proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	2 months ago
Rene Cannao	c8408d76b3	test: add 6 unit test files with 588 assertions (Round 5) New test files (test/tap/tests/unit/): Core: - pgsql_tokenizer_unit-t (65 tests): PgSQL SQL digest — dollar- quoted strings, ::type casts, ARRAY literals, boolean literal replacement, E/B/X/U& prefix strings, comment handling, grouping/IN-list collapsing, edge cases - admin_disk_upgrade_unit-t (60 tests): all 6 disk_upgrade_*() schema migration functions with in-memory SQLite — scheduler v1.2.0→current, mysql_users v1.3.0→current, rest_api_routes v2.0.15→current, mysql_servers v1.1.0→current (with weight cap and compression normalization bugs), pgsql_replication_hostgroups v3.0.1→current, mysql_query_rules v1.2.2→current - gtid_utils_unit-t (37 tests): addGtid interval merging (adjacent, non-consecutive, duplicate, bridge, reverse-order, within- existing), addGtidInterval (update, duplicate, non-overlapping), gtid_executed_to_string formatting - glovars_unit-t (78 tests): GloVars constructor defaults, ProxySQL_Checksum_Value (set/replace_zeros/version/epoch), generate_global_checksum determinism, command-line parsing (--initial/--reload/--no-version-check/-D/--bootstrap/-n/-f/-M) - query_processor_unit-t (+217 tests, 259 total): EXTENDED with PgSQL-specific tests — all-fields rule creation, client_addr wildcard, flagOUT attributes JSON, command counters, stats, rule text 35-column serialization, query_parser_command_type for 100+ PgSQL commands (DML/DDL/views/sequences/functions/ triggers/policies/LISTEN/NOTIFY/VACUUM/TEXT SEARCH/etc.), fast routing hashmap, firewall whitelist, query digests GenAI/MCP (PROXYSQLGENAI=1): - genai_mysql_catalog_unit-t (89 tests): MySQL_Catalog with in-memory SQLite — upsert/get/remove, schema isolation, list with pagination, FTS search, merge, multiple kinds, special character handling Production changes for testability: - include/proxysql_admin.h: add friend class TestDiskUpgrade - test/tap/tests/unit/Makefile: add DEBUG auto-detection from libproxysql.a symbols (fixes struct layout ODR violations when library is built with -DDEBUG) Running totals: 32 test files, 2553 assertions, all passing.	2 months ago

Author

SHA1

Message

Date

Rene Cannao

acaa100dc8

fix: address PR review feedback from coding agents

Actionable fixes from CodeRabbit / agent reviews on PR #5549:

1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t
   used in parse_digest_filter() without direct include

2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix
   check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive.
   This is a real bug fix in production code.

3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count
   dereference with null check to avoid segfault if execute_statement
   returns null

4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset()
   calls on MCP_Threads_Handler that leaked constructor's strdup("")
   allocations for auth fields

5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded
   directory list so new test subdirectories are discovered

6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment
   documenting intentional calloc pattern (ProxySQL_Admin constructor
   has too many daemon deps for unit tests)

Rene Cannao

c8408d76b3

test: add 6 unit test files with 588 assertions (Round 5)

New test files (test/tap/tests/unit/):

  Core:
  - pgsql_tokenizer_unit-t (65 tests): PgSQL SQL digest — dollar-
    quoted strings, ::type casts, ARRAY literals, boolean literal
    replacement, E/B/X/U& prefix strings, comment handling,
    grouping/IN-list collapsing, edge cases
  - admin_disk_upgrade_unit-t (60 tests): all 6 disk_upgrade_*()
    schema migration functions with in-memory SQLite — scheduler
    v1.2.0→current, mysql_users v1.3.0→current, rest_api_routes
    v2.0.15→current, mysql_servers v1.1.0→current (with weight cap
    and compression normalization bugs), pgsql_replication_hostgroups
    v3.0.1→current, mysql_query_rules v1.2.2→current
  - gtid_utils_unit-t (37 tests): addGtid interval merging (adjacent,
    non-consecutive, duplicate, bridge, reverse-order, within-
    existing), addGtidInterval (update, duplicate, non-overlapping),
    gtid_executed_to_string formatting
  - glovars_unit-t (78 tests): GloVars constructor defaults,
    ProxySQL_Checksum_Value (set/replace_zeros/version/epoch),
    generate_global_checksum determinism, command-line parsing
    (--initial/--reload/--no-version-check/-D/--bootstrap/-n/-f/-M)
  - query_processor_unit-t (+217 tests, 259 total): EXTENDED with
    PgSQL-specific tests — all-fields rule creation, client_addr
    wildcard, flagOUT attributes JSON, command counters, stats,
    rule text 35-column serialization, query_parser_command_type
    for 100+ PgSQL commands (DML/DDL/views/sequences/functions/
    triggers/policies/LISTEN/NOTIFY/VACUUM/TEXT SEARCH/etc.),
    fast routing hashmap, firewall whitelist, query digests

  GenAI/MCP (PROXYSQLGENAI=1):
  - genai_mysql_catalog_unit-t (89 tests): MySQL_Catalog with
    in-memory SQLite — upsert/get/remove, schema isolation,
    list with pagination, FTS search, merge, multiple kinds,
    special character handling

Production changes for testability:
- include/proxysql_admin.h: add friend class TestDiskUpgrade
- test/tap/tests/unit/Makefile: add DEBUG auto-detection from
  libproxysql.a symbols (fixes struct layout ODR violations
  when library is built with -DDEBUG)

Running totals: 32 test files, 2553 assertions, all passing.

2 Commits (v3.0-CodeCov0325)