11 Commits (v3.0-CodeCov0325)

Author	SHA1	Message	Date
Rene Cannao	242eef0241	Address code review feedback ... - test_binlog_reader_uses_previous_hostgroup-t.cpp: Use relative path when TEST_DEPS is unset. - test_com_register_slave_enables_fast_forward-t.cpp: Use relative path when TEST_DEPS is unset. - test_ffto_pgsql-t.cpp: Escape credentials before using them in SQL. - charset_unsigned_int-t.cpp: Ensure mysql_b connects and verifies latin1 before reset. - test_cluster_sync-t.cpp: Use mysql_query instead of system() for diagnostics. - test_cluster_sync_config: Replace tracked runtime stderr file with .example and gitignore it. - test_cluster_sync_withmonitor: Use relative path for datadir in config. - test_sqlite3_pass_exts-t.cpp: Use cl.admin_host for admin connection and improve version check. - test_auth_methods-t.cpp: Correctly detect MariaDB and use plan(0) for skip.	2 months ago
Rene Cannao	00e18636c4	test: Align credentials and paths with CI environment in FFT-O and config tests	2 months ago
Rene Cannao	05b723c253	test: Add descriptive diag messages to all test_ffto_* tests ... Add multi-line descriptive messages at startup for: - test_ffto_bypass-t.cpp: Tests FFTO bypass for large queries - test_ffto_mysql-t.cpp: Tests FFTO for MySQL connections - test_ffto_pgsql-t.cpp: Tests FFTO for PostgreSQL connections Explains FFTO (Fast Forward To Optimization) purpose and what each test validates regarding query digest tracking.	3 months ago
Rene Cannao	96b1a8ff3b	fix: Fix test_ffto_pgsql-t test failures ... Three issues fixed: 1. Use TRUNCATE TABLE instead of DELETE for stats_pgsql_query_digest (DELETE doesn't actually clear the stats table) 2. Remove DROP TABLE digest verification - DDL statements are not tracked in stats_pgsql_query_digest 3. Fix SELECT digest pattern - simple query uses ? not $1 Reduced plan count from 22 to 19 to match remaining tests.	3 months ago
Rene Cannao	79c0b383e8	integration: fix pre-CI issues in unified branch	3 months ago
Rene Cannao	90462f6d5a	ffto: harden MySQL/PgSQL observer state handling and align tests/docs ... Address outstanding review findings for FFTO on v3.0-ff_inspect and tighten protocol-state correctness for both engines. MySQL FFTO - Restrict on_close() reporting to true in-flight states and always clear query tracking state after close. - Add explicit active-query cleanup helpers and invoke them on state transitions to IDLE. - Preserve accounting on mid-resultset server ERR packets by reporting current query in READING_COLUMNS/READING_ROWS before reset. - Keep prepared-statement lifecycle cleanup robust (pending prepare cleared on prepare completion paths). MySQL session integration - Extract duplicated FAST_FORWARD client FFTO feed logic into observe_ffto_client_packet() and reuse it from all call sites. PostgreSQL FFTO - Replace regex-based CommandComplete parsing with lightweight token parsing, including NUL/whitespace trimming and strict numeric validation. - Add queued tracking for pipelined extended-protocol executes so query text and response attribution stay aligned under Parse/Bind/Execute pipelining. - Distinguish finalize semantics (execute-finalize on CommandComplete vs sync-finalize on ReadyForQuery) and centralize finalize/activation helpers. - Add frontend Close ('C') handling to evict statement/portal mappings. - Harden client/server message parsing with additional length checks. - Extend affected-row command tag coverage to COPY and MERGE. TAP tests - Stabilize test plans for failure paths by replacing early returns with a fail-and-skip-remaining flow and shared cleanup labels. - Ensure both MySQL and PgSQL FFTO tests preserve planned assertion counts under setup/prepare/execute failures. Documentation - Align FFT0 design doc state/response descriptions with current implementation (ReadyForQuery handling, pipelined queueing, supported PG command tags). - Fix wording/typo issues in protocol section. Validation performed - make -C lib -j4 - make -C test/tap/tests test_ffto_mysql-t test_ffto_pgsql-t -j4 Runtime execution of the two TAP binaries remains environment-dependent (admin endpoint connectivity required).	3 months ago
Rene Cannao	51a0395076	Comprehensive FFTO Enhancements: Performance, Robustness, and Security ... Summary of improvements based on PR reviews: 1. Performance Optimization: - Implemented read-offset indices in MySQLFFTO and PgSQLFFTO to replace linear std::vector::erase calls, reducing per-packet processing from O(N) to O(1). 2. Memory & Resource Safety: - Added explicit handlers for COM_STMT_CLOSE (MySQL) and Close (PostgreSQL) messages to correctly clear internal statement/portal maps and prevent memory leaks. - Enforced *-ffto_max_buffer_size checks on the server-to-client data path, ensuring large responses correctly trigger FFTO bypass. - Improved PostgreSQL message parsing with strnlen and msg_len validation to prevent buffer over-reads and underflows. - Updated MySQL_Session::reset and PgSQL_Session::reset to clear FFTO state during session re-use. 3. Protocol Correctness & Robustness: - Fixed MySQL CLIENT_DEPRECATE_EOF detection to use the correct 0xFE terminator logic. - Implemented PostgreSQL metric accumulation across multiple CommandComplete responses within a single query cycle. - Optimized PostgreSQL row extraction using a static local regex with an improved non-greedy pattern. - Stripped trailing NUL bytes from PostgreSQL Simple Query payloads for accurate digest generation. 4. Code Quality & Test Hardening: - Replaced unsafe sprintf calls with snprintf in all new TAP tests. - Stabilized TAP plans by ensuring a constant number of ok() assertions across all success and failure paths. - Hardened the bypass test to verify total digest counts. - Applied modern C++ standards: replaced <stddef.h> with <cstddef>, used = default for virtual destructors, and added override keywords. - Fixed indentation and removed temporary debug log artifacts from production code.	3 months ago
Rene Cannao	1258a1f2f2	Address PR reviews: improve performance, safety, and robustness of FFTO	3 months ago
Rene Cannao	40aff577a9	Complete FFTO implementation with verified metrics and robust error handling ... - Finalized MySQL and PostgreSQL protocol state machines. - Implemented accurate affected_rows and rows_sent capture. - Added defensive null checks to prevent early-session crashes. - Enhanced TAP tests with result-set draining and success verification. - Verified 100% pass rate for MySQL CRUD, binary protocol, and memory bypass.	3 months ago
Rene Cannao	3dfd6a97d9	Fix FFTO metric parity: capture and report affected_rows and rows_sent ... - Implemented MySQL OK_Packet parsing to extract affected_rows - Implemented PostgreSQL CommandComplete parsing to extract rows affected/sent - Updated TAP tests to validate sum_rows_affected and sum_rows_sent metrics - Fixed incorrect assertion in test_ffto_mysql-t.cpp	3 months ago
Rene Cannao	69acd4b431	Implement FFTO TAP testing suite ... - Added comprehensive MySQL FFTO test (text and binary protocols) - Added comprehensive PgSQL FFTO test (Simple and Extended Query protocols) - Added FFTO memory bypass logic test - Added bash orchestration scripts for each test group - Integrated new tests into the TAP Makefile	3 months ago