7 Commits (v3.0-CodeCov0325)

Author	SHA1	Message	Date
René Cannaò	1549370053	Address review feedback on hostgroups unit tests (PR #5506) ... - test_init.h: remove duplicate test_cleanup_query_processor() declaration (copy-paste artifact at line 130) - test_init.cpp: check MyHGM and PgHGM independently instead of using OR guard, so one can't be left null while the other exists	2 months ago
René Cannaò	e4972ac739	Fix hostgroups_unit-t hang: do not call MyHGM->init() ... MySQL_HostGroups_Manager::init() starts two background threads (HGCU_thread and GTID_syncer_thread) that run forever in a blocking loop. The destructor does not call shutdown() to stop them, so the test process hangs indefinitely after main() returns — std::thread destructor calls std::terminate() on joinable threads. Fix: skip init() entirely. The constructor alone sets up the internal SQLite3 database and all data structures needed for unit testing. The background threads are only needed for real connection pool management (connection reuse, GTID sync), not for server add/remove/ shun operations.	2 months ago
René Cannaò	f772c104de	Add HostGroups Manager unit tests (Phase 2.6, #5478) ... Unit tests for MySQL_HostGroups_Manager and PgSQL_HostGroups_Manager covering 17 test cases. Runs in <0.01s with no infrastructure deps. Test coverage: - Server creation via create_new_server_in_hg() (single, multiple in same HG, different HGs) - Server removal via remove_server_in_hg() (existing, non-existent) - shun_and_killall() (existing server returns true, non-existent false) - set_server_current_latency_us() (latency tracking without crash) - Multiple hostgroups independence (shunning in one HG doesn't affect another) - Duplicate server handling - PgSQL: create, remove, and shun operations with PgSQL-specific types (PgSQL_srv_info_t, PgSQL_srv_opts_t) Infrastructure: - New test_init_hostgroups() / test_cleanup_hostgroups() helpers in test_init.h/.cpp - Creates real MySQL_HostGroups_Manager and PgSQL_HostGroups_Manager with internal SQLite3 databases - Requires Prometheus registry (auto-created if nullptr) Note: Methods like shun_and_killall() and set_server_current_latency_us() acquire their own write locks internally — callers must NOT hold the lock beforehand or a deadlock occurs.	2 months ago
René Cannaò	b25cf6d54f	Address review feedback on query processor unit tests (PR #5487) ... - test_mysql_reset_all: remove 2 leaked mysql_simple_rule() calls whose return values were discarded (memory leak under ASAN) - test_mysql_rule_creation: fix misleading "Don't free" comment — rule is NOT inserted into QP and IS freed manually - test_init.cpp: free individual strings from get_variables_list() before freeing the array (was leaking all variable name strings) - test_init.cpp: fix misleading comment claiming GloMTH/GloPTH are cleaned up by test_cleanup_minimal() — they rely on process exit	2 months ago
René Cannaò	c57bd36e98	Add query_processor_unit-t to build and fix QP initialization ... - tests/unit/Makefile: Register query_processor_unit-t in build system - test_init.cpp: Create MySQL_Threads_Handler and PgSQL_Threads_Handler in test_init_query_processor() since QP constructors read variables from GloMTH/GloPTH. Trigger lazy initialization of VariablesPointers maps via get_variables_list() before constructing QP instances. Add extern declaration for GloPTH (not declared in any header).	2 months ago
René Cannaò	2ae866b59c	Add query_cache_unit-t to build and init Prometheus registry ... - tests/unit/Makefile: Register query_cache_unit-t in the build system - test_init.cpp: Create a real Prometheus registry in test_init_query_ cache() since the Query_Cache constructor registers metrics via GloVars.prometheus_registry (nullptr would crash)	2 months ago
René Cannaò	803eb27590	Add unit test harness: Glo* stubs and component init helpers ... Introduces the test infrastructure foundation for Phase 2.1 (#5473) of the unit testing framework (#5472). This enables unit test binaries to link against libproxysql.a without main.cpp, allowing individual components to be tested in isolation. New files: - test/tap/test_helpers/test_globals.h/.cpp: Stub definitions for all 25 Glo* global pointers and the PROXYSQL_EXTERN-based variable definitions (GloVars, MyHGM, PgHGM, __thread vars, tracked vars). Also stubs symbols from src/ (proxy_tls, SQLite3_Server, binary_sha1) and TAP noise testing functions. - test/tap/test_helpers/test_init.h/.cpp: Component initialization helpers (test_init_minimal, test_init_auth, test_init_query_cache, test_init_query_processor) with matching cleanup functions. All are idempotent and safe to call multiple times.	2 months ago