4 Commits (mysqlx-plugin-impl)

Author	SHA1	Message	Date
Rene Cannao	4203cbeec5	test: Add descriptive diag() messages to all MCP TAP tests ... Add 2-10 line descriptive messages at startup for all mcp_*-t.cpp test files explaining what each test validates. This improves test output readability and helps developers understand test purpose at a glance.	4 months ago
Rene Cannao	76822032af	feat: Add SSL/HTTPS support to MCPClient and fix mcp_stats_refresh-t ... MCPClient changes: - Added use_ssl_ member and set_use_ssl(bool) method - When SSL is enabled, uses https:// and disables cert verification - set_host() and set_port() now respect the use_ssl_ flag mcp_stats_refresh-t test fixes: - Completely rewrote test - original tried to INSERT into read-only table - New test: query Client_Connections_connected, create connections, verify count increases - Try both HTTP and HTTPS when connecting to MCP server - Fixed payload parsing to handle actual response format (variables directly in payload) - Handle both lowercase (variable_name/value) and uppercase field names - Added verbose diagnostics for debugging	4 months ago
Rene Cannao	89da8324ec	test: Add retry mechanism for MCP server startup in mcp_stats_refresh-t ... MCP server may need a moment to start after LOAD MCP VARIABLES TO RUNTIME. Added a retry loop that waits up to 3 seconds (30 retries * 100ms) for the MCP server to become reachable before failing the test.	4 months ago
Rene Cannao	c126e63a23	mcp stats: refresh stats tables under admin mutex before direct reads ... Problem MCP stats tools were querying stats.* tables directly through admindb. Unlike admin-session SQL, that path bypassed GenericRefreshStatistics() and could return stale or empty data for runtime-populated tables. What changed - Updated Stats_Tool_Handler::execute_admin_query() to mirror admin-session semantics for stats reads: - acquire GloAdmin->sql_query_global_mutex - optionally invoke ProxySQL_Admin::GenericRefreshStatistics(sql, ..., false) - execute admindb statement - release sql_query_global_mutex - Added strict input validation and explicit lock/unlock error reporting. - Added refresh_before_query parameter (default true) to avoid duplicate refresh passes for secondary count queries. - Switched secondary COUNT(*) calls in show_processlist/show_queries/ show_errors/show_query_rules to refresh_before_query=false. Documentation - Expanded Doxygen in include/Stats_Tool_Handler.h for execute_admin_query() to document locking, refresh behavior, and performance tradeoff. - Added detailed Doxygen above the execute_admin_query() implementation in lib/Stats_Tool_Handler.cpp. Testing - Added TAP integration test test/tap/tests/mcp_stats_refresh-t.cpp. - The test injects a synthetic stale marker row into stats.stats_mysql_global, calls /mcp/stats show_status, and verifies the marker disappears after refresh-before-read. - Added helper-level Doxygen in the test for setup/parsing behavior. Build verification - Compiled lib object: make -C lib obj/Stats_Tool_Handler.oo - Compiled TAP target: make -C test/tap/tests mcp_stats_refresh-t - Direct runtime execution of the TAP test in this workspace could not fully run because no local admin listener was available (connection to 127.0.0.1:6032 failed).	4 months ago