proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	b187f9ac96	Address review feedback on test harness (PR #5482 ) Fixes from Copilot and Greptile review comments: - test_globals.cpp: Replace fixed-size datadir_buf[256] with std::string to avoid truncation on long TMPDIR paths - test_globals.cpp: Initialize glovars.has_debug to match build type (DEBUG vs release) so component constructors that validate debug compatibility do not abort - test/tap/Makefile: Remove 'tap' dependency from unit_tests target since unit tests compile tap.o directly and don't need the full libtap.so/cpp-dotenv build chain. Also remove $(MAKECMDGOALS) pass- through which would cause failures when invoked as 'make unit_tests' - tests/unit/Makefile: Fix default goal — make 'all' the first target so 'make' without arguments builds unit tests correctly	2 months ago
René Cannaò	803eb27590	Add unit test harness: Glo* stubs and component init helpers Introduces the test infrastructure foundation for Phase 2.1 (#5473) of the unit testing framework (#5472). This enables unit test binaries to link against libproxysql.a without main.cpp, allowing individual components to be tested in isolation. New files: - test/tap/test_helpers/test_globals.h/.cpp: Stub definitions for all 25 Glo* global pointers and the PROXYSQL_EXTERN-based variable definitions (GloVars, MyHGM, PgHGM, __thread vars, tracked vars). Also stubs symbols from src/ (proxy_tls, SQLite3_Server, binary_sha1) and TAP noise testing functions. - test/tap/test_helpers/test_init.h/.cpp: Component initialization helpers (test_init_minimal, test_init_auth, test_init_query_cache, test_init_query_processor) with matching cleanup functions. All are idempotent and safe to call multiple times.	2 months ago

Author

SHA1

Message

Date

René Cannaò

b187f9ac96

Address review feedback on test harness (PR #5482 )

Fixes from Copilot and Greptile review comments:

- test_globals.cpp: Replace fixed-size datadir_buf[256] with
  std::string to avoid truncation on long TMPDIR paths

- test_globals.cpp: Initialize glovars.has_debug to match build type
  (DEBUG vs release) so component constructors that validate debug
  compatibility do not abort

- test/tap/Makefile: Remove 'tap' dependency from unit_tests target
  since unit tests compile tap.o directly and don't need the full
  libtap.so/cpp-dotenv build chain. Also remove $(MAKECMDGOALS) pass-
  through which would cause failures when invoked as 'make unit_tests'

- tests/unit/Makefile: Fix default goal — make 'all' the first target
  so 'make' without arguments builds unit tests correctly

René Cannaò

803eb27590

Add unit test harness: Glo* stubs and component init helpers

Introduces the test infrastructure foundation for Phase 2.1 (#5473)
of the unit testing framework (#5472). This enables unit test binaries
to link against libproxysql.a without main.cpp, allowing individual
components to be tested in isolation.

New files:
- test/tap/test_helpers/test_globals.h/.cpp: Stub definitions for all
  25 Glo* global pointers and the PROXYSQL_EXTERN-based variable
  definitions (GloVars, MyHGM, PgHGM, __thread vars, tracked vars).
  Also stubs symbols from src/ (proxy_tls, SQLite3_Server, binary_sha1)
  and TAP noise testing functions.

- test/tap/test_helpers/test_init.h/.cpp: Component initialization
  helpers (test_init_minimal, test_init_auth, test_init_query_cache,
  test_init_query_processor) with matching cleanup functions. All
  are idempotent and safe to call multiple times.

2 Commits (mysqlx-plugin-impl)