proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	acaa100dc8	fix: address PR review feedback from coding agents Actionable fixes from CodeRabbit / agent reviews on PR #5549: 1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t used in parse_digest_filter() without direct include 2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive. This is a real bug fix in production code. 3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count dereference with null check to avoid segfault if execute_statement returns null 4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset() calls on MCP_Threads_Handler that leaked constructor's strdup("") allocations for auth fields 5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded directory list so new test subdirectories are discovered 6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment documenting intentional calloc pattern (ProxySQL_Admin constructor has too many daemon deps for unit tests)	2 months ago
Rene Cannao	093693ba06	test: add check_groups.py to verify groups.json completeness Python tool that checks consistency between groups.json and compiled TAP test binaries: - WARNING (exit 0): tests in groups.json that aren't compiled yet - ERROR (exit 1): compiled tests missing from groups.json Scans test/tap/tests/, test/tap/tests/unit/, and test/tap/tests_with_deps/ for ELF binaries matching *-t pattern. Usage: python3 test/tap/groups/check_groups.py	2 months ago

Author

SHA1

Message

Date

Rene Cannao

acaa100dc8

fix: address PR review feedback from coding agents

Actionable fixes from CodeRabbit / agent reviews on PR #5549:

1. include/Stats_Tool_Handler.h: add #include <cstdint> — uint64_t
   used in parse_digest_filter() without direct include

2. lib/MCP_Endpoint.cpp: use strncasecmp() for Bearer token prefix
   check — RFC 7235 Section 2.1 says auth-scheme is case-insensitive.
   This is a real bug fix in production code.

3. test/tap/tests/unit/sqlite3db_unit-t.cpp: guard result->rows_count
   dereference with null check to avoid segfault if execute_statement
   returns null

4. test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp: remove memset()
   calls on MCP_Threads_Handler that leaked constructor's strdup("")
   allocations for auth fields

5. test/tap/groups/check_groups.py: use os.walk() instead of hardcoded
   directory list so new test subdirectories are discovered

6. test/tap/tests/unit/admin_disk_upgrade_unit-t.cpp: add comment
   documenting intentional calloc pattern (ProxySQL_Admin constructor
   has too many daemon deps for unit tests)

Rene Cannao

093693ba06

test: add check_groups.py to verify groups.json completeness

Python tool that checks consistency between groups.json and compiled
TAP test binaries:
- WARNING (exit 0): tests in groups.json that aren't compiled yet
- ERROR (exit 1): compiled tests missing from groups.json

Scans test/tap/tests/, test/tap/tests/unit/, and
test/tap/tests_with_deps/ for ELF binaries matching *-t pattern.

Usage: python3 test/tap/groups/check_groups.py

2 Commits (mysqlx-plugin-impl)