proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	2f8e63cef2	Address code review feedback for AI TAP group migration Fixes from PR #5461 review: 1. Fix BASE_GROUP derivation inconsistency in run-tests-isolated.bash - Changed from bash pattern matching `${TAP_GROUP%%-g[0-9]}` to sed - Now uses same pattern as ensure-infras.bash: `sed -E "s/[-_]g[0-9]+.//"` - Removed redundant BASE_GROUP reassignment 2. Update outdated comments in seed files - seed-mysql.sql and seed-pgsql.sql now correctly reference setup-infras.bash 3. Change INSERT OR IGNORE to INSERT OR REPLACE in mcp-config.sql - Ensures credentials are updated on reruns for deterministic state 4. Add shellcheck directives to env.sh files - Added `# shellcheck shell=bash` to ai/env.sh and ai-g1/env.sh 5. Add explicit validation for derived infrastructure names - setup-infras.bash now validates DEFAULT_MYSQL_INFRA and DEFAULT_PGSQL_INFRA - Provides clear error messages if infras.lst is misconfigured 6. Add WORKSPACE export to README examples - All runnable examples now include `export WORKSPACE=$(pwd)` Test verification: - ai-g1 group infrastructure setup works correctly - legacy-g2 group tests still pass (backward compatibility verified)	2 months ago
Rene Cannao	0b9806c46e	Migrate AI TAP group to Unified CI Infrastructure pattern This commit migrates the ai TAP group from its legacy hook-based approach to the standard test/infra/ Unified CI Infrastructure pattern. Changes: - Added generic hook system to infrastructure scripts: * ensure-infras.bash: Executes group-specific setup-infras.bash hook * run-tests-isolated.bash: Executes group-specific pre-cleanup.bash hook - Migrated ai group infrastructure: * Created infras.lst with infra-mysql84 and docker-pgsql16-single * Renamed seed files: mysql-seed.sql -> seed-mysql.sql, pgsql-seed.sql -> seed-pgsql.sql * Deleted legacy docker-compose.yml, docker-compose-init.bash, docker-compose-destroy.bash * Deleted legacy hooks: pre-proxysql.bash, post-proxysql.bash - Added group-specific MCP configuration: * setup-infras.bash: Configures MCP targets and seeds test data * pre-cleanup.bash: Removes MCP configuration after tests * mcp-config.sql: SQL template for MCP setup * cleanup.sql: SQL template for MCP cleanup * seed-mysql.sql & seed-pgsql.sql: Test data for AI tests - Updated documentation in README.md with usage examples Architecture: - ai is the supergroup (defines infrastructure and shared config) - ai-g1, ai-g2, etc. are subgroups (define test sets in groups.json) - Group-specific hooks live in test/tap/groups/ai/ directory - Infrastructure scripts remain generic and delegate to group hooks	2 months ago

Author

SHA1

Message

Date

Rene Cannao

2f8e63cef2

Address code review feedback for AI TAP group migration

Fixes from PR #5461 review:

1. Fix BASE_GROUP derivation inconsistency in run-tests-isolated.bash
   - Changed from bash pattern matching `${TAP_GROUP%%-g[0-9]*}` to sed
   - Now uses same pattern as ensure-infras.bash: `sed -E "s/[-_]g[0-9]+.*//"`
   - Removed redundant BASE_GROUP reassignment

2. Update outdated comments in seed files
   - seed-mysql.sql and seed-pgsql.sql now correctly reference setup-infras.bash

3. Change INSERT OR IGNORE to INSERT OR REPLACE in mcp-config.sql
   - Ensures credentials are updated on reruns for deterministic state

4. Add shellcheck directives to env.sh files
   - Added `# shellcheck shell=bash` to ai/env.sh and ai-g1/env.sh

5. Add explicit validation for derived infrastructure names
   - setup-infras.bash now validates DEFAULT_MYSQL_INFRA and DEFAULT_PGSQL_INFRA
   - Provides clear error messages if infras.lst is misconfigured

6. Add WORKSPACE export to README examples
   - All runnable examples now include `export WORKSPACE=$(pwd)`

Test verification:
- ai-g1 group infrastructure setup works correctly
- legacy-g2 group tests still pass (backward compatibility verified)

Rene Cannao

0b9806c46e

Migrate AI TAP group to Unified CI Infrastructure pattern

This commit migrates the ai TAP group from its legacy hook-based approach
to the standard test/infra/ Unified CI Infrastructure pattern.

Changes:
- Added generic hook system to infrastructure scripts:
  * ensure-infras.bash: Executes group-specific setup-infras.bash hook
  * run-tests-isolated.bash: Executes group-specific pre-cleanup.bash hook

- Migrated ai group infrastructure:
  * Created infras.lst with infra-mysql84 and docker-pgsql16-single
  * Renamed seed files: mysql-seed.sql -> seed-mysql.sql, pgsql-seed.sql -> seed-pgsql.sql
  * Deleted legacy docker-compose.yml, docker-compose-init.bash, docker-compose-destroy.bash
  * Deleted legacy hooks: pre-proxysql.bash, post-proxysql.bash

- Added group-specific MCP configuration:
  * setup-infras.bash: Configures MCP targets and seeds test data
  * pre-cleanup.bash: Removes MCP configuration after tests
  * mcp-config.sql: SQL template for MCP setup
  * cleanup.sql: SQL template for MCP cleanup
  * seed-mysql.sql & seed-pgsql.sql: Test data for AI tests

- Updated documentation in README.md with usage examples

Architecture:
- ai is the supergroup (defines infrastructure and shared config)
- ai-g1, ai-g2, etc. are subgroups (define test sets in groups.json)
- Group-specific hooks live in test/tap/groups/ai/ directory
- Infrastructure scripts remain generic and delegate to group hooks

2 Commits (mysqlx-plugin-impl)