9 Commits (mysqlx-plugin-impl)

Author	SHA1	Message	Date
Javier Jaramago Fernández	64b16172c7	Change 'COM_STMT_EXECUTE' params length decoding ... According to MySQL protocol, variable length strings are encoded using length encoded integers. For reference, see: - https://dev.mysql.com/doc/dev/mysql-server/9.4.0/page_protocol_com_stmt_execute.html - https://dev.mysql.com/doc/dev/mysql-server/9.4.0/page_protocol_basic_dt_integers.html#a_protocol_type_int2 The protocol specifies that values greater than 2^24 (16777216) should be encoded using '0xFE + 8-byte integer'. Yet, in reality MySQL ignores the upper section of these 8-byte integers, treating them effectively like '4-bytes'. For the sake of compatibility this commit changes the decoding behavior for 'COM_STMT_EXECUTE' to match MySQL one. This different is subtle but important, since in practice MySQL itself doesn't use the '8 bytes' from the field. This means that connectors that are compatible with MySQL could find issues when sending these packets through ProxySQL (like NodeJS 'mysql2' connector which writes the 8-bytes as a 4-bytes duplication, motivating these changes), situation that could result in rejection due to malformed packet detection (or crashes/invalid handling in the worse case scenario). The previous decoding function is now renamed into 'mysql_decode_length_ll' to honor MySQL naming 'net_field_length_ll'. For now, this protocol change is limited to 'COM_STMT_EXECUTE'.	6 months ago
Rene Cannao	0481ab5936	Adding some timers for debugging purposes ... Adding Timers in Base_Thread to count the number of time and elapsed time of when Session::handler() and Connection::handler() are called. This feature is disabled by default. Timers are enabled only if in proxysql_macros.h the following is defined: #define ENABLE_TIMER true The default: #define ENABLE_TIMER false	2 years ago
René Cannaò	c1c0617995	Wrong decoding causes crash #1350 ... Wrong decoding in MySQL protocol for field bigger than 16MB causes crash. The only code path affected by this seems to be reading parameters from prepared statements.	7 years ago
René Cannaò	362c051d53	Adding likely/unlikely in header	9 years ago
René Cannaò	a6c53d0d12	Revert "Refactor header includes."	10 years ago
Maxim Bublis	30dbcc21a8	Refactor header includes. ... * reduce build time by 25%; * remove circular dependency on `cpp.h` and other headers. * fixes issue with `my_global.h` from mariadbclient which redefines `__attribute__`, that leads to broken STL and GCC intrinsics if `<algorithm>` wasn't included prior including this header; * fixes another issue with redefined `__attribute__` which leads to `_conn_exchange_t` not being aligned to cache line size; * removes `pthread_setstacksize` calls as `my_global.h` redefines `pthread_setstacksize` to be `pthread_dummy(0)` which led to stack size being never adjusted; * add missing include guards to some headers; * remove unused proxysql_hash.h header.	10 years ago
René Cannaò	304944a194	Continuing work to support prepared statements ... Still buggy	10 years ago
René Cannaò	125114b0d5	Work for facilitate debug in MySQL Thread (issue #198) ... In order to facilitate the reuse of code in Standard_ProxySQL_Admin.cpp : - moved remove_spaces() from Standard_ProxySQL_Admin.cpp to gen_utils.cpp - moved Standard_ProxySQL_Admin::SQLite3_to_MySQL() to MySQL_Session::SQLite3_to_MySQL() Moved few macros from Standard_Query_Processor.cpp to proxysql_macros.h Added functions: - MySQL_Session::SQL3_Session_status() - MySQL_Session::handler___status_WAITING_CLIENT_DATA___STATE_SLEEP___MYSQL_COM_QUERY_debug() - Standard_MySQL_Thread::SQL3_Thread_status() - MySQL_Threads_Handler::SQL3_Threads_status() (not completed) Modified class Query_Info to copy queries : this can be a small performance penalty, but can improve functionalities Added mysql commands: - DBG SESSION STATUS - DBG THREAD STATUS - DBG THREADS STATUS Added variable MySQL_Thread::thread_mutex , a mutex to protect the thread: this will be used to implement access to MySQL Thread via Admin MySQL_Thread now have a new per thread variable updated via Admin Interface : - mysql_thread___session_debug ProxySQL_Poll now counts number of poll() in variable "loops" If mysql_thread___session_debug is enabled and a query starts with "dbg " it is interpreted as a command for proxysql. In Standard_ProxySQL_Admin added a variable admin_mutex to protect the update of statistics. Fixed minor bugs.	11 years ago
René Cannaò	68d6786320	first commit	12 years ago