4 Commits (fix/pgsql-unix-socket)

Author	SHA1	Message	Date
Rene Cannao	960c8bcb73	fix(session): SET STATEMENT ... FOR detection tolerates any whitespace ... PR #5708 added detection for MariaDB's `SET STATEMENT … FOR …` syntax to keep ProxySQL from invoking `unable_to_parse_set_statement()` and locking the session to a single hostgroup. The detection at `lib/MySQL_Session.cpp` was: if (strncasecmp(nq.c_str(), "SET STATEMENT ", 14) == 0 && strcasestr(nq.c_str(), " FOR ")) { return false; } `strcasestr(nq, " FOR ")` is a literal-substring search requiring a space BOTH before and after the FOR keyword. A customer report (see PR #5708 thread) reproduced the same error 9006 as before the fix by typing the statement across multiple lines at the mysql client prompt — the character after FOR is then a newline, not a space, so the detection misses, the code falls through to the regular SET parser, the parser doesn't know SET STATEMENT, and the hostgroup is locked to the user's default. The next non-default-hostgroup query fails with 9006. Verified with a standalone strcasestr probe: q1 (customer multi-line): strcasestr(" FOR ") matches ? NO q2 (existing TAP single-line): YES The fix uses `dig` (the digest text) for the detection instead of `nq` (the raw query). `dig` is whitespace-normalised by the digest builder, so " FOR " always has a space on both sides regardless of how the client formatted the query. This is consistent with the prefix check 35 lines above, which already uses `dig` for keyword detection. == Test coverage == `test/tap/tests/test_set_statement_for-t.cpp` previously had `plan(5)` and self-skipped on non-MariaDB backends via `skip_all()`. It was also registered ONLY in MySQL-family TAP groups (`legacy-g2`, `mysql84-g2`, etc.). The net effect was that the test self-skipped on every CI run since it was added — never actually executing an assertion in CI. The customer's bug regressed entirely unnoticed. This commit: 1. Removes the runtime MariaDB-detection helper and the `skip_all` call. A misregistered test should fail loudly, not silently skip; correct registration is enforced through the groups.json layer instead. 2. Moves the groups.json registration from the MySQL-only groups to `mariadb10-galera-g2`, which actually provides a MariaDB backend. 3. Adds four new test cases (assertions 6–13) covering the customer whitespace shapes that strcasestr (" FOR ") missed: newline, tab, CRLF, and multiple spaces between FOR and the inner statement. Each case verifies (a) the SET STATEMENT succeeds, and (b) a follow-up plain SELECT succeeds (i.e. no hostgroup lock persists — the customer's actual failure mode). Verified locally on TAP group mariadb10-galera-g2 against MariaDB 10.11.9: 13/13 ok, RC=0. A separate framework-cleanup follow-up should remove `skip_all()` from `test/tap/tap/tap.{h,cpp}` entirely and convert the other four callers (`test_mysqlx_e2e_*`, `test_mysqlx_route_drop_inflight-t`, `test_mysqlx_sigterm_inflight-t`) to either fail loudly or move to appropriately-gated TAP groups.	1 month ago
Rene Cannao	b1ace3f62b	fix: distinguish connection errors from non-MariaDB in test ... Address review feedback: detect_mariadb() now returns three states (1=MariaDB, 0=not MariaDB, -1=error) so that connection failures cause the test to fail rather than silently skip.	2 months ago
Rene Cannao	c4666ae8f3	test: improve SET STATEMENT ... FOR TAP test readability ... Rewrite test_set_statement_for-t.cpp with: - Clear diag() output explaining what each test does and why - Explicit description of the bug being tested (hostgroup lock) - Verify the query returns the correct result, not just succeeds - 5 tests: basic, result correctness, multi-variable, no-lock, case-insensitive	2 months ago
Rene Cannao	0c832e5ced	feat: add support for MariaDB SET STATEMENT ... FOR passthrough ... ProxySQL now recognizes MariaDB's SET STATEMENT ... FOR syntax and forwards it to the backend without locking the hostgroup. Previously, this syntax was unrecognized and triggered unable_to_parse_set_statement(), which locked the session to a single hostgroup. This caused error 9006 on subsequent queries targeting different hostgroups. The implementation is a minimal passthrough: ProxySQL detects the "SET STATEMENT <vars> FOR <query>" pattern, forwards the query as-is to the backend, and does not lock the hostgroup. Variable tracking is not needed since SET STATEMENT variables are temporary (scoped to the single statement execution). Changes: - Add SET STATEMENT ... FOR detection in MySQL_Session.cpp before the SET parser, returning false without lock_hostgroup - Add new TAP test (test_set_statement_for-t.cpp) that verifies: - Basic SET STATEMENT ... FOR succeeds - Multi-variable SET STATEMENT ... FOR succeeds - No hostgroup lock persists after execution - Case-insensitive matching works - Register test in groups.json (legacy-g2, mysql84-g2, etc.) Ref: sub-issue 2 of #5686	2 months ago