proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	ed0010e8fa	test(tap): fix setup-infras.bash and pgsql-unix_socket-t after local run Differences from the initial commit surfaced when running the test locally against docker-pgsql16-single: setup-infras.bash: - Use the PgSQL admin port 6132 instead of the MySQL admin port 6032. ProxySQL exposes both; 6132 is the one psql can drive. - Add a 'monitor' pgsql_user (default pgsql-monitor_username) so the monitor can authenticate and increment connect_check_OK. - Shorten pgsql-monitor_connect_interval to 1000ms and persist via LOAD/SAVE so the test sees a counter tick within a few seconds. Split into separate docker exec calls because the pgsql admin parser mis-handles 'value; <next-stmt>' by applying the value text to the next variable. pgsql-unix_socket-t.cpp: - Drop the SET pgsql-monitor_connect_interval from the test body; the setup hook already handles it (and trying to set it from the test with a semicolon-mangled multi-statement clobbered every monitor variable with '1000', including the username). - Use the real monitor counter names: PgSQL_Monitor_connect_check_OK and PgSQL_Monitor_connect_check_ERR (not PgSQL_Monitor_Connections_OK/ERR, which don't exist).	3 weeks ago
Rene Cannao	6e23f405c2	test(tap): fix plan(7)->plan(6) and unused loop var in pgsql-socket CodeRabbit flagged two issues on PR #5844: - pgsql-unix_socket-t.cpp:96 declared plan(7) but only six ok() calls execute (the SELECT 1 ok() in the if/else branches is mutually exclusive, so only one of them runs). - pgsql-socket/setup-infras.bash:29 used 'i' as a loop variable but never referenced it; rename to '_' for shellcheck SC2034.	3 weeks ago
Rene Cannao	49371fd647	pgsql: omit port= when port==0 (Unix socket support) Closes #5837. When pgsql_servers.port is 0 the hostname is documented to be a Unix-domain socket path. libpq rejects 'port=0' with 'invalid port number: "0"', so the field has to be omitted from the conninfo string. Add an 'if (port != 0)' guard at the three call sites that build libpq conninfo (client connect, backend kill, monitor) instead of creating a new helper header for a 3-line check. Add a regression TAP test (pgsql-socket-g1) that configures a pgsql_servers row with hostname='/var/run/postgresql-shared' and port=0, then exercises both the client connect path and the pgsql monitor. The infra uses a host-directory bind mount shared between the pgdb1 container (which creates the socket) and the ProxySQL container (which reads it), following the same pattern already used for the SSL cert directory in the same infra.	3 weeks ago

Author

SHA1

Message

Date

Rene Cannao

ed0010e8fa

test(tap): fix setup-infras.bash and pgsql-unix_socket-t after local run

Differences from the initial commit surfaced when running the test
locally against docker-pgsql16-single:

setup-infras.bash:
- Use the PgSQL admin port 6132 instead of the MySQL admin port 6032.
  ProxySQL exposes both; 6132 is the one psql can drive.
- Add a 'monitor' pgsql_user (default pgsql-monitor_username) so the
  monitor can authenticate and increment connect_check_OK.
- Shorten pgsql-monitor_connect_interval to 1000ms and persist via
  LOAD/SAVE so the test sees a counter tick within a few seconds.
  Split into separate docker exec calls because the pgsql admin
  parser mis-handles 'value; <next-stmt>' by applying the value
  text to the next variable.

pgsql-unix_socket-t.cpp:
- Drop the SET pgsql-monitor_connect_interval from the test body;
  the setup hook already handles it (and trying to set it from the
  test with a semicolon-mangled multi-statement clobbered every
  monitor variable with '1000', including the username).
- Use the real monitor counter names: PgSQL_Monitor_connect_check_OK
  and PgSQL_Monitor_connect_check_ERR (not
  PgSQL_Monitor_Connections_OK/ERR, which don't exist).

Rene Cannao

6e23f405c2

test(tap): fix plan(7)->plan(6) and unused loop var in pgsql-socket

CodeRabbit flagged two issues on PR #5844:
- pgsql-unix_socket-t.cpp:96 declared plan(7) but only six ok()
  calls execute (the SELECT 1 ok() in the if/else branches is
  mutually exclusive, so only one of them runs).
- pgsql-socket/setup-infras.bash:29 used 'i' as a loop variable
  but never referenced it; rename to '_' for shellcheck SC2034.

Rene Cannao

49371fd647

pgsql: omit port= when port==0 (Unix socket support)

Closes #5837.

When pgsql_servers.port is 0 the hostname is documented to be a
Unix-domain socket path. libpq rejects 'port=0' with 'invalid port
number: "0"', so the field has to be omitted from the conninfo
string. Add an 'if (port != 0)' guard at the three call sites that
build libpq conninfo (client connect, backend kill, monitor) instead
of creating a new helper header for a 3-line check.

Add a regression TAP test (pgsql-socket-g1) that configures a
pgsql_servers row with hostname='/var/run/postgresql-shared' and
port=0, then exercises both the client connect path and the
pgsql monitor. The infra uses a host-directory bind mount shared
between the pgdb1 container (which creates the socket) and the
ProxySQL container (which reads it), following the same pattern
already used for the SSL cert directory in the same infra.

3 Commits (fix/pgsql-unix-socket)