proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	0d39ac6991	build: kill PROXYSQLGENAI flag, PROXYSQL40=1 builds all plugins PROXYSQLGENAI was a leftover from before the genai plugin carve-out. All genai/MCP/AI/RAG code now lives in plugins/genai/ as a runtime loadable .so. Since the plugin chassis (PROXYSQL40=1) already builds and loads the genai .so, a separate flag serves no purpose. Entrypoint changes (all three -- rhel, suse, deb): - Build: pass PROXYSQL40=1 (not PROXYSQLGENAI=1) to make. - Packaging: copy genai .so alongside mysqlx when PROXYSQL40=1. - protobuf-devel install: gate on PROXYSQL40=1 (needed for mysqlx). Automated packaging verification added to all entrypoints: rpm -qpl / dpkg -c confirms both .so files are in the package. ELF smoke test: validates .so is a valid shared object exporting proxysql_plugin_descriptor_v1 symbol. Fails build on mismatch. Test Makefiles: PROXYSQLGENAI -> PROXYSQL40 for the vec.o link gate (test/tap/tests/Makefile and test/deps/cluster_simulator/Makefile). Updated remaining PROXYSQLGENAI references to PROXYSQL40 in: CLAUDE.md, include/cpp.h, lib/proxy_sqlite3_symbols.cpp, src/main.cpp (3x comments), proxysql.spec, test/infra/control/start-proxysql-isolated.bash, test/infra/control/run-unit-tests-asan-coverage.bash, and 14 genai test file comments.	1 month ago
Rene Cannao	a9f2eaaa13	feat: remove PROXYSQLGENAI flag, genai now builds under PROXYSQL40 (issue #5722 ) PROXYSQLGENAI flag eliminated entirely. PROXYSQL40=1 now unconditionally builds the genai plugin alongside core. All #ifdef PROXYSQLGENAI replaced with #ifdef PROXYSQL40 in source, Makefiles, and 61 CI workflows.	2 months ago
Rene Cannao	ece648fc16	test: add 6 more unit test files with 550 assertions (Tier 2+3) Expand coverage for firewall whitelist, statistics, config validation, logging, and GenAI thread variable management. New test files (test/tap/tests/unit/): Core: - query_processor_firewall_unit-t (44 tests): load_firewall() users/rules/sqli fingerprints, find_firewall_whitelist_user/rule, whitelisted_sqli_fingerprint, reload/clear, memory accounting, PgSQL parity, multiple digest bsearch - statistics_unit-t (20 tests, 95 with TSDB): timer functions (timetoget for MySQL threads, query cache, CPU, logger, digest), TSDB set/get/has variable with range validation, insert/query metrics, backend health, downsampling, retention - config_validation_unit-t (54 tests): addField() formatting and escaping, validate_backend_users() duplicate detection for MySQL/PgSQL, validate_backend_servers() with field aliases and default ports, validate_proxysql_servers() - log_utils_unit-t (42 tests): LogBuffer append/write/operator<< overloads, data() accessor, reset(), should_log() rate limiting, GetLogBufferThreadContext() lifecycle GenAI/MCP (PROXYSQLGENAI=1): - genai_mcp_thread_unit-t (197 tests): MCP_Threads_Handler constructor defaults (26 vars), boolean/port/timeout/string variable set/get with range validation, has_variable, get_variables_list, null safety, target auth map - genai_thread_unit-t (193 tests): GenAI_Threads_Handler constructor defaults (31 vars), integer range validation for 15+ variables, double/boolean/string round-trips, has_variable, get_variables_list, overwrite and rejection persistence Note: found potential bug — llm_cache_enabled has no get/set handler despite being listed in variables array Minimal production change: - include/proxysql_config.h: add friend class for test access to private validate_backend_users/servers/proxysql_servers methods Running totals: 21 test files, 1268 assertions, all passing.	3 months ago

Author

SHA1

Message

Date

Rene Cannao

0d39ac6991

build: kill PROXYSQLGENAI flag, PROXYSQL40=1 builds all plugins

PROXYSQLGENAI was a leftover from before the genai plugin carve-out.
All genai/MCP/AI/RAG code now lives in plugins/genai/ as a runtime
loadable .so.  Since the plugin chassis (PROXYSQL40=1) already
builds and loads the genai .so, a separate flag serves no purpose.

Entrypoint changes (all three -- rhel, suse, deb):
- Build: pass PROXYSQL40=1 (not PROXYSQLGENAI=1) to make.
- Packaging: copy genai .so alongside mysqlx when PROXYSQL40=1.
- protobuf-devel install: gate on PROXYSQL40=1 (needed for mysqlx).

Automated packaging verification added to all entrypoints:
  rpm -qpl / dpkg -c confirms both .so files are in the package.
ELF smoke test: validates .so is a valid shared object exporting
  proxysql_plugin_descriptor_v1 symbol.  Fails build on mismatch.

Test Makefiles: PROXYSQLGENAI -> PROXYSQL40 for the vec.o link gate
(test/tap/tests/Makefile and test/deps/cluster_simulator/Makefile).

Updated remaining PROXYSQLGENAI references to PROXYSQL40 in:
CLAUDE.md, include/cpp.h, lib/proxy_sqlite3_symbols.cpp,
src/main.cpp (3x comments), proxysql.spec,
test/infra/control/start-proxysql-isolated.bash,
test/infra/control/run-unit-tests-asan-coverage.bash,
and 14 genai test file comments.

Rene Cannao

a9f2eaaa13

feat: remove PROXYSQLGENAI flag, genai now builds under PROXYSQL40 (issue #5722 )

PROXYSQLGENAI flag eliminated entirely. PROXYSQL40=1 now unconditionally
builds the genai plugin alongside core. All #ifdef PROXYSQLGENAI replaced
with #ifdef PROXYSQL40 in source, Makefiles, and 61 CI workflows.

Rene Cannao

ece648fc16

test: add 6 more unit test files with 550 assertions (Tier 2+3)

Expand coverage for firewall whitelist, statistics, config validation,
logging, and GenAI thread variable management.

New test files (test/tap/tests/unit/):

  Core:
  - query_processor_firewall_unit-t (44 tests): load_firewall()
    users/rules/sqli fingerprints, find_firewall_whitelist_user/rule,
    whitelisted_sqli_fingerprint, reload/clear, memory accounting,
    PgSQL parity, multiple digest bsearch
  - statistics_unit-t (20 tests, 95 with TSDB): timer functions
    (timetoget for MySQL threads, query cache, CPU, logger, digest),
    TSDB set/get/has variable with range validation, insert/query
    metrics, backend health, downsampling, retention
  - config_validation_unit-t (54 tests): addField() formatting and
    escaping, validate_backend_users() duplicate detection for
    MySQL/PgSQL, validate_backend_servers() with field aliases and
    default ports, validate_proxysql_servers()
  - log_utils_unit-t (42 tests): LogBuffer append/write/operator<<
    overloads, data() accessor, reset(), should_log() rate limiting,
    GetLogBufferThreadContext() lifecycle

  GenAI/MCP (PROXYSQLGENAI=1):
  - genai_mcp_thread_unit-t (197 tests): MCP_Threads_Handler
    constructor defaults (26 vars), boolean/port/timeout/string
    variable set/get with range validation, has_variable,
    get_variables_list, null safety, target auth map
  - genai_thread_unit-t (193 tests): GenAI_Threads_Handler
    constructor defaults (31 vars), integer range validation for
    15+ variables, double/boolean/string round-trips, has_variable,
    get_variables_list, overwrite and rejection persistence
    Note: found potential bug — llm_cache_enabled has no get/set
    handler despite being listed in variables array

Minimal production change:
- include/proxysql_config.h: add friend class for test access to
  private validate_backend_users/servers/proxysql_servers methods

Running totals: 21 test files, 1268 assertions, all passing.

3 Commits (feature/pgsql-native-backend-protocol)