proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	0d39ac6991	build: kill PROXYSQLGENAI flag, PROXYSQL40=1 builds all plugins PROXYSQLGENAI was a leftover from before the genai plugin carve-out. All genai/MCP/AI/RAG code now lives in plugins/genai/ as a runtime loadable .so. Since the plugin chassis (PROXYSQL40=1) already builds and loads the genai .so, a separate flag serves no purpose. Entrypoint changes (all three -- rhel, suse, deb): - Build: pass PROXYSQL40=1 (not PROXYSQLGENAI=1) to make. - Packaging: copy genai .so alongside mysqlx when PROXYSQL40=1. - protobuf-devel install: gate on PROXYSQL40=1 (needed for mysqlx). Automated packaging verification added to all entrypoints: rpm -qpl / dpkg -c confirms both .so files are in the package. ELF smoke test: validates .so is a valid shared object exporting proxysql_plugin_descriptor_v1 symbol. Fails build on mismatch. Test Makefiles: PROXYSQLGENAI -> PROXYSQL40 for the vec.o link gate (test/tap/tests/Makefile and test/deps/cluster_simulator/Makefile). Updated remaining PROXYSQLGENAI references to PROXYSQL40 in: CLAUDE.md, include/cpp.h, lib/proxy_sqlite3_symbols.cpp, src/main.cpp (3x comments), proxysql.spec, test/infra/control/start-proxysql-isolated.bash, test/infra/control/run-unit-tests-asan-coverage.bash, and 14 genai test file comments.	1 month ago
Rene Cannao	a9f2eaaa13	feat: remove PROXYSQLGENAI flag, genai now builds under PROXYSQL40 (issue #5722 ) PROXYSQLGENAI flag eliminated entirely. PROXYSQL40=1 now unconditionally builds the genai plugin alongside core. All #ifdef PROXYSQLGENAI replaced with #ifdef PROXYSQL40 in source, Makefiles, and 61 CI workflows.	2 months ago
Rene Cannao	dffa89de7a	fix(ci): repair non-PROXYSQL40 dbg builds + genai unit-test linking CI surfaced two separate build breakages that had been latent since the carve-out steps but only became visible once they ran on the right matrix variants. # lib/MySQL_Session.cpp + lib/PgSQL_Session.cpp: chassis dispatch # block needs PROXYSQL40 guard The query-hook dispatch I added in Step 2.2 references chassis types (`ProxySQL_PluginProtocol`, `ProxySQL_PluginQueryHookPayload`, `ProxySQL_PluginQueryHookResult`, etc.) without an `#ifdef PROXYSQL40` guard. Those types are only declared when ProxySQL_Plugin.h is compiled with `-DPROXYSQL40` — v3.0/v3.1 dbg builds (debian12,-dbg and ubuntu22,-tap on the CI matrix) define neither, so the lib step fails: MySQL_Session.cpp:4477:127: error: 'ProxySQL_PluginProtocol' has not been declared MySQL_Session.cpp:4477:85: error: 'proxysql_has_configured_plugin _query_hook' was not declared in this scope [+ 7 more identical errors in PgSQL_Session.cpp] Wrap both dispatch blocks (MySQL_Session.cpp:~4477-4509, PgSQL_Session.cpp:~2414-2446) in `#ifdef PROXYSQL40`. The block was only meaningful when the chassis is present anyway — the call to `proxysql_has_configured_plugin_query_hook` short-circuits to false when no plugin is loaded, but the SYMBOL doesn't exist at all in non-chassis builds. # test/tap/tests/unit/Makefile: PROXYSQLGENAI autodetect probe was # defining the macro without a way to satisfy the resulting linker # requirements Pre-Step-7 the autodetect probed for `MCP_Tool_Handler` in libproxysql.a; this symbol is plugin-side now, so the probe never matches and PROXYSQLGENAI stays empty. My previous attempt to "fix" the autodetect (probing `invoke_register_schemas_phase`) made it match again — but that defines PROXYSQLGENAI for the WHOLE unit- test build, including tests like `genai_llm_clients_unit-t` and `genai_mcp_endpoint_unit-t` that pull in plugin headers AND instantiate plugin classes. Those classes' definitions live in plugin .cpp files that the unit-test build does NOT link, so the result was: genai_llm_clients_unit-t.cpp:201: undefined reference to `LLM_WriteCallback(void, unsigned long, ...)' [+5 more] Solution: never auto-define PROXYSQLGENAI for the unit-test build. Tests that legitimately exercise plugin internals (`genai_plugin_anomaly_unit-t`, `genai_plugin_backend_client_unit-t`, `genai_plugin_load_unit-t`, `genai_fts_string_unit-t`) declare a new GENAI_PLUGIN_DEFINES variable on their dedicated rule and add the specific plugin .cpp files they need to the link line. Every other genai__unit-t test guards its body in `#ifdef PROXYSQLGENAI ... #else SKIP #endif`, so falling through to the SKIP path keeps CI green. Coverage for those tests in non-genai builds was already zero — the autodetect was never activating PROXYSQLGENAI for them in practice (the probed symbol moved out in Step 6). This commit documents that reality instead of pretending to maintain coverage that didn't exist. # test/tap/tests/unit/genai_fts_string_unit-t.cpp: stub for # MySQL_Tool_Handler::execute_query The new dedicated rule for genai_fts_string_unit-t compiles plugins/genai/src/MySQL_FTS.cpp directly into the test binary. MySQL_FTS::index_table calls MySQL_Tool_Handler::execute_query — but this test only exercises the pure string helpers (sanitize_name / escape_*) and never reaches index_table, so the call site is unreachable at runtime. The linker still needs a body, so we provide an empty stub directly in the test .cpp. The real implementation lives in MySQL_Tool_Handler.cpp which we can't link without dragging in the full plugin runtime stack.	2 months ago
Rene Cannao	accc68c9dc	test: add 11 new unit test files with 520 assertions for lib/ coverage Add targeted unit tests for pure functions and isolated components across lib/, increasing test coverage for both core utilities and GenAI/MCP components. New test files (test/tap/tests/unit/): Core utilities: - pgsql_variables_validator_unit-t (75 tests): bool, float, string, memory size, search_path, and client_encoding validators - gen_utils_unit-t (28 tests): mywildcmp wildcard matching, escape_string_single_quotes, Proxy_file_regular - mysql_encode_unit-t (23 tests): mysql_encode_length, CPY3/CPY8, proxy_my_crypt XOR, write_encoded_length - proxysql_utils_unit-t (23 tests): hex/unhex, sql_escape, split_str, replace_str, generate_multi_rows_query, checksums - proxy_protocol_unit-t (22 tests): PROXY v1 header parsing, subnet validation, IPv4/IPv6 network matching - pgsql_error_helper_unit-t (139 tests): SQLSTATE code mapping, all 38 error class branches, severity classification, fill/reset - pgsql_txn_state_unit-t (54 tests): TxnCmdParser for BEGIN, COMMIT, ROLLBACK, SAVEPOINT, RELEASE, AND CHAIN variants - sqlite3db_unit-t (21 tests): execute, return_one_int, check_table_structure, build_table, row ops, locking GenAI/MCP (PROXYSQLGENAI=1): - genai_stats_parsing_unit-t (79 tests): parse_server_filter, parse_digest_filter, parse_ll_or_zero, get_interval_config, calculate_percentile - genai_fts_string_unit-t (32 tests): MySQL_FTS sanitize_name, escape_identifier, escape_sql, table name construction - genai_anomaly_unit-t (24 tests): normalize_query SQL normalization, check_sql_injection pattern detection Minimal production changes for GenAI testability: - include/Anomaly_Detector.h: add friend class for test access - include/Stats_Tool_Handler.h: declare 4 parsing helpers, move 2 pure computation methods (get_interval_config, calculate_percentile) to public - lib/Stats_Tool_Handler.cpp: remove static from 4 free helper functions (no behavioral change, only linkage visibility)	3 months ago

4 Commits (feature/pgsql-native-backend-protocol)