4 Commits (feature/pgsql-native-backend-protocol)

Author	SHA1	Message	Date
Rene Cannao	7de1ae3dcd	test(mysqlx): address PR-#5700 review feedback ... Two reviewers flagged the same area in the previous commit (ec0c5... oh wait wrong sha — eebfbde2b). Both findings legitimate and applied. # CodeRabbit nitpick: BAIL_OUT on Phase B failure If invoke_register_schemas_phase() returns false, every subsequent assertion in this test depends on tables(kind) state populated by Phase B. They would all spuriously fail as "not ok" and obscure the root cause (the same logic the existing load() guard already uses on line 41 — bail on the prerequisite, don't drown the operator in downstream noise). # Gemini: capture return value explicitly + drop redundant err.clear() Verified Gemini's claim by reading lib/ProxySQL_PluginManager.cpp: - invoke_register_schemas_phase clears err at line 417 (entry). - init_all clears err at line 489 (entry). So the previous commit's err.clear() between the two calls was dead code; removing it. And since reading err after a successful return is meaningless (it's empty by contract), the success/failure check should go through the bool return, not err.empty(). Matches the load() pattern at line 37 ("const bool loaded = mgr.load(...)") for consistency. # Verified locally $ ./test_mysqlx_plugin_load-t 1..7 ok 1 - load mysqlx plugin succeeds ok 2 - invoke_register_schemas_phase registers mysqlx schema ok 3 - init_all completes after schema registration ok 4 - mysqlx_users registered in admin_db ok 5 - mysqlx_users registered in config_db ok 6 - mysqlx_users admin schema includes allowed_auth_methods ok 7 - mysqlx_users config schema includes backend_auth_mode	2 months ago
Rene Cannao	eebfbde2b3	fix(test): test_mysqlx_plugin_load-t needs Phase B between load and init ... Pre-existing test bug surfaced by CI-unit-tests-asan-coverage on plugin-chassis (run 25202654334, head bb199c6c). 4 of 6 assertions failed: not ok 3 - mysqlx_users registered in admin_db not ok 4 - mysqlx_users registered in config_db not ok 5 - mysqlx_users admin schema includes allowed_auth_methods not ok 6 - mysqlx_users config schema includes backend_auth_mode Root cause: the mysqlx plugin (ABI 2+) registers its admin tables in register_schemas() — Phase B of the four-phase lifecycle — not in init() / Phase D. The test only does load() + init_all(), skipping Phase B entirely, so mgr.tables(admin_db) and mgr.tables(config_db) return empty vectors and find_table() returns nullptr for every table-existence assertion. The test was written before the four-phase lifecycle was finalised; when mysqlx_register_admin_schema moved into Phase B (the Phase B mysqlx_register_schemas wraps it; init_all() no longer touches the admin-table-registration path), this test was not updated. # Fix Insert mgr.invoke_register_schemas_phase(err) between load() and init_all(). For ABI-1 plugins that don't declare register_schemas the call is a no-op (returns true with err empty). The plan goes from 6 to 7 to cover the new assertion. Verified locally: $ ./test_mysqlx_plugin_load-t 1..7 ok 1 - load mysqlx plugin succeeds ok 2 - invoke_register_schemas_phase registers mysqlx schema ok 3 - init_all completes after schema registration ok 4 - mysqlx_users registered in admin_db ok 5 - mysqlx_users registered in config_db ok 6 - mysqlx_users admin schema includes allowed_auth_methods ok 7 - mysqlx_users config schema includes backend_auth_mode # Why now This wasn't caught earlier because the same plugin-load assertions were partially covered by sibling tests (test_mysqlx_admin_tables-t, plugin_manager_unit-t) that drove the full Phase A→B→D lifecycle. test_mysqlx_plugin_load-t was the only test with the load+init-only shortcut. CI-unit-tests-asan-coverage on plugin-chassis is the specific job that runs every *-t binary in test/tap/tests/unit (the file lives in test/tap/tests/, not unit/, but groups.json registers it with @proxysql_min_version:4.0 so the chassis gates are right).	2 months ago
Rene Cannao	6df15c63c6	fix: complete mysqlx scaffold schema and test build	3 months ago
Rene Cannao	19d48bdc13	feat: scaffold mysqlx plugin module	3 months ago