6 Commits (feature/pgsql-native-backend-protocol)

Author	SHA1	Message	Date
Rene Cannao	7824489fc9	fix(mysql): advertise CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA in server greeting ... ProxySQL already correctly parses the lenenc auth data format when clients send it in the handshake response (MySQL_Protocol.cpp:1708), but the server greeting packet never advertised the capability flag. Clients like Boost MySQL require this flag before they will even attempt a connection. Adding it to extended_capabilities makes ProxySQL compatible with such clients without any protocol behavior change. The existing test_greeting_capabilities-t test is updated to include the new flag in the baseline regression check. Closes: #4760	2 months ago
Rene Cannao	4d251c80ec	Revert 'enable_client_session_tracking' variable; keep greeting fix ... Issue #5621 mis-diagnosed "CLIENT_SESSION_TRACKING missing from the greeting" as a long-standing configuration gap and proposed a new 'mysql-enable_client_session_tracking' variable analogous to 'mysql-enable_client_deprecate_eof'. On closer inspection this was in fact a regression introduced by commit 8c6a6444d (zstd refactor), which dropped the hard-coded upper-word bits from the greeting. The right fix is simply to restore those hard-coded bits — commits 536c9d916 and 6b311b701 already do that via the 'extended_capabilities' local in 'generate_pkt_initial_handshake'. The new variable adds no value on top of that: the hard-coded bits cannot be disabled through 'mysql-server_capabilities' (which is OR-combined with the greeting), and there is no protocol hazard motivating a per-instance off-switch for CLIENT_SESSION_TRACKING, unlike CLIENT_DEPRECATE_EOF. Revert the variable (MySQL_Thread.h / proxysql_structs.h / MySQL_Thread.cpp / MySQL_Protocol.cpp) and restore CLIENT_SESSION_TRACKING to the 'extended_capabilities' literal, matching v3.0.6 exactly. Keep the test's doxygen / diag / baseline-check rewrite from the investigation — it's strictly better coverage and will catch any future regression of the hard-coded bits early. Test plan reduced to 2 scenarios (deprecate_eof on/off) since session_tracking is now unconditionally advertised.	2 months ago
Rene Cannao	536c9d9169	Restore greeting upper-word capabilities dropped in 8c6a6444d ... The zstd refactor in 8c6a6444d replaced the per-greeting 'extended_capabilities' local with 'server_capabilities' derived from 'mysql_thread___server_capabilities'. As a side effect, the four upper-word bits the greeting used to hardcode were no longer advertised: CLIENT_MULTI_STATEMENTS CLIENT_MULTI_RESULTS CLIENT_PS_MULTI_RESULTS CLIENT_REMEMBER_OPTIONS OR these bits back into 'mysql_thread___server_capabilities' before the upper-word memcpy, matching what real MySQL 8.x advertises (see #4023). Also rewrite test_greeting_capabilities-t with doxygen documentation and step-by-step diag() tracing that decodes capability bitmasks to names, and reinstate the baseline-capability assertion that silently degraded when commit 6e1483f1f tightened the caps_match overwrite into '&='. In 'PPHR_2', fold the CLIENT_SESSION_TRACKING enforcement into the shared two-step comment block for clarity.	2 months ago
Rene Cannao	6e1483f1f3	Address PR review feedback for test_greeting_capabilities ... - Fix check_server_capabilities() to accumulate results with &= instead of overwriting caps_match per flag, preventing false positives with multiple conditional capabilities - Add mixed toggle tests (deprecate_eof=1/session_tracking=0 and vice versa) for better isolation coverage	3 months ago
Rene Cannao	c3532088d4	Add mysql-enable_client_session_tracking variable for client connections ... Introduce a new mysql global variable 'enable_client_session_tracking' (default: true) that controls whether CLIENT_SESSION_TRACKING is advertised to clients during handshake. This follows the same pattern as the existing 'enable_client_deprecate_eof' variable, allowing operators to disable session tracking capability on the client side independently of the server side. Closes #5621	3 months ago
Javier Jaramago Fernández	dcfbb0de62	Add test checking capabilities reported by ProxySQL in 'Greeting message' #4023	4 years ago