proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	d8e4a607de	fix(test/tap): real bugs from static analysis - fix uninitialized loop var (UB) in test_digest_umap_aux-t.cpp - fix dead stores and unused vars in test_binlog_reader-t.cpp - rename reserved identifiers (__timer, _mysql_hdr, th_args__in_t, etc.) - fix narrowing conversions (ssize_t->int, uint32_t->int, size_t->int) - fix implicit widening of multiplication (overflow risk) - consolidate duplicated conditional branch in reg_test_4556 - pass modname by const ref in test_cluster1-t.cpp - fix narrowing in test_default_conn_collation-t.cpp	3 months ago
Rene Cannao	a3d7378ad0	fix(test/tap): misleading-indentation bug fix + function-address bug + leak cleanup test_ssl_fast_forward-1-t.cpp: - Fix a bug I introduced in the prior batch: my scripted wrapping of braceless 'if (cond) return exit_status();' bodies skipped the one 'if' line that had a trailing '// comment' (it didn't end with ')'). The result was a misleading-indentation case where only close_all() was inside the if body and return exit_status() ran unconditionally. Added explicit { } around that block. test_digest_umap_aux-t.cpp: - Fix real logic bug: 'tests_failed == 0' (missing parentheses) compared the address of the function against zero. The address is never NULL, so the second operand of the '&&' was always false, and the TRUNCATE TABLE stats.stats_mysql_query_digest cleanup at end of main never actually ran. Fixed to 'tests_failed() == 0'. Surfaced by -Waddress. test_default_conn_collation-t.cpp: - Fix NULL-deref UB: mysql_init was not checked for NULL before being passed to mysql_real_connect. - Fix 'admin' leak on mysql_real_connect failure. - Remove the dead 'cleanup:' label: the label's cleanup code (mysql_close + return exit_status) was unreachable because the preceding happy-path flow was a plain fall-through into it. Moved the cleanup body inline and deleted the label. Compile-verified with -fsyntax-only (-Wall for the first two files).	3 months ago
Miro Stauder	803510fa5e	fix mysql includes	3 years ago
Javier Jaramago Fernández	5f008b8925	Add 'plan' for TAP with all collations expressed by protocol	3 years ago
Javier Jaramago Fernández	b812563eca	Add TAP test verifying behavior of 'mysql-default_collation_connection'	3 years ago

5 Commits (feature/pgsql-native-backend-protocol)