proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	174c5bda20	test: expand zstd_compression_level test with MySQL 8.4 C API and timing benchmark The existing test only verified admin variable behavior (default, range, independence). It did not prove that ZSTD compression was actually active on the wire. Two new test variants address this: MariaDB connector path (mysql-zstd_compression_level-t): - Tests 1-9: unchanged (variable defaults, range validation, independence) - Tests 10-11: use mysql CLI via execvp with --compression-algorithms=zstd and --zstd-compression-level={3,19}. Each call spawns a new process (= new connection). Verifies CONNECTION_ID() retrieval and large resultset transfer. Skipped if mysql CLI lacks zstd support. MySQL 8.4 connector path (mysql-zstd_compression_level_libmysql-t): - Tests 1-9: same as MariaDB path - Test 10: establishes a ZSTD connection using mysql_options( MYSQL_OPT_COMPRESSION_ALGORITHMS, "zstd") and prints mysql_thread_id() without running any query. - Test 11: timing benchmark proving compression is active. Creates a query rule (rule_id=1, cache_ttl=60000) to cache all SELECTs, then runs a 576-row resultset query 1000 times on a plain connection and 1000 times on a ZSTD level 22 connection. ZSTD level 22 is extremely CPU-intensive: observed 40122ms vs 858ms (46.7x ratio). A ratio >= 3x proves compression is really running on the client<->ProxySQL link. Other changes: - MySQL_Protocol.cpp: simplify redundant clamping to a simple cast (the variable is already validated at SET time) - Makefile: add build rule for _libmysql variant linking against MySQL 8.4 connector - groups.json: register _libmysql variant for mysql84/90/95-g1 - CLAUDE.md: update testing section with CI script usage and DO NOT list	2 months ago
Rene Cannao	f9f6f74ecc	fix: address code review issues in zstd compression level test - Remove mysql_error(NULL) UB on failed admin connection (use static error string instead). - Correct Test 10 comment and label: it exercises zlib (CLIENT_COMPRESS), not zstd compression, verifying the new variable doesn't break existing compressed connections.	2 months ago
Rene Cannao	6dae8d125f	test: add TAP tests and housekeeping for mysql-zstd_compression_level - New test mysql-zstd_compression_level-t.cpp: validates default value, range enforcement (1-22), rejection of 0 and 23, independence from mysql-protocol_compression_level, and functional compressed connection. - Register mysql-zstd_compression_level-t in groups.json (same groups as mysql-protocol_compression_level-t). - Add variable visibility check to reg_test_2793-compression-t.cpp. - Add unit test binary pattern to .gitignore.	2 months ago

Author

SHA1

Message

Date

Rene Cannao

174c5bda20

test: expand zstd_compression_level test with MySQL 8.4 C API and timing benchmark

The existing test only verified admin variable behavior (default, range,
independence). It did not prove that ZSTD compression was actually
active on the wire. Two new test variants address this:

MariaDB connector path (mysql-zstd_compression_level-t):
- Tests 1-9: unchanged (variable defaults, range validation, independence)
- Tests 10-11: use mysql CLI via execvp with --compression-algorithms=zstd
  and --zstd-compression-level={3,19}. Each call spawns a new process
  (= new connection). Verifies CONNECTION_ID() retrieval and large
  resultset transfer. Skipped if mysql CLI lacks zstd support.

MySQL 8.4 connector path (mysql-zstd_compression_level_libmysql-t):
- Tests 1-9: same as MariaDB path
- Test 10: establishes a ZSTD connection using mysql_options(
  MYSQL_OPT_COMPRESSION_ALGORITHMS, "zstd") and prints mysql_thread_id()
  without running any query.
- Test 11: timing benchmark proving compression is active. Creates a
  query rule (rule_id=1, cache_ttl=60000) to cache all SELECTs, then
  runs a 576-row resultset query 1000 times on a plain connection and
  1000 times on a ZSTD level 22 connection. ZSTD level 22 is extremely
  CPU-intensive: observed 40122ms vs 858ms (46.7x ratio). A ratio >= 3x
  proves compression is really running on the client<->ProxySQL link.

Other changes:
- MySQL_Protocol.cpp: simplify redundant clamping to a simple cast
  (the variable is already validated at SET time)
- Makefile: add build rule for _libmysql variant linking against
  MySQL 8.4 connector
- groups.json: register _libmysql variant for mysql84/90/95-g1
- CLAUDE.md: update testing section with CI script usage and DO NOT list

Rene Cannao

f9f6f74ecc

fix: address code review issues in zstd compression level test

- Remove mysql_error(NULL) UB on failed admin connection (use static
  error string instead).
- Correct Test 10 comment and label: it exercises zlib (CLIENT_COMPRESS),
  not zstd compression, verifying the new variable doesn't break existing
  compressed connections.

Rene Cannao

6dae8d125f

test: add TAP tests and housekeeping for mysql-zstd_compression_level

- New test mysql-zstd_compression_level-t.cpp: validates default value,
  range enforcement (1-22), rejection of 0 and 23, independence from
  mysql-protocol_compression_level, and functional compressed connection.
- Register mysql-zstd_compression_level-t in groups.json (same groups as
  mysql-protocol_compression_level-t).
- Add variable visibility check to reg_test_2793-compression-t.cpp.
- Add unit test binary pattern to .gitignore.

3 Commits (feature/pgsql-native-backend-protocol)