proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	da655099ee	fix(test/tap): batch 2 of static analysis real-bug fixes Batch 1 - dead stores/unused vars (11 files): - remove dead test_count assignments in genai_module/async/embedding_rerank/mcp_module - remove unused result strings in ai_llm_retry_scenarios - remove dead jitter_ms in ai_llm_retry_scenarios - remove unused row assignments in mysql-fast_forward/mysql-mirror1 - remove dead rc, sock, num_rows in mysql-protocol_compression/malformed/ssl_CA Batch 2 - narrowing conversions (~100 fixes): - pgsql-extended_query_protocol_test: uint8_t->char, ssize_t->int casts - genai_module/async/embedding_rerank: recv()/mysql_num_rows() casts - mysql-protocol_compression_level: various narrowing casts - max_connections_ff: timeout/duration casts - mysql_query_logging_memory: errno/plan() casts - pgsql-connection_parameters: htonl/ntohl casts - multiple_prepared_statements, mysql-reg_test_4716, nl2sql_internal, etc. Batch 3 - macros + branch clone: - fix macro parens in mysql-reg_test_4867_query_rules - fix macro parens in proxysql_debug.h - fix branch clone in pgsql-connection_parameters_test - fix branch clone in pgsql-copy_to_test - fix narrowing in pgsql-copy_from_test Batch 4 - value params + widening + reserved IDs: - pass string params by const ref in admin_various_commands2, mysql_hostgroup_attributes-servers_defaults, mysql-protocol_compression_level - fix implicit widening overflow in mcp_mysql_concurrency_stress - fix widening in mysql_stmt_send_long_data_large - rename reserved identifiers (__1, _PtrSize_t) - fix narrowing in pg_lite_client.h	3 months ago
Rene Cannao	b99e8c57ed	fix(test/tap): wrong handle/column bugs + leaks in two more tests test_connection_annotation-t.cpp: - Fix wrong-handle diagnostic: after mysql_real_connect(proxysql_admin) failed, the error path reported mysql_error(proxysql_mysql) — the handle that had already connected successfully. Reports the failed admin handle now. - Fix atoi(row[2]) reading 'srv_host' (a string) as srv_port: the SELECT column order is ConnUsed, ConnFree, srv_host, srv_port, so row[3] is the port. The diagnostic was reporting garbage values like 127 (for host "127.0.0.1") as the port. - Add mysql_init NULL checks for both proxysql_mysql and proxysql_admin; fix cross-leaks when one succeeds and the other fails. - Fix proxysql_mysql/proxysql_admin leaks on all real_connect and store_result error paths, plus at happy-path exit. - NULL-check both mysql_store_result calls before passing the result to mysql_fetch_row (was UB on NULL). - Guard the vector subtraction loop against mismatched row counts using std::min of both vector sizes; previously a shorter 'new_ cur_connections' would be read out of bounds. mysql-fast_forward-t.cpp: - Same leak pattern as kill_connection{2,3}-t.cpp: NULL-deref UB on mysql_init failure, create_connections leaking the in-flight handle on real_connect failure, and the entire conns[NUM_CONNS] + admin handle leaked on every exit path. - Between the two create_connections calls, add explicit close_all_conns() so the second batch doesn't orphan the first. - Add NULL check on mysql_store_result(conns[0]) before passing to mysql_fetch_row in the SELECT * FROM test.sbtest1 loop. Compile-verified with -fsyntax-only.	3 months ago
Rene Cannao	df76a3dc06	test: implement comprehensive noise injection across MySQL TAP tests Integrated the enhanced noise framework into multiple MySQL-specific tests. Each test now optionally spawns: - Random Stats Poller - REST Prometheus Poller (with auto-enable support) - PgSQL Traffic v2 (configured with 100 conns and 300ms delay) This significantly increases the background load during test execution to better uncover potential race conditions and stability issues.	4 months ago
Wazir Ahmed	8ebd7e48ae	TAP: Move init_mysql_conn() and run_q() to utils Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	10 months ago
Javier Jaramago Fernández	ef3360f102	Several enhancements for TAP tests compilation - Split 'libtap' into different binaries. This allows for the reuse of 'TAP' utilities that make use of MySQL or other third party library versions. Each of these tests that require special library versions that aren't the common ones embedded into the dynamic library 'libtap.so' should be compiled defining special helper targets, in the 'tests' folder Makefile itself. These helper targets with specify the linking of the required version of the library for the test. Each MySQL client version supported by the 'tap' tests that breaks headers compatibility should be compiled into a different object file, following the previous described procedure. - Add MySQL 8.4.0 client library as a new TAP test dependency. - Multiple compilation fixes consequence of the introduced change to 'libtap.a'. - Added as ProxySQL dependency the forward declaration header for 'nlohmann::json'. This header is the proper way of including the library is headers which are sensible of being included in multiples files. This speeds compilation times of each TAP test. - Removed 'std::regex' dependency from 'utils.cpp', and replaced by project dependency 're2'. Library 'std::regex' should not be used in any place that introduces it as a dependency for later objects, it's heavy, slow, and should be avoided in general.	2 years ago
Miro Stauder	c78819bda9	use inludes from our deps intead of system	3 years ago
René Cannaò	1d5ac70e7b	Adding test to test mysql user fast_forward This commit also fix a bug: When the session uses fast_forward, frontend and backend connections must have the same bit for CLIENT_DEPRECATE_EOF	5 years ago

7 Commits (feature/pgsql-native-backend-protocol)