proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	da655099ee	fix(test/tap): batch 2 of static analysis real-bug fixes Batch 1 - dead stores/unused vars (11 files): - remove dead test_count assignments in genai_module/async/embedding_rerank/mcp_module - remove unused result strings in ai_llm_retry_scenarios - remove dead jitter_ms in ai_llm_retry_scenarios - remove unused row assignments in mysql-fast_forward/mysql-mirror1 - remove dead rc, sock, num_rows in mysql-protocol_compression/malformed/ssl_CA Batch 2 - narrowing conversions (~100 fixes): - pgsql-extended_query_protocol_test: uint8_t->char, ssize_t->int casts - genai_module/async/embedding_rerank: recv()/mysql_num_rows() casts - mysql-protocol_compression_level: various narrowing casts - max_connections_ff: timeout/duration casts - mysql_query_logging_memory: errno/plan() casts - pgsql-connection_parameters: htonl/ntohl casts - multiple_prepared_statements, mysql-reg_test_4716, nl2sql_internal, etc. Batch 3 - macros + branch clone: - fix macro parens in mysql-reg_test_4867_query_rules - fix macro parens in proxysql_debug.h - fix branch clone in pgsql-connection_parameters_test - fix branch clone in pgsql-copy_to_test - fix narrowing in pgsql-copy_from_test Batch 4 - value params + widening + reserved IDs: - pass string params by const ref in admin_various_commands2, mysql_hostgroup_attributes-servers_defaults, mysql-protocol_compression_level - fix implicit widening overflow in mcp_mysql_concurrency_stress - fix widening in mysql_stmt_send_long_data_large - rename reserved identifiers (__1, _PtrSize_t) - fix narrowing in pg_lite_client.h	3 months ago
Rene Cannao	99dbd0a358	Add TAP test for GenAI module Add comprehensive TAP test for the GenAI module that validates: LOAD/SAVE Commands: - All 14 standard command variants (TO MEMORY/FROM DISK/TO RUNTIME, etc.) - Verifies commands execute successfully Variable Access: - SET operations for genai-var1 and genai-var2 - SELECT operations to retrieve variable values - Default values and special character handling Persistence Layers: - Memory layer (main.global_variables) - Disk layer (disk.global_variables) - Runtime layer (GloGATH handler object) - SAVE/LOAD operations between layers CHECKSUM Commands: - CHECKSUM DISK GENAI VARIABLES - CHECKSUM MEM/MEMORY GENAI VARIABLES - CHECKSUM GENAI VARIABLES (default) The test includes proper documentation and follows ProxySQL's TAP test conventions. Tests will fully pass once the GenAI module is completely implemented with variable registration.	6 months ago

Author

SHA1

Message

Date

Rene Cannao

da655099ee

fix(test/tap): batch 2 of static analysis real-bug fixes

Batch 1 - dead stores/unused vars (11 files):
- remove dead test_count assignments in genai_module/async/embedding_rerank/mcp_module
- remove unused result strings in ai_llm_retry_scenarios
- remove dead jitter_ms in ai_llm_retry_scenarios
- remove unused row assignments in mysql-fast_forward/mysql-mirror1
- remove dead rc, sock, num_rows in mysql-protocol_compression/malformed/ssl_CA

Batch 2 - narrowing conversions (~100 fixes):
- pgsql-extended_query_protocol_test: uint8_t->char, ssize_t->int casts
- genai_module/async/embedding_rerank: recv()/mysql_num_rows() casts
- mysql-protocol_compression_level: various narrowing casts
- max_connections_ff: timeout/duration casts
- mysql_query_logging_memory: errno/plan() casts
- pgsql-connection_parameters: htonl/ntohl casts
- multiple_prepared_statements, mysql-reg_test_4716, nl2sql_internal, etc.

Batch 3 - macros + branch clone:
- fix macro parens in mysql-reg_test_4867_query_rules
- fix macro parens in proxysql_debug.h
- fix branch clone in pgsql-connection_parameters_test
- fix branch clone in pgsql-copy_to_test
- fix narrowing in pgsql-copy_from_test

Batch 4 - value params + widening + reserved IDs:
- pass string params by const ref in admin_various_commands2,
  mysql_hostgroup_attributes-servers_defaults,
  mysql-protocol_compression_level
- fix implicit widening overflow in mcp_mysql_concurrency_stress
- fix widening in mysql_stmt_send_long_data_large
- rename reserved identifiers (__1, _PtrSize_t)
- fix narrowing in pg_lite_client.h

Rene Cannao

99dbd0a358

Add TAP test for GenAI module

Add comprehensive TAP test for the GenAI module that validates:

LOAD/SAVE Commands:
- All 14 standard command variants (TO MEMORY/FROM DISK/TO RUNTIME, etc.)
- Verifies commands execute successfully

Variable Access:
- SET operations for genai-var1 and genai-var2
- SELECT operations to retrieve variable values
- Default values and special character handling

Persistence Layers:
- Memory layer (main.global_variables)
- Disk layer (disk.global_variables)
- Runtime layer (GloGATH handler object)
- SAVE/LOAD operations between layers

CHECKSUM Commands:
- CHECKSUM DISK GENAI VARIABLES
- CHECKSUM MEM/MEMORY GENAI VARIABLES
- CHECKSUM GENAI VARIABLES (default)

The test includes proper documentation and follows ProxySQL's
TAP test conventions. Tests will fully pass once the GenAI
module is completely implemented with variable registration.

2 Commits (feature/pgsql-native-backend-protocol)