proxysql

Commit Graph

Author	SHA1	Message	Date
René Cannaò	35cad4b4f4	Merge branch 'v3.0' into fix/kill-proxysqlgenai-build-flag-v2	1 month ago
Rene Cannao	0d39ac6991	build: kill PROXYSQLGENAI flag, PROXYSQL40=1 builds all plugins PROXYSQLGENAI was a leftover from before the genai plugin carve-out. All genai/MCP/AI/RAG code now lives in plugins/genai/ as a runtime loadable .so. Since the plugin chassis (PROXYSQL40=1) already builds and loads the genai .so, a separate flag serves no purpose. Entrypoint changes (all three -- rhel, suse, deb): - Build: pass PROXYSQL40=1 (not PROXYSQLGENAI=1) to make. - Packaging: copy genai .so alongside mysqlx when PROXYSQL40=1. - protobuf-devel install: gate on PROXYSQL40=1 (needed for mysqlx). Automated packaging verification added to all entrypoints: rpm -qpl / dpkg -c confirms both .so files are in the package. ELF smoke test: validates .so is a valid shared object exporting proxysql_plugin_descriptor_v1 symbol. Fails build on mismatch. Test Makefiles: PROXYSQLGENAI -> PROXYSQL40 for the vec.o link gate (test/tap/tests/Makefile and test/deps/cluster_simulator/Makefile). Updated remaining PROXYSQLGENAI references to PROXYSQL40 in: CLAUDE.md, include/cpp.h, lib/proxy_sqlite3_symbols.cpp, src/main.cpp (3x comments), proxysql.spec, test/infra/control/start-proxysql-isolated.bash, test/infra/control/run-unit-tests-asan-coverage.bash, and 14 genai test file comments.	1 month ago
Rene Cannao	5044d13d5e	test(framework): remove skip_all() — fail loudly on missing preconditions Stage 2 follow-up to the PR #5708 reproduction debug. The framework helper test/tap/tap/tap.{h,cpp}::skip_all() prints "1..0 # skip ..." and exit(0), which the harness reports as "ignored" — zero assertions emitted, zero failures recorded, no notice that a test never ran. While investigating the customer regression on PR #5708 we discovered that test_set_statement_for-t had been silently skipping in CI since the day it was added: it self-skipped on non-MariaDB backends, but was registered only in MySQL-family TAP groups, so every run skipped. PR #5794 fixes that one test. The principled fix is to remove the mechanism that lets a test silently disappear. This commit converts the remaining four skip_all() callers and deletes the framework function: - test_mysqlx_e2e_routing-t BAIL_OUT if MYSQLX_E2E_PROXYSQL_PORT is not set. The group env file test/tap/groups/mysqlx-e2e/env.sh sets it; missing at runtime means the harness did not source it. - test_mysqlx_e2e_handshake-t BAIL_OUT if MYSQLX_E2E_HOST is not set (same env file, same rationale). - test_mysqlx_route_drop_inflight-t BAIL_OUT if the X-Protocol listener is not reachable. The mysqlx-soak-g1 harness is supposed to start ProxySQL with the mysqlx plugin and provision the route; a missing listener is a setup bug. - test_mysqlx_sigterm_inflight-t Deleted. The binary was a stub whose body was a TODO; the real sigterm scenario is implemented in test/scripts/mysqlx/behavioral_validation.py --scenario sigterm. With skip_all gone the stub had no remaining purpose. Also dropped from groups.json and the Makefile. After this commit, the test/tap codebase has zero call sites of skip_all(). The framework declaration and definition are deleted from tap.h and tap.cpp; the doc references at the bottom of tap.cpp are updated; a comment explains the rationale and points at BAIL_OUT() as the replacement. Verified locally: full TAP debug build succeeds, no undefined-reference errors, lint_groups_json + check_groups --source both green. Depends on PR #5794 (which removed the fifth caller in test_set_statement_for-t.cpp). This PR is based on that branch; merging in order keeps each merge a clean compile.	1 month ago
René Cannaò	44c33cd2d3	Merge branch 'v3.0' into feature/parsersql-integration	2 months ago
Rene Cannao	a9f2eaaa13	feat: remove PROXYSQLGENAI flag, genai now builds under PROXYSQL40 (issue #5722 ) PROXYSQLGENAI flag eliminated entirely. PROXYSQL40=1 now unconditionally builds the genai plugin alongside core. All #ifdef PROXYSQLGENAI replaced with #ifdef PROXYSQL40 in source, Makefiles, and 61 CI workflows.	2 months ago
Rene Cannao	b8cfa32c63	fix: address all critical and important code review findings (issue #5729 ) Critical fixes: - Move db_kind to end of ProxySQL_PluginRuntimeView (tail-append = free ABI-3 compat) - Add mutex to protect Anomaly_Detector::user_statistics from concurrent session threads - Replace system(mkdir -p) with pure mkdir() loop (command injection fix) - Replace 77 std::stoi/stoll with non-throwing parse_int_or_zero/parse_ll_or_zero - Fix proxysql.cnf filename: Mysqlx -> MySQLX - Add --whole-archive to non-ClickHouse link path (plugin symbol resolution) Important fixes: - Add default: case with warning to db_kind switch in ProxySQL_PluginManager.cpp - Add config_db dispatch and null-handle tests to plugin_runtime_views_unit-t (6 new tests) - Update CLAUDE.md with sqlite-vec PROXYSQLGENAI exception - Remove stale anomaly_detection-t Makefile target - Replace fixed 1024-byte buffer with dynamic sqlite3_mprintf in Anomaly_Detector Minor: update ABI.md, PLUGIN_API.md, stale comments, unit test plan counts	2 months ago
René Cannaò	80b93f11a1	Merge branch 'v3.0' into feature/parsersql-integration	2 months ago
Rene Cannao	391afb524f	upgrade: vendor ParserSQL 1.0.1 with SET parser fixes, update test expectations - Vendored ParserSQL 1.0.1 (was 1.0.0) with fixes for issues #34, #35, #36: - #34: Comma-separated assignments after SET NAMES/CHARSET - #35: ON/OFF keyword values accepted as SET RHS - #36: Empty AST detection for incomplete SET statements - New: NAMES/CHARSET/CHARACTER SET recognized after commas - Updated deps/Makefile and makefiles_paths.mk for parsersql-1.0.1 - Added -lsqlparser to TAP test link flags (MYLIBS_STATIC_PART, LDIRS) - Updated setparser_test_common.h expectations: - Invalid subquery tests now produce extracted paren values (sql_mode 23-25) - SET with empty RHS skips invalid assignment, returns valid ones (Set1_v2 0) - Complex nested function calls now fully parsed (Set1_v2 1) - Syntax errors partially parsed (syntax_errors 0-1) - All 224 SET tests pass, all 51 digest tests pass	2 months ago
Rene Cannao	b340da9ab6	test(mysqlx): add behavioural TAP scaffolding for SIGTERM mid-traffic Issue #5678 part (a) asks operators to demonstrate that an X-Protocol client connected to ProxySQL during SIGTERM receives a clean Mysqlx::Error frame with code 1053 ("Server is shutting down") rather than a TCP RST. The contract is: Mysqlx_Thread::run() -> for each session: MysqlxSession::shutdown_notify_client() -> send_error(1053, "Server is shutting down", fatal=true) -> client_ds_.write_to_net() -> if TLS: SSL_set_quiet_shutdown(1) + SSL_shutdown() (plugins/mysqlx/src/mysqlx_session.cpp:1875, plugins/mysqlx/src/mysqlx_thread.cpp:120-128). Why this is scaffolding, not an automated test: ProxySQL runs in its own Docker container under test/infra/control/run-tests-isolated.bash. Tests run in a separate test-runner container that does NOT have docker socket access, so it cannot kill -TERM the proxysql container. Even if it could, doing so mid-test would tear down the infrastructure that the rest of the TAP group expects to remain up. The harness has no "test that owns proxysql lifecycle" mode and adding one is out of scope. The equivalent automated path already exists out-of-band: test/scripts/mysqlx/behavioral_validation.py --scenario sigterm which (a) opens N X-Protocol sessions via mysql-connector-python, (b) os.kill(pid, SIGTERM)s the proxysql process directly, and (c) verifies each client's exception carries errno=1053 (Mysqlx shutdown frame), not a generic OperationalError-without-errno (TCP RST). It is invoked manually against staging or local-loop infrastructure where proxysql termination is acceptable. What this binary does: - Compiles + links, so groups.json registration exercises its existence on every CI run alongside the rest of the mysqlx-soak group; future drift in the link line or TAP harness shows up here, not at "we never built this". - At runtime, defaults to skip_all() with a pointer to the behavioral_validation.py script and the manual procedure documented in the file's header comment. - With MYSQLX_SIGTERM_INFLIGHT_OPT_IN=1 set, the binary refuses loudly (fails with a planned ok(false, ...)) rather than silently doing nothing, so an operator who flips the env var without first wiring up an automated body gets a clear signal. - Header comment includes the pseudocode for the future automated body so a follow-up PR can lift it directly. Wired into mysqlx-soak-g1 alongside the other mysqlx behavioural tests; the skip_all keeps CI green while the registration ensures the binary is built and the test name is well-known. Build: WITHASAN=1 NOJEMALLOC=1 PROXYSQLGENAI=1 make test_mysqlx_sigterm_inflight-t Verified that the binary skip_alls correctly when MYSQLX_SIGTERM_INFLIGHT_OPT_IN is unset: $ ./test_mysqlx_sigterm_inflight-t 1..0 # skip manual procedure -- see header comment. ...	2 months ago
Rene Cannao	9e6243026f	test(mysqlx): add behavioural TAP test for LOAD MYSQLX ROUTES TO RUNTIME mid-traffic Demonstrates issue #5678 part (b) end-to-end against a real ProxySQL instance with the mysqlx plugin loaded. The test: 1. Opens 5 X-Protocol clients to ProxySQL via route r1 and dispatches SELECT 1 on each so the session is past handshake/routing. 2. Connects to the admin port (classic protocol via libmariadbclient) and runs: DELETE FROM mysqlx_routes WHERE name='r1'; LOAD MYSQLX ROUTES TO RUNTIME; 3. Asserts each in-flight session can still execute SELECT 1 -- the contract from mysqlx_listener_reconcile.cpp::remove_listener_for_route ("in-flight sessions are NOT torn down on route removal; they continue against their already-resolved target_hostgroup_/target_address_/target_port_") matching MySQL's "DROP TABLE doesn't cancel in-flight queries" semantics. 4. Asserts a NEW TCP connect to the dropped route's port is refused (Mysqlx_Thread::remove_listener_for_route close()d the listener fd). 5. Restores the route via INSERT + LOAD MYSQLX ROUTES TO RUNTIME so downstream tests in the same group are not disrupted. Wired into the mysqlx-soak-g1 TAP group, which is the only group that provisions route r1 + user alice in ProxySQL (mysqlx-e2e-g1 uses SKIP_PROXYSQL=1 against a dbdeployer sandbox so the route doesn't exist there). Runs through the standard isolated docker harness (test/infra/control/run-tests-isolated.bash); requires no new infrastructure beyond what mysqlx-soak/setup-infras.bash already provisions. The test issues skip_all() if the X-Protocol listener is unreachable, which keeps it inert in groups that don't bring up the route-r1 fixture and on bare workstations without infrastructure. Build: WITHASAN=1 NOJEMALLOC=1 PROXYSQLGENAI=1 make test_mysqlx_route_drop_inflight-t Reuses the protocol helpers from plugins/mysqlx/src/mysqlx_protocol.cpp and the protobuf objects from plugins/mysqlx/proto/, identical to the existing test_mysqlx_e2e_*-t binaries.	2 months ago
Rene Cannao	889c319420	test: add SET parser and digest adapter validation tests	2 months ago
Rene Cannao	d4427731b7	Merge remote-tracking branch 'origin/v3.0' into plugin-chassis Picks up the v3.0 fixes that unblock plugin-chassis CI: - `5d702b12b` build(test): fix testgalera link after switch to src/SQLite3_Server.cpp — restores -Wl,--allow-multiple-definition, ClickHouse/zstd/lz4 link, and ProxySQL_Admin.cpp recompile under TEST_GALERA. Resolves CI-maketest red on plugin-chassis. - `baa5069ea` introduces test/tap/groups/mysql56-single/ which the CI-mysql56-single-g1 workflow expects. Resolves the missing-infra error. - macOS package upload + init_release race-tolerant grouping + amd64 package workflow expansion + various CI/release cleanups. CI-unit-tests-asan-coverage on plugin-chassis still depends on the v3.0 workflow YAML having libprotobuf-dev in its apt install step (workflow_run loads the YAML from the default branch). That fix is already on plugin-chassis (`47ab14148`) and will land on v3.0 via a separate small PR.	2 months ago
Rene Cannao	df7e335e23	fix(ci,infra): pass PROXYSQL40 to plugin build, remove orphaned infra files Three CI/infra clean-ups that fall out of the independent review. 1) .github/workflows/CI-mysqlx.yml: pass PROXYSQL40=1 (and the implied tier flags) to `make` when building the mysqlx plugin. plugins/mysqlx/Makefile picks up tier flags from the environment and propagates them as -DPROXYSQL40 / -DPROXYSQL31 / -DPROXYSQLFFTO / -DPROXYSQLTSDB / -DPROXYSQLGENAI on every compile line. If the workflow runs `make` with no flags, the plugin is built without -DPROXYSQL40 — meaning the ProxySQL_PluginDescriptor and ProxySQL_PluginServices struct layouts compiled into the plugin .so differ from the layouts that the cached src/proxysql binary (built upstream by CI-trigger with the full tier flags) sees. The link succeeds and the first virtual dispatch into a plugin callback crashes or, worse, corrupts memory silently. The Makefile already warns about exactly this in lines 56-61. Pass the flags explicitly. 2) test/tap/groups/mysqlx-e2e/infras.lst + test/infra/docker-compose-mysqlx.yml: delete both — they are orphaned. `infras.lst` referenced `infra-mysqlx`, which has never existed under `test/infra/`. ensure-infras.bash would have errored on it — except `mysqlx-e2e/env.sh` exports SKIP_PROXYSQL=1, which makes ensure-infras.bash short-circuit at line 38 before it reaches the docker-compose loop. So infras.lst was both wrong AND unreachable — the worst combination for the next reader trying to figure out how the e2e group is wired. Similarly, `test/infra/docker-compose-mysqlx.yml` was a docker-compose file that no `infra-*/` directory points at, left over from an early plan to use Docker for the mysqlx backend that was abandoned in favour of dbdeployer. Both files are dead weight; delete them. 3) test/tap/groups/mysqlx-e2e/env.sh: comment the unconventional wiring so the next reader doesn't have to reverse-engineer it. Document why this group has no `infras.lst` / no `infra-mysqlx/` dir, why CI uses inline dbdeployer instead of ensure-infras.bash, and that setup-infras.bash + pre-cleanup.bash exist for local-only ad-hoc use today. 4) test/tap/tests/Makefile: drop the dangling `test_mysqlx_listener_smoke-t` target. That test was retired together with the dormant MysqlxWorker path in commit 98aee7db2; the unit/Makefile no longer builds it. The wrapper target in test/tap/tests/Makefile remained and would fail `make test_mysqlx_listener_smoke-t` with "no rule to make target". Replace with a NOTE pointing at where the listener-lifecycle coverage actually lives now (mysqlx_thread_unit-t, mysqlx_robustness_unit-t). Verified: the plugin still builds clean with the tier flags exported to the sub-make. No behavioural change for the docker-using groups.	2 months ago
Rene Cannao	5d702b12bf	build(test): fix testgalera link after switch to src/SQLite3_Server.cpp CI-maketest / builds (testgalera) has been red on every branch since commit `a3883a880` (2026-04-12) which replaced the galera rules' use of the stub test/tap/tap/SQLite3_Server.cpp with the real src/SQLite3_Server.cpp. The stub was a type-inconsistency hazard, but the real source pulls in three new link-time problems that the galera Makefile rules did not accommodate: 1. Symbol collisions. src/SQLite3_Server.cpp has test-variant definitions of init_galera_ifaces_string() and populate_galera_table() gated by #ifdef TEST_GALERA (lines 1323 and 1424), while galera_1_timeout_count.cpp and galera_2_timeout_no_count.cpp provide their own versions of the same symbols plus SQLite3_Server_session_handler. Both land in the link and ld rejects with "multiple definition". Fix: -Wl,--allow-multiple-definition. The sibling anomaly_detection-t rule already uses this. 2. ClickHouse typeinfo. libproxysql.a pulls in ClickHouse_Server.oo, which references typeinfo for clickhouse::Column*. The galera rules do not link libclickhouse-cpp-lib.a, libzstdstatic.a, liblz4.a, and they do not add -I$(CLICKHOUSE_CPP_IDIR) / the corresponding -L paths. Copy the incantation from anomaly_detection-t. 3. Missing ProxySQL_Admin::enable_galera_testing(). This method is also #ifdef TEST_GALERA-gated (lib/ProxySQL_Admin.cpp:9305). libproxysql.a is built without TEST_GALERA, so the method is not in the archive. src/SQLite3_Server.cpp:1848 calls it under its own TEST_GALERA guard — linker error. Compile lib/ProxySQL_Admin.cpp fresh with -DTEST_GALERA alongside the galera test and SQLite3_Server.cpp. --allow-multiple-definition above handles the symbol overlap with libproxysql.a. Add -I$(COREDUMPER_IDIR) for ProxySQL_Admin.cpp's transitive include of coredumper/coredumper.h. Verified locally: make testgalera from scratch, rc=0, both binaries produced (124 MB each).	2 months ago
Rene Cannao	b3d4de0bc8	Merge remote-tracking branch 'origin/v3.0' into plugin-chassis # Conflicts: # test/tap/groups/groups.json	2 months ago
Rene Cannao	e20876a451	fix(tests): repair pre-existing mysqlx test build breakage Under `export PROXYSQLGENAI=1 && export PROXYSQL40=1 && make debug -j && make build_tap_test_debug -j` the tap build failed with ~78 errors spread across several mysqlx tests. None were caused by the chassis work; they are drift between test code and current APIs that no plain build had ever exercised (unit builds tried PROXYSQL40 without DEBUG; the debug path uncovers them). Changes: * test/tap/tests/unit/mysqlx_route_store_unit-t.cpp (19 sites), test/tap/tests/unit/mysqlx_stats_unit-t.cpp (7 sites), test/tap/tests/unit/mysqlx_admin_commands_unit-t.cpp (1 site), test/tap/tests/unit/mysqlx_admin_disk_commands_unit-t.cpp (2 sites): the `// NOSONAR:` comment was placed BEFORE the closing `)` of `SQLite3DB::open(..., FLAGS);`, commenting out both the flags and the closing paren. Move the NOSONAR comment to end of line and restore the flags argument. * test/tap/tests/unit/mysqlx_stats_unit-t.cpp (28 sites): `record_conn_ok/err/used` added a second argument (destination hostgroup) in `cd94ac2b1` but the tests still passed one arg. Pass `0` as the hostgroup for existing assertions (they only read back via route name anyway). * test/tap/tests/test_mysqlx_listener_smoke-t.cpp: add missing stub `record_conn_used`, `route_hostgroup`, and `~Mysqlx_Thread` definitions. The context-destructor path was generating `unique_ptr<Mysqlx_Thread>::operator delete` which couldn't find the real destructor (mysqlx_thread.cpp isn't linked into this test). * test/tap/tests/Makefile: add dedicated recipe for test_mysqlx_listener_smoke-t that defers to unit/ (matching test_mysqlx_plugin_load-t / test_mysqlx_admin_tables-t pattern). Without it the generic `%-t: %-t.cpp` rule built the test without `-I.../plugins/mysqlx/include` and failed on `mysqlx_config_store.h: No such file or directory`. * test/tap/tests/Makefile: add `-lcpp_dotenv -lcurl -lmariadbclient` to the link line for test_mysqlx_e2e_handshake-t and test_mysqlx_e2e_routing-t. libtap pulls those in transitively but the `-Wl,--no-as-needed` propagated from $(OPT) requires explicit references. * test/tap/tests/test_mysqlx_e2e_handshake-t.cpp and test/tap/tests/test_mysqlx_e2e_routing-t.cpp: The protobuf API changed (Array::add_value() returns Any, not Scalar; Capability::value is Any, not Array; AuthenticateStart/ Continue::auth_data is bytes, not Scalar). Wrap the MYSQL41 capability array element in an Any, and pass auth_data as raw bytes directly. Also fix `plan(skip_all, "...")` → `skip_all("...")` (TAP `plan()` now takes a single int). * test/tap/tests/unit/Makefile: add $(PROXYSQL_PATH)/plugins/mysqlx/src/mysqlx_config_store.cpp to the deps + compile line of every test that already links mysqlx_thread.cpp (mysqlx_thread_unit-t, mysqlx_session_unit-t, mysqlx_message_dispatch_unit-t, mysqlx_concurrent_unit-t, mysqlx_robustness_unit-t). mysqlx_thread.cpp calls MysqlxConfigStore::resolve_identity which was added recently and is defined in mysqlx_config_store.cpp. Verification: * `unset PROXYSQLGENAI && unset PROXYSQL40 && make cleanall && make debug -j && make build_tap_test_debug -j` — 0 errors. * `export PROXYSQLGENAI=1 && export PROXYSQL40=1 && make cleanall && make debug -j && make build_tap_test_debug -j` — 0 errors.	2 months ago
Rene Cannao	f34dc4573a	fix(tap tests): gate test_mysqlx_-t under PROXYSQL40 test/tap/tests/Makefile's tests-cpp target uses `$(wildcard -t.cpp)` to pick up all test sources. test_mysqlx_e2e_handshake-t.cpp, test_mysqlx_e2e_routing-t.cpp, test_mysqlx_listener_smoke-t.cpp, test_mysqlx_admin_tables-t.cpp and test_mysqlx_plugin_load-t.cpp all reference chassis types (ProxySQL_PluginServices, mysqlx_config_store.h) that only exist in the public headers under -DPROXYSQL40. Under a plain v3.0 build (`unset PROXYSQLGENAI && unset PROXYSQL40 && make debug -j && make build_tap_test_debug -j`), the wildcard still matched them, and the generic `%-t: %-t.cpp` recipe tried to compile them -- producing 130+ `error:` lines (mysqlx_config_store.h not found, Mysqlx::Datatypes::* conversion failures, ProxySQL_PluginServices undeclared, etc.). Reported by the user. Fix: autodetect PROXYSQL40 via `nm libproxysql.a \| grep -c invoke_register_schemas_phase` (same probe the unit Makefile uses) and filter out `test_mysqlx_` from the wildcard when the chassis symbol is absent. Under PROXYSQL40 the wildcard is unmodified and all mysqlx tests are built as before. Verification: `unset PROXYSQLGENAI && unset PROXYSQL40 && make debug -j && make build_tap_test_debug -j` -> 0 errors, builds complete. - proxysql binary built (122 MB) - ProxySQL_MySQLX_Plugin.so NOT built (skipped by top-level Makefile) - 51 unit tests built, 0 plugin/mysqlx unit tests, 0 mysqlx tests/ tests -> chassis is completely invisible to v3.0.	2 months ago
Rene Cannao	96bd55784d	test/tap/tests: wire mysql-zstd_compression_level_libmysql-t into tests target Commit `174c5bda2` added the pattern rule for the _libmysql variant of the zstd_compression_level test but did not add it to the 'tests:' target list, so 'make build_tap_tests' silently skipped building it. Add the missing entry so the libmysql variant is built alongside its siblings.	2 months ago
Rene Cannao	174c5bda20	test: expand zstd_compression_level test with MySQL 8.4 C API and timing benchmark The existing test only verified admin variable behavior (default, range, independence). It did not prove that ZSTD compression was actually active on the wire. Two new test variants address this: MariaDB connector path (mysql-zstd_compression_level-t): - Tests 1-9: unchanged (variable defaults, range validation, independence) - Tests 10-11: use mysql CLI via execvp with --compression-algorithms=zstd and --zstd-compression-level={3,19}. Each call spawns a new process (= new connection). Verifies CONNECTION_ID() retrieval and large resultset transfer. Skipped if mysql CLI lacks zstd support. MySQL 8.4 connector path (mysql-zstd_compression_level_libmysql-t): - Tests 1-9: same as MariaDB path - Test 10: establishes a ZSTD connection using mysql_options( MYSQL_OPT_COMPRESSION_ALGORITHMS, "zstd") and prints mysql_thread_id() without running any query. - Test 11: timing benchmark proving compression is active. Creates a query rule (rule_id=1, cache_ttl=60000) to cache all SELECTs, then runs a 576-row resultset query 1000 times on a plain connection and 1000 times on a ZSTD level 22 connection. ZSTD level 22 is extremely CPU-intensive: observed 40122ms vs 858ms (46.7x ratio). A ratio >= 3x proves compression is really running on the client<->ProxySQL link. Other changes: - MySQL_Protocol.cpp: simplify redundant clamping to a simple cast (the variable is already validated at SET time) - Makefile: add build rule for _libmysql variant linking against MySQL 8.4 connector - groups.json: register _libmysql variant for mysql84/90/95-g1 - CLAUDE.md: update testing section with CI script usage and DO NOT list	2 months ago
Rene Cannao	c72cdd9768	Merge remote-tracking branch 'origin/v3.0' into lint-tap-tests-static-analysis # Conflicts: # test/tap/tests/set_testing-240-t.cpp	3 months ago
Wazir Ahmed	24450eaf72	Use MariaDB replication helper for binlog TAP tests - Replace the external binlog reader with a helper function which uses mariadb replication functions. - The helper opens replication sessions, sends `COM_REGISTER_SLAVE`, and fetches heartbeats to verify the stream is active. - It runs the same two-session flow required for TAP tests: - `test_com_register_slave_enables_fast_forward-t` - `test_binlog_reader_uses_previous_hostgroup-t` Signed-off-by: Wazir Ahmed <wazir@proxysql.com>	3 months ago
Rene Cannao	a3883a8801	test/tap/tests/Makefile: use src/SQLite3_Server.cpp instead of tap/SQLite3_Server.cpp Fixes undefined reference to SQLite3_Server_session_handler in: - anomaly_detection-t - galera_1_timeout_count - galera_2_timeout_no_count The tap/SQLite3_Server.cpp defines its own stub using PtrSize_t, while src/SQLite3_Server.cpp uses _PtrSize_t. Using the src version ensures type consistency with the actual implementation.	3 months ago
Rene Cannao	5c1549dcc6	merge: resolve conflicts with v3.0 branch Merge origin/v3.0 into ProtocolX. One conflict in test/tap/tests/unit/Makefile resolved by keeping both mysqlx unit tests (ProtocolX) and pgsql_servers_ssl_params unit test + GENAI vec.o link (v3.0).	3 months ago
Rene Cannao	e0a96d380e	chore: fix stale rembed reference and simplify test Makefile - Remove stale comment reference to rembed in AI_Features_Manager.cpp - Remove redundant ifeq/else/endif in anomaly_detection-t target (both branches identical after libsqlite_rembed.a removal)	3 months ago
Rene Cannao	44a6c9d583	build(test): drop libsqlite_rembed.a from TAP and rag test link order	3 months ago
Rene Cannao	8de0a60c25	test: add admin schema unit tests, expand listener smoke, update build (42 new assertions) Create mysqlx_admin_schema_unit-t.cpp (15 assertions) testing the DDL registration and command registration from mysqlx_admin_schema in isolation using mock ProxySQL_PluginServices. Verifies all 8 table names registered (mysqlx_users, runtime_mysqlx_users, mysqlx_routes, runtime_mysqlx_routes, mysqlx_backend_endpoints, runtime_mysqlx_backend _endpoints, stats_mysqlx_routes, stats_mysqlx_processlist), null guard for register_table/register_command, and exactly 6 LOAD/SAVE commands. Expand test_mysqlx_listener_smoke-t.cpp from 8 to 15 assertions. Added listener count before start (0), empty routes table (count stays 0), two-route two-port listener creation, stop-and-restart lifecycle, TCP connect verification to both ports, and idempotent stop. Update Makefiles and groups.json to register all new test targets in unit-tests-g1 build group.	3 months ago
Rene Cannao	782e019a8c	wip: capture mysqlx task 5 scaffolding and wrap-up status	3 months ago
Rene Cannao	e24f54261a	fix: keep mysqlx plugin smoke test bridge fresh	3 months ago
Rene Cannao	8e7a99d36a	fix: align mysqlx plugin schema and smoke test	3 months ago
Rene Cannao	d1d10188cc	Register PgSQL FFTO tests in Makefile and groups.json (#5517 ) Add Makefile rules for the two pg_lite_client-based tests: - test_ffto_pgsql_pipeline-t (links pg_lite_client.cpp) - test_ffto_pgsql_stmt_portal-t (links pg_lite_client.cpp) The other 5 PgSQL FFTO tests use the default wildcard rule (%-t: %-t.cpp) and don't need explicit Makefile entries. Register all 7 new PgSQL FFTO tests in groups.json under legacy-g4 and mysql84-g4 (same groups as test_ffto_pgsql-t): - test_ffto_pgsql_command_types-t - test_ffto_pgsql_concurrent-t - test_ffto_pgsql_errors-t - test_ffto_pgsql_large_resultsets-t - test_ffto_pgsql_mixed_protocol-t - test_ffto_pgsql_pipeline-t - test_ffto_pgsql_stmt_portal-t Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	3 months ago
Rene Cannao	2fcfd648e5	Merge remote-tracking branch 'origin/v3.0' into copilot/support-zstd-compression # Conflicts: # test/infra/infra-mysql84/docker-compose-init.bash # test/tap/groups/groups.json	3 months ago
Rene Cannao	4517edea78	Address review feedback and create no-infra TAP group - Fix retry loop in admin_set_credentials_logging-t.cpp to clear eofbit (CodeRabbit) - Fix spelling in lib/Admin_Handler.cpp (CodeRabbit) - Create new 'no-infra-g1' TAP group in groups.json - Add 'tests_no_infra' target to Makefiles to run tests without backends	3 months ago
copilot-swe-agent[bot]	ec44a15058	feat: add mysql protocol zstd compression support Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>	3 months ago
Rene Cannao	c902d21219	build: Cleanup redundant test targets in test/tap/tests/Makefile Removed explicit listings of several tests from the 'tests' target dependency list, as they are already automatically discovered and compiled by the 'tests-cpp' target via the *-t.cpp wildcard rule. Removed: - test_tsdb_variables-t - test_tsdb_api-t - test_ffto_mysql-t - test_ffto_pgsql-t - test_ffto_bypass-t - mcp_query_rules-t These tests do not require custom linking or special build rules beyond the generic %-t pattern, making their explicit inclusion in the main tests list redundant.	4 months ago
Rene Cannao	a72d2bdd20	test: Replace deprecated shell MCP query rules tests with C++ TAP test This commit modernizes the MCP query rules validation by replacing a complex collection of 15+ shell scripts with a single, high-performance C++ TAP test. Changes: - Implemented mcp_query_rules-t.cpp: * Full CRUD validation for mcp_query_rules table. * Verification of LOAD MCP QUERY RULES TO RUNTIME command. * Runtime evaluation tests for Block, Rewrite, and OK_msg actions. * End-to-end verification of hits tracking in stats_mcp_query_rules. - Updated test/tap/tests/Makefile to build mcp_query_rules-t by default. - Removed deprecated test artifacts: * Deleted test_mcp_query_rules-t.sh and its environment files. * Deleted the entire collection of test_phase.sh scripts in mcp_rules_testing/ directory. Kept mcp_test_helpers.sh as it is still required by other MCP-related shell tests. - Improved diagnostic output and error reporting for better observability in CI environments.	4 months ago
Rene Cannao	acef17a8c1	Merge branch 'v3.0-ff_inspect' into v3.0-unified-large-pr # Conflicts: # test/tap/tests/Makefile	4 months ago
Rene Cannao	0691b8a858	build: address reviewer feedback and finalize dynamic linking architecture Implemented comprehensive fixes based on CodeRabbit reviews and user feedback: - Restored dynamic linking for 'libtap.so' using shared 'libpq' and 'libre2' from deps. - Configured absolute 'rpath' in all Makefiles to ensure reliable runtime discovery. - Refined '.gitignore' with directory-scoped PEM patterns and removed broad globs. - Hardened noise routines: added NULL checks for MySQL handles, sanitized reconnect intervals, and wrapped 'std::stol' in try-catch blocks. - Fixed 'internal_noise_rest_prometheus_poller' to use proper HTTP authentication instead of embedding credentials in the URL. - Corrected test plans and logic in 'mysql-set_transaction-t.cpp' and 'test_admin_stats-t.cpp'. - Updated 'NOISE_TESTING.md' with correct heading hierarchy and error mechanism details.	4 months ago
Rene Cannao	788be4adbd	build: restore dynamic linking and configure rpath for shared dependencies Restored 'libtap.so' as the primary target and updated Makefiles to link against shared 'libpq.so' and 'libre2.so' from the deps directory. Implemented 'rpath' embedding in all relevant Makefiles to ensure tests can automatically locate these shared libraries at runtime without manual LD_LIBRARY_PATH configuration. This maintains small binary sizes and adheres to the project's preferred shared-library architecture.	4 months ago
Rene Cannao	ba893e7ce2	build: transition libtap to static archive and bundle dependencies Refactored the build system to use a static 'libtap.a' instead of a shared library. This allows for bundling PostgreSQL, re2, and SQLite3 symbols directly into the archive using a cross-platform extraction and re-archiving method, ensuring compatibility with both GNU and BSD 'ar'. Key fixes: - Resolved 'undefined reference' errors for libpq and re2 symbols in TAP tests. - Fixed 'multiple definition' conflict for 'replace_str' between utils.cpp and proxysql_utils.cpp. - Simplified test Makefiles to link against the self-contained 'libtap.a'.	4 months ago
Rene Cannao	a00abfa369	test: expand noise injection to 20+ TAP tests and update build system - Refactored Makefiles to link libtap.so against static libpq.a from deps. - Injected 'PgSQL Traffic v2', 'REST Prometheus Poller', and 'Random Stats' into 20 unique TAP tests, reaching the 15-20 range for MySQL tests. - Updated 'PgSQL Traffic v2' configuration to use 100 connections and 300ms delay. - Incorporated user documentation update for 'internal_noise_admin_pinger' interval.	4 months ago
Rene Cannao	496f67c7a2	Enhance Noise Injection robustness and error handling - Implement robust connection health checks and retry logic in noise routines. - Introduce global 'noise_failure_detected' flag to propagate fatal noise errors to the main TAP test. - Update exit_status() to report failure if background noise encountered critical issues. - Integrated background noise tools into the TAP test plan (updated plan() counts). - Redirect noise tool stderr to test stderr for transparent error logging. - Refactor NoiseOptions as a std::map for dynamic, routine-specific parameterization. - Fix libtap variants build to ensure noise_utils matches the correct protocol flags. - Link libtap.so and tests against libpq to resolve PostgreSQL dependency errors. - Correct clean_utils target in Makefile to prevent accidental deletion of source headers.	4 months ago
Rene Cannao	69acd4b431	Implement FFTO TAP testing suite - Added comprehensive MySQL FFTO test (text and binary protocols) - Added comprehensive PgSQL FFTO test (Simple and Extended Query protocols) - Added FFTO memory bypass logic test - Added bash orchestration scripts for each test group - Integrated new tests into the TAP Makefile	4 months ago
Rene Cannao	95b46cf21a	tests: add TSDB API and UI verification test - Implemented TAP test for TSDB REST API and Dashboard. - Verified /api/tsdb/{metrics,query,status} endpoints. - Verified /tsdb dashboard accessibility via HTTPS. - Updated Makefile to include new test binary.	4 months ago
Rene Cannao	0e605f4170	build: fix anomaly_detection-t linking for PROXYSQLGENAI When PROXYSQLGENAI is enabled, anomaly_detection-t should link with libsqlite_rembed.a instead of -lscram -lusual due to different SQLite embedding requirements.	5 months ago
Rene Cannao	a57b43286b	Fix TAP test builds with PROXYSQLGENAI Add sqlite-vec and sqlite-rembed libraries to TAP test linking when PROXYSQLGENAI=1 is set. The proxy_sqlite3_symbols.cpp in libproxysql.a references sqlite3_vec_init which requires these libraries. Changes to test/tap/tests/Makefile: - Add libsqlite_rembed.a and vec.o to STATIC_LIBS when PROXYSQLGENAI=1 - Add GenAI libraries to sqlite3-t target - Add GenAI libraries to setparser_test, setparser_test2, setparser_test3 targets - Fix typo: -EXCLUDE_TRACKING_VARIABLES -> -DEXCLUDE_TRACKING_VARIABLES	5 months ago
Rene Cannao	48bc7dd7bf	Merge v4.0 GenAI features into v3.0 with conditional compilation This commit merges the experimental v4.0 GenAI/MCP features into the stable v3.0 branch using conditional compilation. All v4.0 features are disabled by default and only enabled when PROXYSQLGENAI=1 is set at compile time. Changes: Build System: - Modified main Makefile to pass PROXYSQLGENAI flag to sub-makefiles - Modified deps/Makefile to conditionally build sqlite-vec and sqlite-rembed - Modified lib/Makefile to add PSQLGA flag and include GenAI object files - Modified src/Makefile to add PSQLGA flag and conditional linking Headers (wrapped with #ifdef PROXYSQLGENAI): - All 20 new GenAI header files in include/ - Modified cpp.h, proxysql_glovars.hpp, proxysql_admin.h - Modified ProxySQL_Admin_Tables_Definitions.h for GenAI/MCP tables Source Files: - All 22 new GenAI source files in lib/ wrapped with #ifdef PROXYSQLGENAI - Modified src/main.cpp for conditional global variables and init/shutdown - Modified Admin_Handler.cpp for conditional command handlers - Modified Admin_Bootstrap.cpp for conditional table registration - Modified Admin_FlushVariables.cpp for conditional variable flushing - Modified ProxySQL_Admin.cpp for conditional admin methods - Modified ProxySQL_Admin_Stats.cpp for conditional MCP stats functions - Modified proxy_sqlite3_symbols.cpp to always compile (needed by core) - Modified MySQL_Session.cpp for conditional GenAI function calls Test Files: - Renamed test_mcp_query_rules-t to test_mcp_query_rules-t.sh - Renamed test_mcp_rag_metrics-t to test_mcp_rag_metrics-t.sh - Modified anomaly_detection-t.cpp for conditional test execution Usage: # Build without GenAI (v3.0 mode - default) make clean && make build_deps -j$(nproc) && make build_lib -j$(nproc) && make build_src -j$(nproc) # Build with GenAI (v4.0 mode) make clean && PROXYSQLGENAI=1 make build_deps -j$(nproc) && PROXYSQLGENAI=1 make build_lib -j$(nproc) && PROXYSQLGENAI=1 make build_src -j$(nproc)	5 months ago
Rene Cannao	02918d18b8	Fix PR #25 Review: All AI code reviewer feedback addressed This commit addresses all recommendations from CodeRabbit, Gemini Code Assist, and Copilot for PR #25 (FTS security and code quality improvements). Critical Security Fixes: - MCP_Thread.cpp: Rollback fts_path on reset failure to keep config consistent - MySQL_FTS.cpp: Add escape_mysql_identifier() for MySQL query identifier escaping - MySQL_FTS.cpp: Add unique hash-based fallback to sanitize_name() for empty strings - MySQL_FTS.cpp: Add where_clause validation to block dangerous SQL patterns Memory Safety Fixes: - MySQL_FTS.cpp: Fix indexes_result memory leak on early return in search() - MySQL_FTS.h: Delete copy/move operations to prevent accidental resource duplication Thread Safety Documentation: - MySQL_Tool_Handler.cpp: Add comment explaining FTS lock design rationale Test Script Improvements: - test_mcp_fts.sh: Add curl timeouts (5s connect, 30s max) - test_mcp_fts.sh: Remove unused delete_response variable - test_mcp_fts_detailed.sh: Make cleanup tolerant of non-existent indexes Build Fixes: - Makefile: Fix EXCLUDE_TRACKING_VARAIABLES typo to EXCLUDE_TRACKING_VARIABLES - vector_db_performance-t.cpp: Fix printf format specifiers to %lld with cast Schema Fixes: - Query_Tool_Handler.cpp: Change fts_index_table columns schema from string to array Code Cleanup: - MySQL_Tool_Handler.cpp: Remove all remaining debug fprintf statements (34 lines) - Documentation: Change "Full Text" to "Full-Text" (hyphenated) Total: ~50 fixes across 10 files	5 months ago
Rene Cannao	0dc3531744	fix: Linking issues for anomaly_detection-t TAP test - Add special build rule in Makefile for anomaly_detection-t that includes: - $(OBJ) for global variables (GloVars, GloGATH) - -Wl,--allow-multiple-definition to allow test's main() to override ProxySQL's - ClickHouse client libraries (libclickhouse-cpp-lib.a, libzstdstatic.a, liblz4.a) - SQLite rembed library (libsqlite_rembed.a) - -lscram -lusual for PostgreSQL SCRAM support - Add stub function SQLite3_Server_session_handler required by SQLite3_Server.cpp Resolves compilation errors for anomaly_detection-t test.	5 months ago
René Cannaò	75a62f334d	Merge branch 'v4.0' into v3.1-vec Signed-off-by: René Cannaò <rene@proxysql.com>	5 months ago
Rene Cannao	49092e9c8d	test: Add unit tests for AI configuration validation This commit adds comprehensive unit tests for the AI configuration validation functions used in AI_Features_Manager. Changes: - Add test/tap/tests/ai_validation-t.cpp with 61 unit tests - Test URL format validation (validate_url_format) - Test API key format validation (validate_api_key_format) - Test numeric range validation (validate_numeric_range) - Test provider name validation (validate_provider_name) - Test edge cases and boundary conditions The test file is self-contained with its own copies of the validation functions to avoid complex linking dependencies on libproxysql. Test Categories: - URL validation: 15 tests (http://, https:// protocols) - API key validation: 14 tests (OpenAI, Anthropic formats) - Numeric range: 13 tests (min/max boundaries) - Provider name: 8 tests (openai, anthropic) - Edge cases: 11 tests (NULL handling, long values) All 61 tests pass successfully. Part of: Phase 4 of NL2SQL improvement plan	5 months ago

1 2 3 4 5

226 Commits (feature/pgsql-native-backend-protocol)