5 Commits (feature/pgsql-native-backend-protocol)

Author	SHA1	Message	Date
Rene Cannao	187b7e1073	docs(test): fix prerequisites in test/README.md ... - CI base image can be pulled from GHCR instead of built locally - Build commands should use debug mode: make debug + build_tap_test_debug	2 months ago
Rene Cannao	06176265f3	doc(test): address gemini + coderabbit review nits on README flake section ... Three minor corrections from the PR #5609 review: 1. (coderabbit, MD040) The directory-tree fenced block at L74 had no language tag. Added `text` so markdownlint and GitHub's renderer treat it as plain text rather than guessing a language that would then syntax-highlight the tree characters incorrectly. 2. (gemini, L142) The flake-debug loop's "which attempts failed" grep was too narrow: `grep 'FAIL [1-9]'` only matches the proxysql-tester.py summary line "SUMMARY: 'tests' PASS N/M : FAIL K/M" when K is non-zero - but misses tests that fail at the TAP level via "not ok" without incrementing the FAIL counter (e.g. when the binary crashes or times out). Broadened to `grep -lE 'not ok|FAIL [1-9]'` so both paths are caught, matching the idiom already used in the "Where logs actually live" section above. 3. (gemini, L159) The Troubleshooting bullet suggested `docker network prune` as the cleanup idiom for dangling networks. `network prune` is a GLOBAL operation - it would also wipe networks belonging to unrelated Docker projects on the same host, which is user-hostile if a maintainer has other test infras running in parallel. Changed to prefer the targeted form `docker network rm "${INFRA_ID}_backend"` and explicitly call out why `prune` is the wrong default. No change to the "Where logs actually live" section, the "Debugging a flaky test" loop itself, or any of the other content. Doc-only update on top of the earlier commit.	3 months ago
Rene Cannao	f4313be6d9	doc(test): document per-test log paths and flaky-test debugging recipe ... Two gaps in test/README.md surfaced while investigating flaky TAP test failures on PR #5596: 1. The README said "Check logs in ci_infra_logs/${INFRA_ID}/tests/" but did not document the actual layout below that — per-test TAP output lives three directories deep at: ci_infra_logs/${INFRA_ID}/tests/proxysql-tester.py/tests/<test>-t.log.gz The files are gzipped, which makes `cat` and most editors do the wrong thing (binary garbage). A maintainer opening one with vim without knowing to use zless burns several minutes before figuring it out. 2. There was no guidance on how to reproduce a flaky test locally for stress-testing. The typical question "this test passed twice locally and fails on CI - is it really flaky, or is it my environment?" has no canonical answer anywhere in the repo. The natural recipe (reuse one infra, loop N runs, snapshot per-run logs, diff) is described in enough detail for a maintainer to copy/paste it without thinking. This commit adds: - A new "Where logs actually live after a run" section showing the full ci_infra_logs/ directory tree with per-backend, per-ProxySQL, and per-test subdirs. - Concrete zless/zcat/zgrep/zdiff one-liners for reading the gzipped per-test logs (including the cross-test grep idiom). - A new "Debugging a flaky test" section with a copy-pasteable loop that runs the same test 20 times against one infra, snapshotting per-attempt per-test logs for later diffing. - An expanded Troubleshooting bullet list: how to recover from lost INFRA_ID (via `docker network ls`), where each flavor of log lives, and how to clean up stale docker state. No code or workflow changes - doc-only update.	3 months ago
René Cannaò	4c4736c73d	Add SKIP_PROXYSQL support for infrastructure-free test groups ... Unit tests run standalone against libproxysql.a with stubs and need no ProxySQL instance or backend databases. This adds a SKIP_PROXYSQL flag that test groups can set in their env.sh to bypass all Docker infrastructure setup and run tests directly on the host. Changes: - ensure-infras.bash: source group env.sh early; exit immediately when SKIP_PROXYSQL=1 - run-tests-isolated.bash: source group env.sh early; skip ProxySQL and backend verification; run proxysql-tester.py directly on host instead of inside a Docker container - New test/tap/groups/unit-tests/env.sh with SKIP_PROXYSQL=1 - groups.json: add 18 unit test binaries to unit-tests-g1 group - Documentation: SKIP_PROXYSQL in env var tables and new section for infrastructure-free groups in test/infra/README.md	3 months ago
Rene Cannao	3acd6b31d6	Fix max_connections_ff-t: Use dynamic hostgroup discovery ... - Add discover_user_hostgroup() helper function to query default_hostgroup from mysql_users table instead of hardcoding hostgroup=0 - Update test_ff_sess_exceeds_max_conns() to use discovered hostgroup - Update test_ff_only_one_free_conn() to use discovered hostgroup - Update documentation to reflect dynamic hostgroup discovery - Add test/README.md with local CI execution instructions This allows the test to work with any infrastructure configuration (e.g., isolated CI where sbtest1 uses hostgroup 1300 instead of 0).	3 months ago