10 Commits (feature/pgsql-native-backend-protocol)

Author	SHA1	Message	Date
Rene Cannao	7153ac3193	docs(mysqlx): document tls_mode='passthrough' + Router parity matrix update ... Documents the per-route TLS passthrough mode added by issue #5692 and flips the corresponding row in the MySQL Router parity matrix from "P1 gap" to "implemented". doc/mysqlx/README.md: * Adds the `tls_mode` column to the `mysqlx_routes` schema reference in §4.3. * Adds a per-route override subsection to §8.1 (Frontend TLS Modes) documenting all five values (inherit, disabled, preferred, required, passthrough) and explaining the inherit -> deployment-wide `mysqlx_tls_mode` fallback. * Adds a new §8.4 (End-to-end TLS Passthrough) covering the use case (compliance / cert-and-SNI preservation), the operator trade-offs (no pooling, no multiplexing, no per-query routing, no frame-level observability — bytes only), and a worked example. doc/mysqlx/MYSQL_ROUTER_PARITY.md: * Promotes the TLS-modes / TLS-passthrough rows in the comparison table from "No" to "Yes via mysqlx_routes.tls_mode='passthrough'". * Updates the TLS Architecture narrative to call out the third configuration handle (per-route override) alongside the two deployment-wide variables, and adds a paragraph describing the X_PASSTHROUGH_FORWARD splice path. * Strikes through "P1 TLS passthrough" in the Feature Gaps table and adds an implementation reference. * Updates the Summary section to note that all five Router TLS modes are now matched.	2 months ago
Rene Cannao	744fb0bf36	feat(mysqlx): preferred-mode backend TLS fallback to plaintext + docs ... Closes the loop on issue #5693 (P1: asymmetric TLS / AsClient mode). The previous two commits added the runtime variable and the per- session decision; this commit wires the actual `preferred`-mode fallback path in the backend auth state machine and updates the operator-facing documentation to describe the full four-mode model. What changes: * MysqlxConnection::step_auth_capabilities_set_sent now treats a Mysqlx::Error response from CapabilitiesSet(tls=true) as a fall-back trigger when backend_tls_fallback_allowed_ is set (set by the session for mode=preferred). The connection silently downgrades on the same TCP socket — backend_tls_required_ is cleared so subsequent steps don't re-attempt TLS, tls_active_ stays false (which keeps the connection out of the encrypted half of the per-thread pool), and step_auth proceeds straight into AuthenticateStart on plaintext. Under mode=required (and AsClient + frontend-TLS), the same Error is still fatal — the operator's policy demands encryption. The pre-existing `Frame is not OK` rejection branch is preserved for malformed / unexpected response types. * doc/mysqlx/README.md §8 rewritten: * §8.1 frontend TLS modes (mysqlx_tls_mode, unchanged behaviour). * §8.2 backend TLS modes (mysqlx_tls_backend_mode, full table of the four documented values, migration notes from MySQL Router AsClient, and a connection-pool partitioning note explaining that the cache key now includes tls_active. * §8.3 configuration example showing the asymmetric pattern (frontend REQUIRED + backend preferred). The §3.1 variables table gains the new variable. * doc/mysqlx/MYSQL_ROUTER_PARITY.md updated: * Feature comparison row 4 (TLS modes) now lists 4-frontend x 4-backend with explicit mention of mysqlx_tls_backend_mode and issue #5693. * Asymmetric TLS row marked implemented. * Architecture section §TLS rewritten to describe both the frontend mysqlx_tls_mode and backend mysqlx_tls_backend_mode models; identifies passthrough as the remaining gap. * Feature gaps table marks "Asymmetric TLS / AsClient" and "Per-message response state machines" as implemented. * Summary updated. Tests: test/tap/tests/unit/mysqlx_backend_auth_unit-t (was 34): adds 7 new ok lines covering both branches of the fallback decision: * test_backend_auth_preferred_mode_fallback_to_plaintext: 5 assertions across the wire-level transition (state on entry, rc=1 on Error, AUTHENTICATE_START_SENT after fallback, backend_tls_required_ cleared, tls_active false, AuthStart frame on the wire). * test_backend_auth_required_mode_no_fallback_on_error: 2 assertions confirming the same Error is fatal when fallback_allowed=false. Total 42. All 8 (mode x frontend_tls) acceptance combinations from the issue are now covered: 6 by the decision-function tests in mysqlx_message_dispatch_unit-t (commit 2), and the remaining 2 mode=preferred + backend Error cases by the wire-level fallback tests added here. Tested under NOJEMALLOC=1 WITHASAN=1 PROXYSQLGENAI=1. Closes #5693. Stacks on #5706 / #5704.	2 months ago
Rene Cannao	af270316b9	docs(mysqlx): correct ABI version, mysqlx_variables list, start() flow ... Doc-accuracy review pass found three substantive lies in README.md / ARCHITECTURE.md the previous doc rewrite missed. # ABI version Both README §13 and ARCHITECTURE §1 stated "ProxySQL Plugin ABI version 1". The plugin descriptor in mysqlx_plugin.cpp has used PROXYSQL_PLUGIN_ABI_VERSION since chassis introduction; that macro is now 3 (descriptor ABI 2 four-phase lifecycle + ABI-3 register_runtime_view services field). Updated both files to call the right number with a one-liner on what each ABI bump added. # mysqlx_variables list README §3.1 listed eight variables: mysqlx_thread_pool_size, mysqlx_connect_timeout, mysqlx_tls_mode, mysqlx_tls_cert, mysqlx_tls_key, mysqlx_tls_ca, mysqlx_tls_backend_mode, and mysqlx_max_cached_connections_per_thread. Only the four canonical scalars are wired through MysqlxConfigStore — load_variables() in mysqlx_config_store.cpp matches against four exact names and silently ignores everything else; save_variables_to_admin_table DELETEs the entire table and re-inserts only the four. So the TLS-related entries the README told operators to set are accepted into the table by the CHECK constraints, never read by LOAD, and deleted by the next SAVE. §8.2 example was equally misleading: it instructed operators to UPDATE mysqlx_tls_cert / mysqlx_tls_key paths and run LOAD MYSQLX VARIABLES TO RUNTIME, which is a silent no-op. Trim the §3.1 table to the four wired variables, add a paragraph explaining that other variable_name values are silently ignored by LOAD and deleted by SAVE, and trim §8.2 to the one TLS-related variable that actually round-trips (mysqlx_tls_mode). # start() flow README §2.3 step 6 said "The plugin's start() function loads configuration from runtime tables, ...". After the architectural fix mysqlx_start() syncs disk → memory for the editable mysqlx_* tables, then drives the four install_*_from_admin calls (each SELECTing the editable table plus the relevant cross-module runtime_mysql_* projection). Updated to spell out the actual flow. # Smaller corrections ARCHITECTURE §3.5 listed a "MysqlxStatsStore" in the plugin context — there is no such struct. Replaced with the actual context members. ARCHITECTURE §3.6 listed runtime_mysql_users as the only cross-module dependency for installs; install_endpoints also reads runtime_mysql_servers — added that.	2 months ago
Rene Cannao	e678d101a0	docs(mysqlx): rewrite architecture/README for module-owned runtime state ... Both files described the OLD model — runtime_mysqlx_<X> tables as persistent admin-side mirrors, MysqlxConfigStore::load_from_runtime as the canonical reload, copy_table as the LOAD/SAVE mechanism. None of that is true after the architectural fix on this branch. # ARCHITECTURE.md changes - §3.6 mysqlx_config_store row: Responsibility cell now identifies the store as the canonical source of truth and runtime_mysqlx_* as projections. Key methods cell lists the four install_*_from_admin / save_*_to_admin_table / project_*_to_ runtime_view triplets in place of the removed load_from_runtime. Thread-safety cell updated to match. - §3.8 mysqlx_admin_schema row: describes direct interaction with MysqlxConfigStore (no SQLite-to-SQLite copies) and the four refresh_<X>_runtime_view callbacks registered via the chassis services.register_runtime_view(). - §10.2 Admin Command Flow: replaced the single copy_table flow diagram with three flows (LOAD, runtime-view refresh on SELECT, SAVE). Added §10.2.5 explicitly contrasting the new model with the old "authoritative SQLite mirror" model so a reader who skimmed the old docs knows which mental model to discard. - §11 Thread Model: the call graph shows sync_disk_to_memory plus the four install_<X>_from_admin calls instead of the removed single load_from_runtime(). Startup prose updated. # README.md changes - §4.2 / §4.4 / §4.6: section titles changed from "Runtime Table" to "Runtime View"; bodies rewritten to describe the on-demand projection mechanism, with explicit "LOAD never writes / SAVE never reads" notes. - §4.7 (NEW): dedicated runtime_mysqlx_variables section so the documentation surface is symmetric across all four entities. Old §4.7/§4.8 stats sections renumbered to §4.8/§4.9. - §6.3 Dual-Mode Identity Resolution: corrected a stale claim that a user existing only in mysql_users (no mysqlx_users row) could still authenticate with default X Protocol settings. install_users_from_admin explicitly drops canonical-only users from the store; the doc now reflects that. # Intentional historical reference ARCHITECTURE.md §10.2.5 still names the obsolete identifiers (load_from_runtime, copy_table, "INSERT INTO runtime_mysqlx_users SELECT * FROM mysqlx_users") — that paragraph is exactly the "what to unlearn" anchor for readers who internalized the old docs. README.md §4.2 still shows the literal SQL the projection callback emits (DELETE FROM ... INSERT INTO ...), which is the concrete mechanism description rather than a description of the old wrong path.	2 months ago
Rene Cannao	a1def9d927	docs(mysqlx): fix stale TLS, table name, and missing documentation ... Update all four doc/mysqlx/ files to reflect current implementation: - TLS: change from "stub" to "supported" (OpenSSL Memory BIO) - Fix table name: mysqlx_endpoints → mysqlx_backend_endpoints - Add missing X_SESSION_RESET_WAITING state - Add section 5.3 documenting 8 DISK commands - Fix allowed_auth_methods default (empty, not 'MYSQL41,PLAIN') - Add missing comment column to all table schemas - Update test counts: 24 files, 600+ assertions - Update MYSQL_ROUTER_PARITY with accurate TLS/connect-timeout info	3 months ago
Rene Cannao	1a33009667	docs(mysqlx): add MySQL Router X Protocol parity comparison ... Detailed feature-by-feature comparison between MySQL Router 8.0 and the ProxySQL X Protocol plugin covering: - Architecture: async callback vs poll()-based event loop - TLS: Router has 5 modes (Disabled/Preferred/Required/AsClient/Passthrough), ProxySQL has stubs only - this is the biggest feature gap - Authentication: Router is pass-through, ProxySQL does local validation - Connection pooling: ProxySQL has per-thread LRU cache, Router has none - Query-level routing: ProxySQL supports it via hostgroups, Router pins sessions - State machines: Router has ~100 states, ProxySQL has 15 Key findings: - ProxySQL has superior proxy architecture (pooling, multiplexing, local auth, query routing, dynamic config) that Router cannot match - Router has more mature protocol implementation (TLS, per-message states, Capabilities negotiation) - Biggest gap to close is TLS (P0 priority) - Most other differences are by design	3 months ago
Rene Cannao	39b86e0296	docs(mysqlx): update documentation for v2 event-driven architecture ... All three docs updated to reflect the complete rewrite: - ARCHITECTURE.md: poll() event loop, thread pool, session state machine, connection pool, frame forwarding, TLS stubs, Phase 1 vs 2 comparison - README.md: new config variables (thread_pool_size, connect_timeout, tls_mode, max_cached_connections), 23 message type support, v2.0.0 - TESTING.md: 6 new test files, ~138 new assertions, coverage map	3 months ago
Rene Cannao	7c782d05bd	docs: add MySQL X Protocol plugin architecture document ... Developer-facing architecture documentation with ASCII diagrams showing component relationships, client connection flow, admin command flow, thread model, plugin ABI contract, memory ownership rules, and MYSQL41 authentication internals.	3 months ago
Rene Cannao	d90108e5c3	docs: add MySQL X Protocol plugin testing documentation ... Comprehensive testing documentation covering all 16 test files (292+ assertions), three test tiers (unit/integration/E2E), running instructions, test infrastructure patterns, CI workflow using dbdeployer, test coverage map, and guidelines for adding new tests.	3 months ago
Rene Cannao	1dded26e9e	docs: add MySQL X Protocol plugin reference manual ... Comprehensive user-facing documentation covering plugin loading, admin tables (mysqlx_users, mysqlx_routes, mysqlx_backend_endpoints), admin commands (LOAD/SAVE MYSQLX ... TO RUNTIME/MEMORY), authentication methods (MYSQL41/PLAIN), dual-mode identity resolution, routing strategies, quick start example, and Phase 1 limitations.	3 months ago