proxysql

Commit Graph

Author	SHA1	Message	Date
Rene Cannao	f17f63dcdb	docs(agents): formalize procedural lessons from the v3.0-260523 session Adds a Pre-Push Checklist at the top of doc/agents/common-mistakes.md and six new entries (sections 8 extended; 10-15 new) covering the mistakes I actually made during the v3.0-260523 integration session and the discipline corrections that came out of fixing each one: * Pre-Push Checklist — six items, each cross-linked to the relevant section. Item 2 (unit tests) is intentionally qualified: only when binaries are already built and exercise costs seconds; not a 10+-minute extra build. * Section 8 (Didn't Verify Compilation) — extended with the `-j$(nproc)` requirement (`make debug` silently single-threads), the header-changes-need-full-debug-build rule, and the `build_tap_test_debug` requirement when test code changes. * Section 10 — Validate dependency fixes via the real consumer before tagging. The 8-step ParserSQL <-> ProxySQL integration-test gate, motivated by the v1.0.4 -> v1.0.5 -> v1.0.6 churn. * Section 11 — Don't dismiss failing tests as "pre-existing" / "baseline" / "flaky". Cites the set_parser_algorithm_3-g1 case where the "baseline failure" label hid 10 real ParserSQL bugs. * Section 12 — Exhaustive probe before declaring "comprehensive fix". Catalogue first, fix second. * Section 13 — Distinguish test failure from CI infrastructure failure. The LouisBrunner/checks-action 401 case and the cache-restore-race case. * Section 14 — Don't understand the test before "fixing" it. reg_test_4072-show-warnings-t as the example; usleep(10) is load-bearing because it's the bug's reproducer condition. * Section 15 — Don't insert new values in public-API enums; append. The NodeType segfault during the ParserSQL P3/P4/P5 work. All examples are real from the past day. The doc is intended to be read by future agents (myself included) before starting work on the codebase.	1 month ago
René Cannaò	586fb734f8	Move git workflow to top of task template — agents skip buried instructions Learned from agent post-mortem: agents prioritize technical content over administrative instructions. Even when branch info is present, agents skim past it while focusing on code requirements, then use heuristics to fill the gap they don't realize they have. Fix: git workflow is now the FIRST section with "do this before reading anything else" label. Also updates common-mistakes.md with the expanded root cause analysis.	3 months ago
René Cannaò	c54e6e1805	Expand task assignment template with learnings from CodeRabbit plans Adds four new checklist items based on analyzing CodeRabbit's auto- generated plans for issues #5491 and #5492: - #9: Write ready-made prompts for executing agents — pre-digest the task into imperative, sequential, agent-optimized format - #10: Document design decisions with rationale — prevent agents from re-litigating settled architecture choices - #11: Show the research — make codebase analysis visible for verification and context transfer - #12: For refactoring tasks, specify what to replace — exact line ranges, replacement calls, include dependencies Also adds two new entries to the common mistakes table: - "Recreates existing infrastructure" (research contradicts plan) - "Uses wrong infrastructure" (multiple similar patterns exist) Updates the good-vs-bad example to demonstrate the new items.	3 months ago
René Cannaò	bf250c6307	Add agent guidelines documentation Adds doc/agents/ with three guidance documents for AI coding agents, based on lessons learned from Milestone 2-3 unit testing work: - project-conventions.md: ProxySQL-specific rules — directory layout, build system, unit test harness usage, header conventions, circular include dependency warnings, git workflow, dual-protocol coverage - task-assignment-template.md: Generic template and orchestrator checklist for writing GitHub issues that agents can execute correctly. Covers: specifying WHERE/HOW/environment, DO NOT lists, binary acceptance criteria, and the good-vs-bad issue example - common-mistakes.md: Catalog of 9 observed failure patterns with root cause analysis, prevention strategies, and shell commands for detection in agent PRs Also updates CLAUDE.md with a reference to the agent guidelines and a note about the unit test harness.	3 months ago

4 Commits (feature/pgsql-native-backend-protocol)