From feed404031a6a820c0e22af1ecc8bdf3856eee6a Mon Sep 17 00:00:00 2001
From: Rene Cannao <rene@proxysql.com>
Date: Sat, 18 Apr 2026 18:27:48 +0000
Subject: [PATCH] ci: disable repltests/shuntest auto-trigger and fix 'make
 unit_tests'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Two test-infrastructure fixes on this branch.

1) CI-repltests / CI-shuntest: every run since the upstream
   proxysql/jenkins-build-scripts access broke has been failing at the
   Checkout step with HTTP 403. Comment out the workflow_run trigger so
   they no longer auto-fire on every push; keep workflow_dispatch so
   they can still be manually re-run once the token/repo-access is
   fixed. Same root cause affects CI-taptests-groups as well — that
   needs the GH_TOKEN_PROXYSQL secret refreshed, not a code change.

2) test/tap/tests/unit/Makefile: 'make unit_tests' (invoked from
   test/tap/Makefile via $(MAKECMDGOALS)) failed with
     make[1]: *** No rule to make target 'unit_tests'
   because the unit Makefile only exposed 'all' and 'debug'. Commit
   16e94131f intentionally forwards MAKECMDGOALS so
   'make build_tap_test_debug' propagates 'debug' to the submake,
   which is what CI-unit-tests-asan-coverage relies on for
   -DDEBUG-guarded __thread stubs like mysql_thread___session_debug.
   Add a phony 'unit_tests: all' alias so the same pass-through also
   works when the goal name is 'unit_tests'. 'debug' is unchanged.
---
 .github/workflows/CI-repltests.yml | 9 ++++++---
 .github/workflows/CI-shuntest.yml  | 9 ++++++---
 test/tap/tests/unit/Makefile       | 6 ++++++
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/CI-repltests.yml b/.github/workflows/CI-repltests.yml
index f2beac23a..3450d2f50 100644
--- a/.github/workflows/CI-repltests.yml
+++ b/.github/workflows/CI-repltests.yml
@@ -2,10 +2,13 @@ name: CI-repltests
 run-name: '${{ github.event.workflow_run && github.event.workflow_run.head_branch || github.ref_name }} ${{ github.workflow }} ${{ github.event.workflow_run && github.event.workflow_run.head_sha || github.sha }}'
 
 on:
+  # Auto-triggering disabled: jenkins-build-scripts repo access currently
+  # returns HTTP 403 from this workflow. Re-enable by restoring the
+  # workflow_run trigger once jenkins-build-scripts access is fixed.
   workflow_dispatch:
-  workflow_run:
-    workflows: [ CI-trigger ]
-    types: [ completed ]
+  # workflow_run:
+  #   workflows: [ CI-trigger ]
+  #   types: [ completed ]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.workflow_run && github.event.workflow_run.head_branch || github.ref_name }}
diff --git a/.github/workflows/CI-shuntest.yml b/.github/workflows/CI-shuntest.yml
index 59b59b659..8347d2ab1 100644
--- a/.github/workflows/CI-shuntest.yml
+++ b/.github/workflows/CI-shuntest.yml
@@ -2,10 +2,13 @@ name: CI-shuntest
 run-name: '${{ github.event.workflow_run && github.event.workflow_run.head_branch || github.ref_name }} ${{ github.workflow }} ${{ github.event.workflow_run && github.event.workflow_run.head_sha || github.sha }}'
 
 on:
+  # Auto-triggering disabled: jenkins-build-scripts repo access currently
+  # returns HTTP 403 from this workflow. Re-enable by restoring the
+  # workflow_run trigger once jenkins-build-scripts access is fixed.
   workflow_dispatch:
-  workflow_run:
-    workflows: [ CI-trigger ]
-    types: [ completed ]
+  # workflow_run:
+  #   workflows: [ CI-trigger ]
+  #   types: [ completed ]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.workflow_run && github.event.workflow_run.head_branch || github.ref_name }}
diff --git a/test/tap/tests/unit/Makefile b/test/tap/tests/unit/Makefile
index c62fcfd7d..71bc459ff 100644
--- a/test/tap/tests/unit/Makefile
+++ b/test/tap/tests/unit/Makefile
@@ -297,6 +297,12 @@ UNIT_TESTS := smoke_test-t query_cache_unit-t query_processor_unit-t \
 .PHONY: all
 all: $(UNIT_TESTS)
 
+# Alias: top-level 'make unit_tests' (via test/tap/Makefile) forwards the goal
+# name here via $(MAKECMDGOALS), so this target must exist even though `all`
+# does the same thing.
+.PHONY: unit_tests
+unit_tests: all
+
 .PHONY: debug
 debug: OPT += -DDEBUG
 debug: $(UNIT_TESTS)