From dfb3ef2cefc9b2fa5cbcd94804578c6e8b3b6f74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javier=20S=C3=A1nchez=20Parra?= Date: Wed, 14 Dec 2022 12:34:01 +0100 Subject: [PATCH] Fix test_server_sess_status-t to expect autocommit to be set Commit c319438484d918cc90d3cd3eb8dd3d4d0eecd5a1 fixed the bug that caused autocommit to be shown as disabled when it is truly enabled. --- test/tap/tests/test_server_sess_status-t.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/tap/tests/test_server_sess_status-t.cpp b/test/tap/tests/test_server_sess_status-t.cpp index 076481547..c7233600c 100644 --- a/test/tap/tests/test_server_sess_status-t.cpp +++ b/test/tap/tests/test_server_sess_status-t.cpp @@ -133,18 +133,18 @@ int main(int argc, char** argv) { exp_mysql_srv_st, mysql->server_status ); - // TODO-FIXME: We are setting here '0' as expecting to see 'SERVER_STATUS_AUTOCOMMIT' to be false. - // This is a bug that should be addressed, and this test revisited. + uint32_t exp_proxy_srv_st = SERVER_STATUS_AUTOCOMMIT; + ok( - proxy->server_status == 0, + exp_proxy_srv_st == proxy->server_status, "ProxySQL init server status should match expected - exp: '%d', act:'%d'", - 0, proxy->server_status + exp_proxy_srv_st, proxy->server_status ); mysql_query(proxy, "SET SESSION session_track_transaction_info=\"CHARACTERISTICS\""); mysql_query(proxy, "START TRANSACTION"); - uint32_t exp_proxy_srv_st = SERVER_STATUS_AUTOCOMMIT | SERVER_STATUS_IN_TRANS; + exp_proxy_srv_st = SERVER_STATUS_AUTOCOMMIT | SERVER_STATUS_IN_TRANS; ok( exp_proxy_srv_st == proxy->server_status,