mirror of https://github.com/sysown/proxysql
Two SonarCloud hotspots from the previous round didn't actually pick
up the inline annotations:
- lib/DNS_Cache.cpp: the NOSONAR comment was on the line above the
`std::mt19937 gen(...)` construction. Sonar attributes the hotspot
to the construction line itself, so the comment needs to be inline
on that line. Moved it. Kept the explanatory comment block above.
- test/tap/tests/setparser_parsersql_test.cpp: new hotspot on the
strlen() call in the inline_validate_search_path helper added in
commit 950f6415b. Test code, caller-supplied null-terminated C
string, and the SIZE_MAX guard on the very next line bounds the
result. Annotated inline.
No behaviour change; only Sonar annotation cleanups. Should clear the
last two TO_REVIEW hotspots on PR #5809.
pull/5809/head
parent
a315ebe0be
commit
de37c64f5e
Loading…
Reference in new issue