mirror of https://github.com/sysown/proxysql
reg_test_mariadb_metadata_check-t.cpp: - Remove the dead 'cleanup:' label in main(). The label was empty (no cleanup body, just fell through to return exit_status()), so deleting it is purely warning cleanup; no behavior change. test_rw_binary_data-t.cpp: - Fix NULL-deref UB and cross-leak: proxy and admin were each mysql_ init()'d without a NULL check, then immediately passed to mysql_ real_connect. On either side failing, the other side's already- initialized handle was leaked because every error path did a bare 'return EXIT_FAILURE'. - Remove the unused 'cleanup:' label at the end of main(). The label was fall-through-only (nothing ever jumped to it) which is why -Wunused-label fired; behavior is unchanged because the happy path still runs mysql_close on both handles. - Added a TODO comment noting that many MYSQL_QUERY calls in the test body still leak proxy/admin on query failure; restructuring the whole main() is out of scope for this batch.lint-tap-tests-static-analysis
parent
fcfeec42a9
commit
da105ca2b3
Loading…
Reference in new issue