Fixed socket resource leak in case 'bind' fails for 'web_port'

6 years ago · b712c8f334
parent 22d66d5223
commit b712c8f334
1 changed files with 1 additions and 0 deletions
--- a/lib/ProxySQL_Admin.cpp
+++ b/lib/ProxySQL_Admin.cpp
@ -5842,6 +5842,7 @@ void ProxySQL_Admin::flush_admin_variables___database_to_runtime(SQLite3DB *db,
 							tmp_addr.sin_addr.s_addr = INADDR_ANY;

 							if (bind(sfd, (struct sockaddr*)&tmp_addr, sizeof(tmp_addr)) == -1) {
+								close(sfd);
 								proxy_error(
 									"Unable to start WebInterfacePlugin, port '%d' already in use.\n",
 									variables.web_port