From b70b07ead7020740c61a58402ac2e3fc7e167c57 Mon Sep 17 00:00:00 2001 From: Rene Cannao Date: Sun, 11 Jan 2026 19:23:29 +0000 Subject: [PATCH] Skip checksum generation for MCP until feature is complete The checksum generation caused an assert failure because the MCP module was not yet added to the checksums_values struct. For now, we skip checksum generation for MCP until the feature is complete and stable. Changes: - Removed flush_GENERIC_variables__checksum__database_to_runtime() call - Kept flush_mcp_variables___runtime_to_database() to populate runtime_global_variables - Added comment explaining checksum is skipped until MCP is complete This allows ProxySQL to start without crashing while MCP is under development. --- lib/Admin_FlushVariables.cpp | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/Admin_FlushVariables.cpp b/lib/Admin_FlushVariables.cpp index af2d43ae4..40ca0e5c6 100644 --- a/lib/Admin_FlushVariables.cpp +++ b/lib/Admin_FlushVariables.cpp @@ -1226,14 +1226,11 @@ void ProxySQL_Admin::flush_mcp_variables___database_to_runtime(SQLite3DB* db, bo GloMCPH->set_variable(var_name, val); } - // Checksums are always generated - same pattern as admin variables - { - // generate checksum for cluster - pthread_mutex_lock(&GloVars.checksum_mutex); - flush_mcp_variables___runtime_to_database(admindb, false, false, false, true); - flush_GENERIC_variables__checksum__database_to_runtime("mcp", checksum, epoch); - pthread_mutex_unlock(&GloVars.checksum_mutex); - } + // Populate runtime_global_variables + // Note: Checksum generation is skipped for MCP until the feature is complete + pthread_mutex_lock(&GloVars.checksum_mutex); + flush_mcp_variables___runtime_to_database(admindb, false, false, false, true); + pthread_mutex_unlock(&GloVars.checksum_mutex); if (lock) wrunlock(); delete resultset; }