mirror of https://github.com/sysown/proxysql
Two unrelated CI blockers, fixed together because each one alone leaves
the pipeline red and they are trivially independent:
1) `make cleanbuild` (and any other goal that recurses into plugins/mysqlx
on a v3.0/v3.1 box without libprotobuf-dev) failed in
plugins/mysqlx/Makefile because the protobuf-3.x ABI check fires at
parse time. The check is correct for *building* the plugin — running
pre-generated .pb.cc against an ABI-incompatible libprotobuf would
produce a .so that links cleanly and crashes on first virtual
dispatch — but it has no business firing for `clean`/`cleanall`,
which only delete object files. Wrap the check in
`ifeq ($(filter clean cleanall,$(MAKECMDGOALS)),)` so the safety
guarantee is preserved on build paths and clean is now usable on a
bare host. CI-builds was failing every job at Makefile:540 cleanbuild
for this reason, and the failure cascaded through every dependent
test workflow.
2) `mysqlx_compression_unit-t` was added in the X-Protocol Phase-1/2/3
compression commits but never registered in `test/tap/groups/groups.json`.
The lint workflow `check_groups.py --source` flagged it as
"executable test missing from groups.json" and exited 1, blocking
the entire CI run. Add the entry to `unit-tests-g1` with the
`@proxysql_min_version:4.0` tag, matching every other mysqlx unit
test in the file.
Also restore six MySQL test entries that lost their `mysql90-g3`,
`mysql95-g3` tags during the d2e03fae3 conflict-resolution commit, plus
`test_noise_injection-t` which lost the same two. Confirmed against
origin/v3.0 — these were valid groupings on v3.0 that should have been
preserved through the merge but were silently dropped.
Verified locally:
- `cd plugins/mysqlx && make clean` succeeds without libprotobuf
installed (was: fatal `$(error)` at parse time).
- `python3 test/tap/groups/lint_groups_json.py` → "OK (419 entries,
sorted, compact)".
- `python3 test/tap/groups/check_groups.py` → "OK: All 29 executable
tests are registered in groups.json".
fix/test-mysqlx-plugin-load-phase-b
Rene Cannao
4 weeks ago
parent
ce39154731
commit
9f5ed235b8
Loading…
Reference in new issue