From 9502c2e7c45eebd4666209ca55cfdf99ebe2f436 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Canna=C3=B2?= Date: Mon, 4 Nov 2019 14:14:39 +1100 Subject: [PATCH] Report client IP:port when setting lock_hostgroup --- lib/MySQL_Session.cpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/MySQL_Session.cpp b/lib/MySQL_Session.cpp index c3fa1878f..4b428ec01 100644 --- a/lib/MySQL_Session.cpp +++ b/lib/MySQL_Session.cpp @@ -7029,7 +7029,11 @@ void MySQL_Session::unable_to_parse_set_statement(bool *lock_hostgroup) { if (known_query_for_locked_on_hostgroup(CurrentQuery.QueryParserArgs.digest)) { proxy_info("Setting lock_hostgroup for SET query: %s\n", nqn.c_str()); } else { - proxy_warning("Unable to parse unknown SET query. Setting lock_hostgroup. Please report a bug for future enhancements:%s\n", nqn.c_str()); + if (client_myds && client_myds->addr.addr) { + proxy_warning("Unable to parse unknown SET query from client %s:%d. Setting lock_hostgroup. Please report a bug for future enhancements:%s\n", client_myds->addr.addr, client_myds->addr.port, nqn.c_str()); + } else { + proxy_warning("Unable to parse unknown SET query. Setting lock_hostgroup. Please report a bug for future enhancements:%s\n", nqn.c_str()); + } } *lock_hostgroup = true; } else { @@ -7037,7 +7041,11 @@ void MySQL_Session::unable_to_parse_set_statement(bool *lock_hostgroup) { if (known_query_for_locked_on_hostgroup(CurrentQuery.QueryParserArgs.digest)) { //proxy_info("Setting lock_hostgroup for SET query: %s\n", nqn.c_str()); } else { - proxy_warning("Unable to parse unknown SET query. Not setting lock_hostgroup because already set. Please report a bug for future enhancements: %s\n", nqn.c_str()); + if (client_myds && client_myds->addr.addr) { + proxy_warning("Unable to parse unknown SET query from client %s:%d. Setting lock_hostgroup. Please report a bug for future enhancements:%s\n", client_myds->addr.addr, client_myds->addr.port, nqn.c_str()); + } else { + proxy_warning("Unable to parse unknown SET query. Setting lock_hostgroup. Please report a bug for future enhancements:%s\n", nqn.c_str()); + } } } } else {