From 7986544808d10db6da8515ce7d9a22427859b94b Mon Sep 17 00:00:00 2001 From: Andrei Ismail Date: Mon, 22 Jun 2015 11:51:52 +0200 Subject: [PATCH] #292 Stopping ProxySQL pings __after__ gdb has finished running Otherwise, it won't have the chance to ping the server and detect it's waiting for GDB to finish (and interact with the user) while the proxy process is crashed. --- test/proxysql_base_test.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/proxysql_base_test.py b/test/proxysql_base_test.py index 0bb4bef83..4e0f7ece3 100644 --- a/test/proxysql_base_test.py +++ b/test/proxysql_base_test.py @@ -202,9 +202,13 @@ class ProxySQLBaseTest(TestCase): @classmethod def tearDownClass(cls): - cls._stop_proxysql_pings() if cls.INTERACTIVE_TEST: cls._gdb_process.wait() + # It's essential that pings are stopped __after__ the gdb process has + # finished. This allows them to keep pinging ProxySQL in the background + # while it's stuck waiting for user interaction (user interaction needed + # in order to debug the problem causing it to crash). + cls._stop_proxysql_pings() cls._shutdown_docker_services() def run_query_proxysql(self, query, db, return_result=True,