From 6d6015a2034dbee2ea4eb50d2e84381df008fa46 Mon Sep 17 00:00:00 2001 From: Rene Cannao Date: Tue, 31 Mar 2026 07:06:06 +0000 Subject: [PATCH] fix: align MCP Bearer token test with case-insensitive implementation The test expected lowercase 'bearer' to be rejected, but the implementation uses strncasecmp() per RFC 7235 (auth-scheme is case-insensitive). Update test to expect true for lowercase prefix. --- test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp b/test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp index c6d4de496..ee34f13a9 100644 --- a/test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp +++ b/test/tap/tests/unit/genai_mcp_endpoint_unit-t.cpp @@ -94,11 +94,11 @@ static void test_missing_auth_header() { ok(result == false, "validate_bearer_token: empty auth header rejected"); } -static void test_malformed_bearer_prefix_lowercase() { +static void test_bearer_prefix_lowercase() { bool result = MCP_JSONRPC_Resource::validate_bearer_token( "bearer mytoken", "mytoken" ); - ok(result == false, "validate_bearer_token: lowercase 'bearer' prefix rejected"); + ok(result == true, "validate_bearer_token: lowercase 'bearer' accepted (RFC 7235 case-insensitive)"); } static void test_malformed_bearer_prefix_no_space() { @@ -293,7 +293,7 @@ int main() { test_valid_bearer_token_complex(); // 1 test_invalid_wrong_token(); // 1 test_missing_auth_header(); // 1 - test_malformed_bearer_prefix_lowercase(); // 1 + test_bearer_prefix_lowercase(); // 1 test_malformed_bearer_prefix_no_space(); // 1 test_malformed_basic_auth(); // 1 test_empty_token_after_bearer(); // 1