From 6c04e2d5fec4954bc7ceac0366c30b3bbbc5e89b Mon Sep 17 00:00:00 2001 From: Rene Cannao Date: Mon, 22 Dec 2025 04:07:46 +0000 Subject: [PATCH] Address Gemini Code Assist review comments - Split Red Hat/CentOS and AlmaLinux repository sections - Add Amazon Linux 2 to supported OS list - Use dnf for Fedora installation command These changes address the issues identified in the code review: 1. AlmaLinux now uses correct /almalinux/ repository path 2. Amazon Linux added to supported OS list for consistency 3. Fedora installation uses dnf instead of yum All repository configurations now match those in README.md. --- INSTALL.md | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/INSTALL.md b/INSTALL.md index 8bd88dda4..8d9b17970 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -15,6 +15,7 @@ The list of currently supported operating systems for native packaging is: - AMD64 - AlmaLinux 8, 9, 10 + - Amazon Linux 2 - CentOS Stream 9, 10 - Debian 12 (bookworm), 13 (trixie) - Fedora 40, 41, 42 @@ -22,6 +23,7 @@ The list of currently supported operating systems for native packaging is: - Ubuntu 22.04 (jammy), 24.04 (noble) - ARM64 - AlmaLinux 8, 9, 10 + - Amazon Linux 2 - CentOS Stream 9, 10 - Debian 12, 13 - Fedora 40, 41, 42 @@ -50,7 +52,7 @@ wget -nv -O /etc/apt/trusted.gpg.d/proxysql-3.0.x-keyring.gpg 'https://repo.prox echo "deb https://repo.proxysql.com/ProxySQL/proxysql-3.0.x/$(lsb_release -sc)/ ./" | tee /etc/apt/sources.list.d/proxysql.list ``` -#### Red Hat / CentOS / AlmaLinux: +#### Red Hat / CentOS: ```bash cat > /etc/yum.repos.d/proxysql.repo << EOF [proxysql] @@ -72,6 +74,17 @@ gpgkey=https://repo.proxysql.com/ProxySQL/proxysql-3.0.x/repo_pub_key EOF ``` +#### AlmaLinux: +```bash +cat > /etc/yum.repos.d/proxysql.repo << EOF +[proxysql] +name=ProxySQL YUM repository +baseurl=https://repo.proxysql.com/ProxySQL/proxysql-3.0.x/almalinux/\$releasever +gpgcheck=1 +gpgkey=https://repo.proxysql.com/ProxySQL/proxysql-3.0.x/repo_pub_key +EOF +``` + #### OpenSUSE: ```bash cat > /etc/zypp/repos.d/proxysql.repo << EOF @@ -105,9 +118,12 @@ After configuring the repository, install ProxySQL with your package manager: apt-get update apt-get install proxysql -# RHEL/CentOS/AlmaLinux/Fedora/Amazon Linux +# RHEL/CentOS/AlmaLinux/Amazon Linux yum install proxysql +# Fedora +dnf install proxysql + # OpenSUSE zypper install proxysql ```