From 6bedcb08ccc9142fed1c9858c13a5a0b50f8ea41 Mon Sep 17 00:00:00 2001
From: Rene Cannao <rene@proxysql.com>
Date: Sat, 11 Apr 2026 05:38:10 +0000
Subject: [PATCH] ci: fix misleading mysql57 label on ci-mysql84-g{1..5} check
 runs

The five ci-mysql84-g*.yml reusables introduced in #5597 inherited
`infradb: [ 'mysql57' ]` from ci-legacy-g4.yml as the sed template.
The `infradb` matrix value is interpolated into `env.MATRIX` and then
into the check-action step's `name` field, so the GitHub PR UI would
display check runs as `CI-mysql84-g3 / tests (mysql57)` even though
the tests themselves are correctly running against infra-mysql84.

The infrastructure resolution is unaffected -- `ensure-infras.bash`
strips the -gN suffix from TAP_GROUP=mysql84-g3 to get BASE_GROUP=mysql84,
which resolves to test/tap/groups/mysql84/infras.lst (infra-mysql84).
This is purely a display-name fix.

Set infradb to 'mysql84' in all five files so the check run name
matches the backend actually under test.

Caught by gemini-code-assist review on #5598.
---
 .github/workflows/ci-mysql84-g1.yml | 2 +-
 .github/workflows/ci-mysql84-g2.yml | 2 +-
 .github/workflows/ci-mysql84-g3.yml | 2 +-
 .github/workflows/ci-mysql84-g4.yml | 2 +-
 .github/workflows/ci-mysql84-g5.yml | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci-mysql84-g1.yml b/.github/workflows/ci-mysql84-g1.yml
index 123bb6f49..381103267 100644
--- a/.github/workflows/ci-mysql84-g1.yml
+++ b/.github/workflows/ci-mysql84-g1.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        infradb: [ 'mysql57' ]
+        infradb: [ 'mysql84' ]
     env:
       BLDCACHE: ${{ inputs.trigger && fromJson(inputs.trigger).event.workflow_run.head_sha || github.sha }}_ubuntu22-tap_src
       MATRIX: '(${{ matrix.infradb }})'
diff --git a/.github/workflows/ci-mysql84-g2.yml b/.github/workflows/ci-mysql84-g2.yml
index 18d9e205b..8592066ee 100644
--- a/.github/workflows/ci-mysql84-g2.yml
+++ b/.github/workflows/ci-mysql84-g2.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        infradb: [ 'mysql57' ]
+        infradb: [ 'mysql84' ]
     env:
       BLDCACHE: ${{ inputs.trigger && fromJson(inputs.trigger).event.workflow_run.head_sha || github.sha }}_ubuntu22-tap_src
       MATRIX: '(${{ matrix.infradb }})'
diff --git a/.github/workflows/ci-mysql84-g3.yml b/.github/workflows/ci-mysql84-g3.yml
index f35029485..c8ce1a651 100644
--- a/.github/workflows/ci-mysql84-g3.yml
+++ b/.github/workflows/ci-mysql84-g3.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        infradb: [ 'mysql57' ]
+        infradb: [ 'mysql84' ]
     env:
       BLDCACHE: ${{ inputs.trigger && fromJson(inputs.trigger).event.workflow_run.head_sha || github.sha }}_ubuntu22-tap_src
       MATRIX: '(${{ matrix.infradb }})'
diff --git a/.github/workflows/ci-mysql84-g4.yml b/.github/workflows/ci-mysql84-g4.yml
index 88403b82f..2a017863e 100644
--- a/.github/workflows/ci-mysql84-g4.yml
+++ b/.github/workflows/ci-mysql84-g4.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        infradb: [ 'mysql57' ]
+        infradb: [ 'mysql84' ]
     env:
       BLDCACHE: ${{ inputs.trigger && fromJson(inputs.trigger).event.workflow_run.head_sha || github.sha }}_ubuntu22-tap_src
       MATRIX: '(${{ matrix.infradb }})'
diff --git a/.github/workflows/ci-mysql84-g5.yml b/.github/workflows/ci-mysql84-g5.yml
index e8b8d759a..81eaf1000 100644
--- a/.github/workflows/ci-mysql84-g5.yml
+++ b/.github/workflows/ci-mysql84-g5.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        infradb: [ 'mysql57' ]
+        infradb: [ 'mysql84' ]
     env:
       BLDCACHE: ${{ inputs.trigger && fromJson(inputs.trigger).event.workflow_run.head_sha || github.sha }}_ubuntu22-tap_src
       MATRIX: '(${{ matrix.infradb }})'