From 64670f46cc2cd3bc848bfa2a9ba887fd61fa7150 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Canna=C3=B2?= Date: Mon, 12 Dec 2022 03:42:50 +0000 Subject: [PATCH] Minor optimization in unable_to_parse_set_statement() --- lib/MySQL_Session.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/MySQL_Session.cpp b/lib/MySQL_Session.cpp index 6f751ded3..28fd72306 100644 --- a/lib/MySQL_Session.cpp +++ b/lib/MySQL_Session.cpp @@ -7667,11 +7667,7 @@ void MySQL_Session::unable_to_parse_set_statement(bool *lock_hostgroup) { // we couldn't parse the query string query_str = string((char *)CurrentQuery.QueryPointer,CurrentQuery.QueryLength); string digest_str = string(CurrentQuery.get_digest_text()); - string nqn; - if (mysql_thread___parse_failure_logs_digest) - nqn = digest_str; - else - nqn = query_str; + string& nqn = ( mysql_thread___parse_failure_logs_digest == true ? digest_str : query_str ); proxy_debug(PROXY_DEBUG_MYSQL_QUERY_PROCESSOR, 5, "Locking hostgroup for query %s\n", query_str.c_str()); if (qpo->multiplex == -1) { // we have no rule about this SET statement. We set hostgroup locking