From 61ce0a96e8a716b884d424abce532871b5401b53 Mon Sep 17 00:00:00 2001 From: Rene Cannao Date: Thu, 12 Feb 2026 22:49:55 +0000 Subject: [PATCH] Remove redundant sqlite3_finalize calls in pgSQL stats Statements are managed by RAII and auto-finalized --- lib/ProxySQL_Admin_Stats.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/ProxySQL_Admin_Stats.cpp b/lib/ProxySQL_Admin_Stats.cpp index ed1d60f43..b91a5c8c9 100644 --- a/lib/ProxySQL_Admin_Stats.cpp +++ b/lib/ProxySQL_Admin_Stats.cpp @@ -2174,8 +2174,7 @@ void ProxySQL_Admin::stats___pgsql_errors(bool reset) { } row_idx++; } - (*proxy_sqlite3_finalize)(statement1); - (*proxy_sqlite3_finalize)(statement32); + // RAII auto-finalizes statement1 and statement32 statsdb->execute("COMMIT"); } @@ -2575,8 +2574,7 @@ int ProxySQL_Admin::stats___save_pgsql_query_digest_to_sqlite( else it++; } - (*proxy_sqlite3_finalize)(statement1); - (*proxy_sqlite3_finalize)(statement32); + // RAII auto-finalizes statement1 and statement32 if (reset) { if (copy) { statsdb->execute("INSERT INTO stats_pgsql_query_digest SELECT * FROM stats_pgsql_query_digest_reset");