From 5d57fd5c4f0e91b3e2368702792b15cc129e427a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Canna=C3=B2?= Date: Wed, 31 Oct 2018 11:51:41 +0100 Subject: [PATCH] Fix a segfault in Admin for empty queries --- lib/ProxySQL_Admin.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/ProxySQL_Admin.cpp b/lib/ProxySQL_Admin.cpp index 09b1d5fc2..90c06c40e 100644 --- a/lib/ProxySQL_Admin.cpp +++ b/lib/ProxySQL_Admin.cpp @@ -2320,10 +2320,12 @@ void admin_session_handler(MySQL_Session *sess, void *_pa, PtrSize_t *pkt) { unsigned int query_no_space_length=remove_spaces(query_no_space); //fprintf(stderr,"%s----\n",query_no_space); - // fix bug #925 - while (query_no_space[query_no_space_length-1]==';' || query_no_space[query_no_space_length-1]==' ') { - query_no_space_length--; - query_no_space[query_no_space_length]=0; + if (query_no_space_length) { + // fix bug #925 + while (query_no_space[query_no_space_length-1]==';' || query_no_space[query_no_space_length-1]==' ') { + query_no_space_length--; + query_no_space[query_no_space_length]=0; + } } // add global mutex, see bug #1188