From 5bfb6e216cc0d7ac2daf24c6f036ed93c7739217 Mon Sep 17 00:00:00 2001 From: Rahim Kanji Date: Mon, 13 Oct 2025 19:58:56 +0500 Subject: [PATCH] Few fixes --- include/Query_Cache.h | 2 +- lib/ProxySQL_Admin.cpp | 4 ++-- test/tap/tests/pgsql-query_cache_test-t.cpp | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/Query_Cache.h b/include/Query_Cache.h index 7ec91e209..4ca64e327 100644 --- a/include/Query_Cache.h +++ b/include/Query_Cache.h @@ -79,7 +79,7 @@ class Query_Cache { * * @param entry_size The size of each entry in the key-value store. */ - KV_BtreeArray(unsigned int entry_size); + explicit KV_BtreeArray(unsigned int entry_size); /** * Destructs the KV_BtreeArray object. diff --git a/lib/ProxySQL_Admin.cpp b/lib/ProxySQL_Admin.cpp index 066d2b909..9d5793640 100644 --- a/lib/ProxySQL_Admin.cpp +++ b/lib/ProxySQL_Admin.cpp @@ -2514,7 +2514,7 @@ void update_modules_metrics() { if (GloMyQC) { GloMyQC->p_update_metrics(); } - /* Turning off Prometheus metrics collection for PostgreSQL modules in ProxySQL +#if 0 // Turning off Prometheus metrics collection for PostgreSQL modules in ProxySQL // Update pgsql_threads_handler metrics if (GloPTH) { GloPTH->p_update_metrics(); @@ -2527,7 +2527,7 @@ void update_modules_metrics() { if (GloPgQC) { GloPgQC->p_update_metrics(); } - */ +#endif // Update cluster metrics if (GloProxyCluster) { GloProxyCluster->p_update_metrics(); diff --git a/test/tap/tests/pgsql-query_cache_test-t.cpp b/test/tap/tests/pgsql-query_cache_test-t.cpp index eab3284fe..ba5462d41 100644 --- a/test/tap/tests/pgsql-query_cache_test-t.cpp +++ b/test/tap/tests/pgsql-query_cache_test-t.cpp @@ -1012,8 +1012,8 @@ void execute_prepared_test(PGconn* admin_conn, PGconn* conn) { metrics.swap(); - // 4) Optional: test that a simple (non-prepared) SELECT would create a cache entry here - // (verifies rule is active). Uncomment if you want an extra sanity-check in the same test. + // 4) test that a simple (non-prepared) SELECT would create a cache entry here + // (verifies rule is active). if (!executeQueries(conn, { "SELECT 1" })) return;