mirror of https://github.com/sysown/proxysql
CI-builds (ubuntu24,-tap-genai-gcov) was failing on PR #5651 because the proxysql/packaging:build-ubuntu24-v4.0.0 image lacks libprotobuf-dev. The plugin Makefile's pkg-config check at plugins/mysqlx/Makefile:47 fires correctly: protobuf 3.x is required for the vendored .pb.cc/.pb.h that were generated with protoc 3.21.12. The v4.0.0 packaging images were built in anticipation of this PR but never updated to include the new dependency. Two paths to resolve. (a) Update the image and republish proxysql/packaging:build-ubuntu24-v4.0.0 + cousins. (b) Patch the docker-compose entrypoint to install on demand. (a) is the cleaner long-term fix but has a longer feedback loop (separate pipeline, separate review). (b) unblocks CI immediately and keeps working even if a future image rebuild forgets the package again. This commit takes path (b) for all three image families: - docker/images/proxysql/deb-compliant/entrypoint/entrypoint.bash → apt-get install -y libprotobuf-dev (Debian, Ubuntu) - docker/images/proxysql/rhel-compliant/entrypoint/entrypoint.bash → dnf|yum install -y protobuf-devel (CentOS, RHEL) - docker/images/proxysql/suse-compliant/entrypoint/entrypoint.bash → zypper install -y libprotobuf-c-devel || protobuf-devel (SUSE) The install is gated on PROXYSQLGENAI=1 (otherwise the plugin path is not exercised) AND on pkg-config --exists protobuf returning false (image already has it → install is a no-op). Idempotent across container restarts. Once the v4.0.0 packaging images are republished with libprotobuf-dev included, this on-demand install becomes a no-op pkg-config check on every build and can be removed. Tracked in issue #5673. Verified locally: the deb-compliant patch follows the existing entrypoint control-flow exactly (set -eu safe, no early exit, runs before the ${MAKE} ${deps_target} call where the protobuf check would fire).fix/test-mysqlx-plugin-load-phase-b
parent
baeca0e3dc
commit
4bc7044710
Loading…
Reference in new issue