From 468adb450e69ec5c5c2173930873c8024dabfa74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Canna=C3=B2?= Date: Sun, 22 Mar 2026 12:49:26 +0100 Subject: [PATCH] Address review on MySQL error classifier (PR #5512) - Remove unused MYSQL_ERROR_CONTINUE enum value - Clarify retries_remaining parameter semantics in docstring --- include/MySQLErrorClassifier.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/MySQLErrorClassifier.h b/include/MySQLErrorClassifier.h index 9b46549db..6830e1fa8 100644 --- a/include/MySQLErrorClassifier.h +++ b/include/MySQLErrorClassifier.h @@ -15,7 +15,6 @@ * @brief Action to take after a MySQL backend query error. */ enum MySQLErrorAction { - MYSQL_ERROR_CONTINUE, ///< Error handled, continue processing. MYSQL_ERROR_RETRY_ON_NEW_CONN, ///< Reconnect and retry on a new server. MYSQL_ERROR_REPORT_TO_CLIENT ///< Send error to client, no retry. }; @@ -35,7 +34,7 @@ enum MySQLErrorAction { * - multiplex not disabled * * @param error_code MySQL error number. - * @param retries_remaining Number of retries left. + * @param retries_remaining Number of retries left (> 0 to allow retry). * @param connection_reusable Whether the connection can be reused. * @param in_active_transaction Whether a transaction is in progress. * @param multiplex_disabled Whether multiplexing is disabled. @@ -57,7 +56,7 @@ MySQLErrorAction classify_mysql_error( * conditions are met. * * @param server_offline Whether the backend server is offline. - * @param retries_remaining Number of retries left. + * @param retries_remaining Number of retries left (> 0 to allow retry). * @param connection_reusable Whether the connection can be reused. * @param in_active_transaction Whether a transaction is in progress. * @param multiplex_disabled Whether multiplexing is disabled.