From 44b09e0a64b45cd4890e3cfe2adb00679a157ff4 Mon Sep 17 00:00:00 2001 From: Rahim Kanji Date: Thu, 9 Mar 2023 14:46:03 +0500 Subject: [PATCH] Revert "Removed incoming_replication_hostgroups flag" This reverts commit 3aa4055109ef61bdaa399b288dfa427e71f71cfe. --- lib/MySQL_HostGroups_Manager.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/MySQL_HostGroups_Manager.cpp b/lib/MySQL_HostGroups_Manager.cpp index 59590d2c9..cfeca2f2e 100644 --- a/lib/MySQL_HostGroups_Manager.cpp +++ b/lib/MySQL_HostGroups_Manager.cpp @@ -1833,11 +1833,12 @@ bool MySQL_HostGroups_Manager::commit( proxy_debug(PROXY_DEBUG_MYSQL_CONNPOOL, 4, "DELETE FROM mysql_servers_incoming\n"); mydb->execute("DELETE FROM mysql_servers_incoming"); - proxy_debug(PROXY_DEBUG_MYSQL_CONNPOOL, 4, "DELETE FROM mysql_replication_hostgroups\n"); - mydb->execute("DELETE FROM mysql_replication_hostgroups"); - - generate_mysql_replication_hostgroups_table(); - + // replication + if (incoming_replication_hostgroups) { // this IF is extremely important, otherwise replication hostgroups may disappear + proxy_debug(PROXY_DEBUG_MYSQL_CONNPOOL, 4, "DELETE FROM mysql_replication_hostgroups\n"); + mydb->execute("DELETE FROM mysql_replication_hostgroups"); + generate_mysql_replication_hostgroups_table(); + } // group replication if (incoming_group_replication_hostgroups) {