mirror of https://github.com/sysown/proxysql
CodeRabbit + Gemini review pass surfaced four small doc-precision
items, all legitimate. None were code bugs.
# CodeRabbit (markdownlint nit)
- doc/PLUGIN_API.md:455: fenced code block at "DISK ↔ MEMORY ↔
RUNTIME" lacked a language specifier. Added `text` to satisfy
MD040 / fenced-code-language.
# Gemini (3x same root: clarify the matching algorithm)
The chassis dispatch matcher is case-insensitive whole-identifier
substring match, but three docs described it loosely. Plugin
authors deciding what table name to register need to know that
runtime_X does not match runtime_X_extra or stats_runtime_X.
- doc/PLUGIN_API.md:289 ("any admin SELECT against it") -> spell
out the whole-identifier rule with the longer-prefix /
longer-suffix rejection examples.
- doc/plugin-chassis/ABI.md:156 ("appears in the SQL") -> "is
referenced as a whole identifier in the SQL query
(case-insensitive; identifier-aware, so runtime_X_extra or
stats_runtime_X do not match runtime_X)".
- doc/plugin-chassis/FILE_CHANGES.md:102 ("substring match") ->
"case-insensitive whole-identifier substring match", matching
the precise wording already used in section B for the
sql_references_table_ci helper. Cross-section consistency.
No source code touched. No new content sections, only existing
prose tightened.
docs/plugin-chassis-abi3-update
parent
ef32d9df87
commit
29ee30daf9
Loading…
Reference in new issue