You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Wilken Rivera b4be598148 Fix static check issues SA1019 for googlecompute plugins (#9950) ... This change replaces the deprecated constructors `New` with `NewService`. Static check before the change ``` ⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | grep SA1019 | grep google - post-processor/googlecompute-import/post-processor.go:183:18: SA1019: storage.New is deprecated: please use NewService instead. To provide a custom HTTP client, use option.WithHTTPClient. If you are using google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey with NewService instead. (staticcheck) - post-processor/googlecompute-import/post-processor.go:219:18: SA1019: compute.New is deprecated: please use NewService instead. To provide a custom HTTP client, use option.WithHTTPClient. If you are using google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey with NewService instead. (staticcheck) - post-processor/googlecompute-import/post-processor.go:273:18: SA1019: storage.New is deprecated: please use NewService instead. To provide a custom HTTP client, use option.WithHTTPClient. If you are using google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey with NewService instead. (staticcheck) - builder/googlecompute/driver_gce.go:127:18: SA1019: compute.New is deprecated: please use NewService instead. To provide a custom HTTP client, use option.WithHTTPClient. If you are using google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey with NewService instead. (staticcheck) - builder/googlecompute/driver_gce.go:132:25: SA1019: oslogin.New is deprecated: please use NewService instead. To provide a custom HTTP client, use option.WithHTTPClient. If you are using google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey with NewService instead. (staticcheck) ``` Static check after change ``` [go-1.15.2] [1] wilken@automaton in ~/Development/packer/ ⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | grep SA1019 | grep google ```		6 years ago
..
test-fixtures	…
account.go	…
artifact.go	…
artifact_test.go	…
builder.go	builder/googlecompute: add support for oslogin (#9339)	6 years ago
config.go	Support using WinRM over an IAP tunnel	6 years ago
config.hcl2spec.go	ci/tech-debt: Fix vmware acceptance tests (#9636)	6 years ago
config_test.go	Fix failing tests due to IAP communicator host name	6 years ago
driver.go	builder/googlecompute: add support for oslogin (#9339)	6 years ago
driver_gce.go	Fix static check issues SA1019 for googlecompute plugins (#9950)	6 years ago
driver_mock.go	builder/googlecompute: add support for oslogin (#9339)	6 years ago
image.go	…
image_test.go	…
networking.go	…
networking_test.go	…
startup.go	builder/googlecompute: add support for oslogin (#9339)	6 years ago
step_check_existing_image.go	…
step_check_existing_image_test.go	…
step_create_image.go	…
step_create_image_test.go	…
step_create_instance.go	builder/googlecompute: add support for oslogin (#9339)	6 years ago
step_create_instance_test.go	builder/googlecompute: Add WrapStartupScriptFile configuration option	6 years ago
step_create_ssh_key.go	…
step_create_ssh_key_test.go	…
step_create_windows_password.go	…
step_create_windows_password_test.go	…
step_import_os_login_ssh_key.go	builder/googlecompute: add support for oslogin (#9339)	6 years ago
step_import_os_login_ssh_key_test.go	builder/googlecompute: add support for oslogin (#9339)	6 years ago
step_instance_info.go	…
step_instance_info_test.go	…
step_start_tunnel.go	Set project via project flag, not setting in the config (#9662)	6 years ago
step_start_tunnel.hcl2spec.go	rename launch timeout to launch wait	6 years ago
step_start_tunnel_test.go	Set project via project flag, not setting in the config (#9662)	6 years ago
step_teardown_instance.go	…
step_teardown_instance_test.go	…
step_test.go	…
step_wait_startup_script.go	builder/googlecompute: Add WrapStartupScriptFile configuration option	6 years ago
step_wait_startup_script_test.go	builder/googlecompute: Add WrapStartupScriptFile configuration option	6 years ago
template_funcs.go	…
template_funcs_test.go	…
tunnel_driver.go	make tunnel timeout configurable	6 years ago
tunnel_driver_windows.go	make tunnel timeout configurable	6 years ago
winrm.go	…