75 Commits (v1.14.3)

Author	SHA1	Message	Date
Karthik P	8e36b92ce3	Preserve User-Defined Variable File Order (#13350) ... * modifying the for loop to preserver user inputted variable files preference * adding test cases * pr comments + refactoring the for loop for better readability. * pr comments + refactoring the for loop for better readability. * pr comments | handling default case * adding additional test case * fixing test cases * fixing test cases. creating a subdirectory to add a test case for both hcl and json auto var files * adding test case for json auto var file	10 months ago
guoguangwu	7eb6a45cd4	chore: remove refs to deprecated io/ioutil ... Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>	2 years ago
hashicorp-copywrite[bot]	19055df3ec	[COMPLIANCE] License changes (#12568) ... * Updating the license from MPL to Business Source License Going forward, this project will be licensed under the Business Source License v1.1. Please see our blog post for more details at https://hashi.co/bsl-blog, FAQ at https://hashi.co/license-faq, and details of the license at www.hashicorp.com/bsl. * Update copyright file headers to BUSL-1.1 --------- Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>	3 years ago
hashicorp-copywrite[bot]	b7df3ca36f	[COMPLIANCE] Add Copyright and License Headers (#12254) ... Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>	3 years ago
Lucas Bajolet	4d559e23b7	hcl2: don't warn on excluded post-processor (#12187) ... * hcl2template: use && for chaining conditions For deciding if we need to run an error provisioner block, we checked using a nested if that we didn't need to avoid running it. This is unnecessary, and adds a superfluous level of inbrication to the code, so we chain both conditions with &&. * hcl2: don't warn on excluded post-processor When a post-processor is excluded through the -except command-line argument for packer build, we used to print a warning on HCL2 templates if this except statement did not match a build. However, since we can use the except option to avoid running post-processors, we should account for this as well when printing out a warning that there were no matches. This commit adds this counter to the except checks for the post-processors as well.	3 years ago
Lucas Bajolet	ca197afe9b	hcp: remove superfluous return value on GetBuilds ... This commit irons out one of the pain points of the HCP rework by introducing a HCPPublisher interface, implemented both by the JSON Core, and the HCL2 PackerConfig, which keeps a map of the build names used by Packer to the build names pushed on HCP. This in turn lets us go back to the old implementation of the GetBuilds function, which returns a list of (filtered) builds, and eventually an error if something went wrong while processing.	3 years ago
Wilken Rivera	57cbe4e203	core: Update validation options for undeclared variables (#12104) ... * Update validation options for undeclared variables In an effort to help users move from JSON to HCL2 templates the support for variable definitions files are being updated to ignore undeclared variable warnings on build execution. For legacy JSON templates builds no warnings are displayed when var-files contain undeclared variables. Since preferred mode HCL2 templates is to be explicit with variable declarations - they must be declared to be used - validation for undeclared variables still warns when running `packer validate`. A new flag has been added to the validate command that can be used to disable undeclared variable warnings. * Update validation test for unused variables Example Run ``` ~> go run . validate -no-warn-undeclared-var -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl The configuration is valid. ~> go run . validate -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl Warning: Undefined variable The variable "unused" was set but was not declared as an input variable. To declare variable "unused" place this block in one of your .pkr.hcl files, such as variables.pkr.hcl variable "unused" { type = string default = null } The configuration is valid. ~> go run . build -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl file.chocolate: output will be in this color. Build 'file.chocolate' finished after 744 microseconds. ==> Wait completed after 798 microseconds ==> Builds finished. The artifacts of successful builds are: --> file.chocolate: Stored file: chocolate.txt ``` * Rename Strict field to WarnOnUndeclaredVar The field name Strict is a bit vague since it is only used for checking against undeclared variables within a var-file definition. To mitigate against potential overloading of this field it is being renamed to be more explicit on its usage. * command/build: Add warn-on-undeclared-var flag Now that the default behaviour is to not display warnings for undeclared variables an optional flag has been added to toggle the old behaviour. ``` ~> go run . build -warn-on-undeclared-var -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl Warning: Undefined variable The variable "unused" was set but was not declared as an input variable. To declare variable "unused" place this block in one of your .pkr.hcl files, such as variables.pkr.hcl variable "unused" { type = string default = null } file.chocolate: output will be in this color. Build 'file.chocolate' finished after 762 microseconds. ==> Wait completed after 799 microseconds ==> Builds finished. The artifacts of successful builds are: --> file.chocolate: Stored file: chocolate.txt ```	3 years ago
Lucas Bajolet	c0e7e7bd3c	hcl2: report error on build without sources ... When a template describes a build block without a source reference, the build should be considered invalid as we won't have a CoreBuild produced as a result of the need to have both. In current versions of Packer, this will produce an error message hinting that nothing will happen because of the lack of either build or source block. This commit takes the defined block, and points out to it as missing a source block as being the reason why nothing is happening, making it clearer what is required for an HCL2 build to be processed.	3 years ago
Lucas Bajolet	61c56e161c	hcl2: add example for undefined variable set warn ... When a variable is set in a pkrvars file, but isn't defined, an error message is output, but does not deliver an example of what is expected by Packer in order to complete a build. To remedy that, we improve the error message by giving an example of variable block to include in the build template.	3 years ago
Lucas Bajolet	e94b8766cb	build: exit immediately if no builds and diags ... When a template with some builds to run ends its GetBuilds with an error, and no builds produced, we can exit immediately without printing more errors.	3 years ago
Eng Zer Jun	f5ec0f1c57	test: use `T.Setenv` to set env vars in tests ... This commit replaces `os.Setenv` with `t.Setenv` in tests. The environment variable is automatically restored to its original value when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.Setenv Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	3 years ago
Lucas Bajolet	a298617ecb	command/build: warn and exit when nothing to build ... When a `packer build' is run on a config that does not define anything to be built, the process would run normally, and only state that no artifacts were produced after builds were run successfully. This is misleading as we reach the end of the command without having a proper warning that nothing was even attempted to be built. This commit adds a warning when that happens, and leaves immediately after.	3 years ago
Adrien Delorme	0362a3ec10	all shells: Pass env vars through a key value store (#11569) ... * allowing to set shell env vars from a key/value map. * tests This new map will work alongside the `environment_vars` but it allows using a datasource value seamlessly. At validation, and because `environment_vars` was an array of strings containing `KEY=value`, using datsources would not work, because these values are not known yet and would evaluate to `<unknown>`. With this, the value and the key can be unknown and will validate correctly for datasources.	4 years ago
Adrien Delorme	e03ad29ca0	Sanitize var code (#11566) ... * evaluateLocalVariables: modify code for readability and some (not benchmarked) perfs * Make default input variable type the DynamicPseudoType This should be the default, and avoids a panic. This type can represent situations where a type is not yet known. Its meaning is undefined in cty. * do not take Empty types from default value * Update types.variables.go Co-authored-by: Wilken Rivera <wilken@hashicorp.com>	4 years ago
Adrien Delorme	3278c1a817	Packer SVC acc tests (#11274)	4 years ago
Wilken Rivera	4a0fbd911a	Add support for variable interpolation to hcp_packer_registry and build blocks. (#11421) ... * Add variable interpolation support to hcp_packer_registry block * Add tests for variable interpolation in hcp_packer_registry block * Add variable interpolation support to the build block (#11425) * Add simple test to build command	4 years ago
Adrien Delorme	710d109c55	HCL2: fix a crash when an HCL2 component is nil after a misconfiguration (#11382) ... * add test for crash * fix * show more precise error message when parse of a provisioner fails * Revert "fix" This reverts commit fc88e89fbb. * add better severity	4 years ago
Adrien Delorme	254e020b08	Allow to use build variables in a post processor (#11323) ... * hcl: add test to verify that build.name can be used in a pp * allow to use build vars in post processors	4 years ago
Adrien Delorme	3135714465	rename all things 'inexist[e|a]nt' to 'nonexistent' & fix tests (#11325) ... + a typo	4 years ago
Adrien Delorme	9d0193ac14	add possibility to use variables everywhere in post-processor blocks (#11094) ... feature + tests. Including in: * name * only * except * keep_input_artifact Example file: ```hcl source "null" "example1" { communicator = "none" } source "null" "example2" { communicator = "none" } locals { except = "null.example1" } variable "only" { default = "null.example1" } build { sources = ["source.null.example1", "source.null.example2"] post-processor "shell-local" { except = [local.except] inline = ["echo first post-processor"] } post-processor "shell-local" { only = [var.only] inline = ["echo second post-processor"] } } ``` Ouput: ```shell-session $ packer build foo.pkr.hcl null.example1: output will be in this color. null.example2: output will be in this color. ==> null.example1: Running post-processor: (type shell-local) ==> null.example2: Running post-processor: (type shell-local) ==> null.example2 (shell-local): Running local shell script: /var/folders/3k/2gb5ct4s7cncr52_jh2kz6cw0000gq/T/packer-shell201696062 ==> null.example1 (shell-local): Running local shell script: /var/folders/3k/2gb5ct4s7cncr52_jh2kz6cw0000gq/T/packer-shell494781572 null.example1 (shell-local): second post-processor Build 'null.example1' finished after 61 milliseconds 432 microseconds. null.example2 (shell-local): first post-processor Build 'null.example2' finished after 111 milliseconds 678 microseconds. ==> Wait completed after 111 milliseconds 714 microseconds ``` close #4895	5 years ago
Adrien Delorme	77a29fc2f8	Allow to have `dynamic` blocks in a `build` block + tests (#10825) ... This : * allows to have a `build.dynamic` block * add tests * makes sure to show a correct message when a source was not found * display only name of source (instead of a weird map printout) * use a "Did you mean %q" feature where possible Because dynamic blocks need all variables to be evaluated and available, I moved parsing of everything that is not a variable to "after" variables are extrapolated. Meaning that dynamic block get expanded in the `init` phase and then only we start interpreting HCL2 content. After #10819 fix #10657	5 years ago
Adrien Delorme	a115b428ac	simplify fmt test case a little	5 years ago
Sylvia Moss	ef4afafde9	Fix force flag for hcl2 provisioners and post-processors (#10571)	5 years ago
Adrien Delorme	ed091163be	HCL2 Parse packer.required_plugins block + packer init (#10304) ... This adds the new `required_plugins` block to be nested under the packer block. Example: ```hcl packer { required_plugins { aws = { version = ">= 2.7.0" source = "azr/aws" } azure = ">= 2.7.0" } } ``` For example on darwin_amd64 Packer will install those under : * "${PACKER_HOME_DIR}/plugin/github.com/azr/amazon/packer-plugin-amazon_2.7.0_x5.0_darwin_amd64" * "${PACKER_HOME_DIR}/plugin/github.com/hashicorp/azure/packer-plugin-azure_2.7.0_x5.0_darwin_amd64_x5" + docs + tests	5 years ago
Sylvia Moss	291121dd55	(2) Implement datasources (#10440)	5 years ago
Adrien Delorme	52d2d7fe5f	Copy `MapOf...` plugin types back into Packer core (#10466) ... * move maps of plugins back in core * go mod vendor * more fixes * fix imports * Update core_test.go * fix build * more fixes * more fixes * up vendors after fixing sdk * Update post_processor_mock.hcl2spec.go * Leave implementatino of MapOf in the sdk for plugi tests Other wise use the interface * go mod tidy * add MapOfDatasource type too	5 years ago
Megan Marsh	88b7b0e14a	remove sdk	5 years ago
Megan Marsh	5576bb5caa	move packer config constants next to the packer config	5 years ago
Megan Marsh	b69d69095e	move postprocessor to sdk, fix generation code	5 years ago
Megan Marsh	be5763ec41	move provisioner interface into sdk	5 years ago
Megan Marsh	ada91b24e9	extract builder interface to sdk	5 years ago
Megan Marsh	d5971ca25e	fix tests by moving mock hooks and communicators, and BasicUi definition, into SDK	5 years ago
Adrien Delorme	6dd06fad14	add command/ tests	5 years ago
Megan Marsh	66b81d9bee	add build.name to hcl code (#10114)	5 years ago
Adrien Delorme	3d7ab9ea43	add an hcl2-json test	6 years ago
sylviamoss	39a8dee4ea	add tests and update override example	6 years ago
Chris Gilmer	6e918c4bd3	Update test for builder output	6 years ago
Adrien Delorme	125178d943	core: Decode: when in HCL2 decoding mode; reset the whole struct before preparing it. (#9622) ... * core: Decode when in HCL2 decoding mode; reset the whole struct before preparing it. * HCL2: add path variables + docs & tests Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Adrien Delorme	a15ad19411	test builds can be 'excepted'	6 years ago
Adrien Delorme	c1c8b8d22a	complete -> recipes	6 years ago
Adrien Delorme	0deaa5d2a5	add a complete tests for builder variables + only/except	6 years ago
Adrien Delorme	7969b690de	Revert "Share build info with Provisioner and Post-Processor via HCL2 variables (#9444)" ... This reverts commit 99046c9178.	6 years ago
Sylvia Moss	99046c9178	Share build info with Provisioner and Post-Processor via HCL2 variables (#9444)	6 years ago
Adrien Delorme	fb337f8867	hcl work on only/except (#9454) ... * HCL2: allow to skip a named build block too * test that excepting a build block works * test only on a named build block * add/update docs	6 years ago
Moss	daaeccd8b0	Skip consecutives post-processors	6 years ago
Moss	bfb9df0039	fix except flag for JSON and HCL2	6 years ago
Adrien Delorme	e6aac8cd6f	Update build_test.go	6 years ago
Adrien Delorme	efcc6af06c	fix tests	6 years ago
Adrien Delorme	42a05e1e80	more refactoring	6 years ago
Tom Dyas	c0a6623ea2	teach HCL mode builds to honor -only and -except options (#8947)	6 years ago