201 Commits (ff4674a49c554edaedddc7eb9be8825ebdfedcac)

Author	SHA1	Message	Date
Megan Marsh	d252a24b82	allow user to set winrm_host override like we do ssh_host override	6 years ago
Sylvia Moss	0677b02e18	Share SourceImageName with provisioners and manifest post-processor (#8603)	6 years ago
Megan Marsh	82f03fca7c	fix to work with hcl2; update tests	6 years ago
Megan Marsh	4059ed75f5	update docs to mention ssh auth sock env var (#8523) ... Closes #8358 Add some docs to alleviate confusion.	6 years ago
Megan Marsh	cd7abf1f9e	clean up a few final issues with info sharing	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	82367a88f8	reorganize placeholder data call to live with provisioner implementation; force users to use the generated function, therefore forcing validation, for all variables except winrmpassword, by doing a simple string check against the placeholder data.	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
nywilken	a61fe833ef	helper/communicator/step_connect_ssh: Update proxy connection settings to use `SSHProxyUsername` and `SSHProxyPassword`	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Chris Roberts	8bb7d8dc16	Prevent busy loop while waiting for WinRM connection ... Set first run variable outside conditional so it will properly be updated during the first run and pause on subsequent runs.	7 years ago
Megan Marsh	85de1d0637	make friendlier message warning user that their creds may be wrong	7 years ago
Adrien Delorme	3fe9d52e3f	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Daniel Kimsey	3b64620234	SSH tunneling support ... Support for both local and remote TCP port tunneling. Includes updated docs and tests. Does not implement dynamic port forwarding (SSH's built-in SOCKS) (uncertain difficulty) nor unix socket (potentially easy).	7 years ago
Adrien Delorme	5517d41468	make sure all documentation fields are there ... * add missing `temporary_key_pair_name` field for alicloud * add missing description to `vpc_filter` for aws * add missing ssh communicator fields for aws * add links for aws * update vmware-vmx docs * manually describe AMI Configuration section for ebsvolume * display missing required ami_name field for aws * add missing fields for docker * add missing fields for openstack	7 years ago
Adrien Delorme	db880ab50a	add decoding tests for trilean	7 years ago
Megan Marsh	3c3f7f26ce	implement custom data type "trilean" (tri-state-boolean) to track booleans which have a "null" or "unset" state. Previously we used *bool for these template options, but it turns out that those won't work because "unset" will evaluate to "false" if a user is using template variables to set the option that maps to a *bool.	7 years ago
Adrien Delorme	4cb7c30987	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Stephen Fox	9592211bcf	Honor value of 'Comment' field in 'ssh.KeyPairFromPrivateKey()'. ... The 'ssh.KeyPairFromPrivateKey()' function in the 'ssh' helper library was not honoring the value of the 'Comment' field in the 'FromPrivateKeyConfig' struct. This commit fixes the issue, and updates unit tests to catch the issue if it happens again.	7 years ago
Vladislav Rassokhin	19e8f150a3	Use context for timeouts, interruption in ssh and winrm communicators ... Also don't waste 5 seconds waiting before first winrm connection attempt Minor code cleanup as well	7 years ago
Megan Marsh	ba66d5d857	Merge pull request #7831 from hashicorp/fix_ssh_interface ... Revert "move SSHInterface/SSHIPVersion fields to communitator.Config …	7 years ago
Megan Marsh	242f5b1c9f	typos	7 years ago
Megan Marsh	8718e98efe	add common commHost function	7 years ago
Megan Marsh	6ad975f296	Revert "move SSHInterface/SSHIPVersion fields to communitator.Config struct" ... This reverts commit b0c09087a2.	7 years ago
Adrien Delorme	6e3dc1aa9a	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Adrien Delorme	d16fd8a2b1	allow to build on solaris	7 years ago
Megan Marsh	df916e805e	borrow wrappedreadline workarounds from terraform and implement a similar check for piped commands; this makes the cli experience much cleaner	7 years ago
Adrien Delorme	4bf6a56d71	split communitacor.SSH & communitacor.WinRM to facilitate documentation ... put doc for communicator into the struct	7 years ago
Adrien Delorme	e96409954a	add execution policy type and use it to default the powershell cmd	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	a81abd297b	Merge remote-tracking branch 'origin/master' into context_provisioner	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	82c4b76639	[Builder|Build|PostProcessor|Provisioner|Hook]Server: context cancel using a RPC cancel method	7 years ago
Adrien Delorme	cccbd7f316	contextualize basic runner	7 years ago
Adrien Delorme	a4bf94dd3c	change Builder to be passed a context for cancellation ... we have to to give it to our hook	7 years ago
Megan Marsh	8f3313d81e	Create new docker communicator for windows containers	7 years ago
Adrien Delorme	7737458d17	fix log output	7 years ago
Adrien Delorme	5a6dffde9a	use port as ints	7 years ago
Adrien Delorme	025fc87278	StepConnectSSH: show connection address in debug output	7 years ago
Adrien Delorme	c214f6735b	make everything a uint	7 years ago
Adrien Delorme	9f82b75e57	Use the hashicorp/go-getter to download files ... * removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same. * removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context. * on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors. * added unit tests for step_download that are now CI tested on windows, mac & linux. * files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension` * since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted. * a download file is protected and locked by a file lock, * updated docs * updated go modules and vendors	7 years ago
Megan Marsh	3dc1dafe58	Merge pull request #7287 from stephen-fox/ephemeral-ssh-key-pair-issue-7225 ... virtualbox: create ephemeral SSH key pair for build process	7 years ago
Stephen Fox	d51e300fcd	Clarified comment for 'defaultRsaBits' constant. ... That *is* a lot of bits.	7 years ago
Stephen Fox	7e1cbc6d89	Rename references to key pair name to comment. ... Per the OpenSSH manual, the field is for a comment.	7 years ago
Stephen Fox	094c87e395	Remove 'SSHPublicKeyUrlEncoded', use 'urlquery' instead. ... Per code review feedback, the Go template library supports encoding variables in URL query format. Instead of exposing two different public key formats (unmodified string and a URL encoded string), just have the user apply the 'urlquery' modifier to their template.	7 years ago
Stephen Fox	856810e82e	Coalesce private key type switch cases per review feedback.	7 years ago