899 Commits (ff01e6715ab6ae89d4353ce7d98d356700a7bb30)

Author	SHA1	Message	Date
Sylvia Moss	31f08909b4	Add usb_scan_codes option to use USB scancodes instead of VNC for remote builds (#9895)	6 years ago
Megan Marsh	d2dd158fe2	Implement cd_files option. The Addfile code is modified from the floppy_files ... tooling. Tested on OSX, `Windows, and Linux. Documented command line dependencies. Added acceptance tests (behind testacc flag, since there are dependencies). This option is only implemented for the vmware and hyperv iso builders. It will be implemented for others in later PRs in order to make review easier.	6 years ago
Lars Lehtonen	03a0beb683	builder/vmware/common: simplify type assertion switch (#9893)	6 years ago
Wilken Rivera	f4556fd3f1	Merge pull request #9831 from hashicorp/remedial_remote_export_config_tests ... add tests to make sure prepare for export defaults properly	6 years ago
Wilken Rivera	03a374f4b6	Fix linting issues for SA6005 check (#9854) ... Before change ``` ⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005 builder/profitbricks/step_create_server.go:254:22: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck) builder/oneandone/config.go:97:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck) builder/vmware/common/driver_parser.go:1199:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck) ``` After change ``` ⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005 ```	6 years ago
Megan Marsh	1c5bc41beb	refactor ovftool validation into vmware driver	6 years ago
Megan Marsh	bbc3a5b0d1	add tests to make sure prepare for export defaults properly	6 years ago
Megan Marsh	a6d5106cd7	Allow "export" to ovf/ova for local vmware builds in addition to esx ones. ... Refactor step_export and the driver interface to move the ovftool call into the vmware driver. This refactor allows us to add meaningful tests to step_export, which I have also added here.	6 years ago
Megan Marsh	e9b526ee2d	Move step_create_disk into common folder, and add to vmx builder (#9815) ... Pull additional disk related config options into their own file.	6 years ago
Megan Marsh	a2cfaace59	extract output dir configuration and defaulting into the step_output_dir, using pointers to make sure they get set properly back on the main config	6 years ago
Megan Marsh	3b2bedf794	implement a remote_output_directory option, and heavily comment output code	6 years ago
Megan Marsh	b0d2201d55	Merge pull request #9782 from hashicorp/fix_9151 ... fully destroy vm if it was cancelled or errored	6 years ago
Megan Marsh	0a5cd953fc	fully destroy vm if it was cancelled or errored	6 years ago
Megan Marsh	aa2418cf01	add progress tracker to vmware-esx iso upload. Add colored prefix to … (#9779) ... * add progress tracker to vmware-esx iso upload. Add colored prefix to tracker to make it clear which build a tracker belongs to. * fix mock; fix tests	6 years ago
Megan Marsh	25f2ec48d3	add network_name option to vmware builder to make it match the network option on the vsphere builder, so vmware users needn't update vmx data just for the network name (#9718)	6 years ago
Megan Marsh	395a0c472e	improve postprocessor stdout	6 years ago
Megan Marsh	b3c3e3ed63	Merge pull request #9589 from hashicorp/fix_9184 ... post-processor/vsphere: Fix password encoding in vsphere post-processor ovftool call	6 years ago
Adrien Delorme	44616d3bff	refactor initialization out from packer configs + tests (#9627) ... The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost. This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too. fix #9478	6 years ago
Megan Marsh	74aef3c819	apply same url encoding to other places we call ovftool	6 years ago
Megan Marsh	a687d6fe12	ci/tech-debt: Fix vmware acceptance tests (#9636) ... * add kex algorithm option to ssh config * regenerate code * This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts: 1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed. 2) It modifies logic in reading and defaulting hardware config values, which was crashing. 3) It adds a new acceptance test with a preseed file to test loading from an http directory.	6 years ago
Adrien Delorme	1edd848877	esx5driver.VerifyChecksum: try checksum remote file instead of local file ... fix #9456	6 years ago
Roger Hu	28f8241a05	update generated files	6 years ago
Moss	8ea64c5b35	undocument ssh_keypair_name and ssh_agent_auth	6 years ago
Moss	41edd09d3c	undocument temporary_key_pair_name and ssh_private_key_file	6 years ago
Megan Marsh	4f77bb0c4a	add new ssh_ciphers option	6 years ago
Megan Marsh	4178625afb	re-add winrm_no_proxy option. Winrm code needs to be modified in order to read no_proxy env var when client is created rather than when net/http library is instantiated.	6 years ago
Ali Rizvi-Santiago	3da5a64a8d	Fixed a race in the ReadNetworkingConfig implementation from the parsers belonging to the vmware builders that existed between reading the version and consuming tokens from the rest of the file.	6 years ago
Megan Marsh	5d67183c4c	fix test	6 years ago
Megan Marsh	093cfcfd9f	Merge pull request #9322 from arizvisa/GH-8528 ... Fix the VMware builders when the guest platform's dhcpcd switches the ip address in-between a build	6 years ago
Ali Rizvi-Santiago	8985ba077c	Re-added the (mistakenly removed) host override to the CommHost for the vmware builders.	6 years ago
Megan Marsh	4cd3429914	add ssh override test	6 years ago
Ali Rizvi-Santiago	9c5a65263f	Added @SwampDragons' suggestion to the `CommHost()` implementation for the vmware builders which uses the communicator config's `Config.Port()` function to determine the communication port-number independent of the configured protocol.	6 years ago
Megan Marsh	baed65156c	Merge pull request #9319 from arizvisa/GH-8528.refactor ... This refactors the dhcpd lease parser in the vmware builders and adds unit tests for everything.	6 years ago
Ali Rizvi-Santiago	898321bcfe	Added suggestions from @SwampDragons to the parsers from the vmware builders, included unit-tests and sample file for fusion's networking file, and fixed a few situations where the channel wasn't being closed.	6 years ago
Joshua Foster	d35f342319	add the ability to configure the http bind address. defaults to 0.0.0.0.	6 years ago
Megan Marsh	df37918467	Merge pull request #9303 from arizvisa/GH-8528.unit-tests ... Unit tests for the driver_parser.go functionality of the vmware builder	6 years ago
Ali Rizvi-Santiago	e5b6d8c37c	Didn't know that WinRM uses a different variable for the port number when trying to determine the communication host in `CommHost`...now it's fixed.	6 years ago
Ali Rizvi-Santiago	229b5d17ff	Re-worked the vmware builder drivers so that they're able to check multiple ip addresses when trying to connect via the CommHost.	6 years ago
Ali Rizvi-Santiago	0609909f1a	Fixed some lint issues.	6 years ago
Ali Rizvi-Santiago	ad7194c920	Rewrote the GuestIP implementation in the vmware builder to use the new dhcpd lease parsers instead of the old regexp-based logic.	6 years ago
Ali Rizvi-Santiago	020b005522	Finished implementing the final dhcpd lease entries parser for the vmware builders and also included its own unit tests.	6 years ago
Ali Rizvi-Santiago	cf5332fa20	Updated the dhcpd lease entry parser in the vmware builder to return errors if any are encountered.	6 years ago
Ali Rizvi-Santiago	afa4696985	Tightened the regular expressions used by the vmware builder to parse the dhcpd leases, and added support for parsing the weekdays.	6 years ago
Ali Rizvi-Santiago	e2a7c317eb	Implemented the dhcpd lease entry decoder and the address decoder for the vmware builder.	6 years ago
Ali Rizvi-Santiago	efb775accb	Added a number of parsing combinators to the vmware builder and some minor tests for them to help with parsing dhcpd leases.	6 years ago
Ali Rizvi-Santiago	f17007d546	Removed the sentinelSignaller chan from the vmware builder parsers and its unit-tests, and also commented all of the goroutines that are used.	6 years ago
Ali Rizvi-Santiago	159ea595df	More lint issues fixed...	6 years ago
Ali Rizvi-Santiago	32b64e0576	Fixed some lint issues in the unit tests for the vmware builder driver parsers.	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Adrien Delorme	0fa60c68fb	Drop the iso_checksum_type & iso_checksum_url fields (#8437) ... * Drop the iso_checksum_type & iso_checksum_url fields In favor of simply using iso_checksum that will know what to do. * fix after master merge * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * remove checksum lowercasing tests * Update builder_test.go * Update builder_test.go * better docs * Update builder_test.go * even better docs * Update config.go * Update builder_test.go * Update step_create_vmx_test.go * make generate * better docs * fix imports * up tests * Update _ISOConfig-required.html.md * Update builder_test.go * don't use sha1.Sum("none") as a caching path * Update builder_test.go * better docs * Update iso_config_test.go remove ISOChecksumType/ISOChecksumURL references * Update step_download_test.go * add iso_checksum_url and iso_checksum_type fixers + tests * add concrete examples of checksum values * add examples of checksumming from local file * update go-getter dep * up deps * use new go-getter version * up ESX5Driver.VerifyChecksum: use go-getter's checksumming * ISOConfig.Prepare: get checksum there in case we need it as a string in ESX5Driver.VerifyChecksum * Update iso_config.go * get go-getter from v2 branch * Update driver_esx5.go add more comments * Update driver_esx5.go * show better error message when the checksum is invalid * Update builder_test.go put in a valid checksum to fix tests, checksum is md5("packer") * Update builder_test.go test invalid and valid checksum * more test updating * fix default md5 string to be a valid md5 * TestChecksumFileNameMixedCaseBug: use 'file:' prefix for file checksumming * Update iso_config_test.go * Update iso_config_test.go * Update builder_test.go * Update builder_test.go * Update builder_test.go * Update CHANGELOG.md * Update CHANGELOG.md * Update go.mod * Update go.mod * Update CHANGELOG.md	6 years ago
Ali Rizvi-Santiago	2a8bc45bc4	Added unit-tests for the netmap parsing components in the vmware builder.	6 years ago
Ali Rizvi-Santiago	7c1ad4adcf	Added unit-tests for the dhcpd configuration components in the vmware builder, and fixed a few discovered race conditions.	6 years ago
Sylvia Moss	1c30a71d09	Replace file shared state by statebag (#9238)	6 years ago
Megan Marsh	7e0cfd8b77	add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs	6 years ago
Wilken Rivera	e8f8ebf132	builder/vmware: Add some additional debug logging to the driver version check (#9064)	6 years ago
Adrien Delorme	840e67f775	HCL2: when we see a map generate an attribute spec instead of a block spec (#9035) ... * mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec this will alow to do tags = { key = "value" } instead of tags { key = "value" } This will also enable using variables directly for those tags * generate code * update tests	6 years ago
Megan Marsh	a48c0ecf49	update docs for headless to help users know they may need to launch the gui	6 years ago
Jeff Escalante	2999934326	fix generation script, bugfixes in source comments, update website paths in primary codebase	6 years ago
Jeff Escalante	9165be87da	packer.io prefix removal, html extension remove for in-code errors	6 years ago
Jeff Escalante	4afd107eeb	patch source files for extensions changes	6 years ago
Sylvia Moss	b17b211aa9	Add cleanup_remote_cache config option to vmware-iso (#8917)	6 years ago
Adrien Delorme	88297c796d	Merge branch 'master' into hcl2_singular_blocks	6 years ago
Adrien Delorme	94a1f0bcb6	go fmt	6 years ago
Megan Marsh	6008f911fd	Merge pull request #8847 from takaishi/support-keyboard-interactive ... communicator/ssh: support keyboard-interactive auth to connect bastion	6 years ago
r_takaishi	f50ff1d270	make generate	6 years ago
Paul Cichonski (pcichons)	c3d793255e	Do not test if NIC is reachable when ssh bastion is required ... Relates to https://github.com/hashicorp/packer/issues/8866	6 years ago
Wilken Rivera	e1a46ec293	Fix gosimple S1025 linting errors (#8838) ... Remove unneeded use of fmt.Sprintf for variables that are already strings.	6 years ago
Megan Marsh	dde74232f2	Clearly document all template-engine-enabled options (#8770)	6 years ago
Jason A. Beranek	9cbb49bacb	builder/vmware/iso: Expand `guest_os_type` docs (#8760)	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
Sylvia Moss	dc31bad539	Sharing info with post-processors via artifact (#8632)	6 years ago
Moss	61bee60ecf	Add StepHttpIpDiscover tests	6 years ago
Moss	df38d11270	Fix compilation error	6 years ago
Moss	0566f1f999	Extract http ip discover to a new step	6 years ago
Megan Marsh	8c8de27509	add note about error abort to vmware warning	6 years ago
Sylvia Moss	d6a351b173	Rename communicator config variables and remove deprecated code (#8584)	6 years ago
Megan Marsh	be3c1ef106	bump the timeout to a very high level to protect against laggy CI machines	6 years ago
Adrien Delorme	f1e6f8eac1	removed unused config puts	6 years ago
Adrien Delorme	a67948f155	fix config pointers	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	84063d2132	implement ID and Type values in the provisioner template info sharing	6 years ago
Stephen Tawn	c66219084e	Fix error message when ovftool is missing	7 years ago
Lars Lehtonen	5f02150e05	builder/vmware/common: defer close after testing for errors	7 years ago
Lars Lehtonen	9924d16fc3	builder/vmware/common: remove unused testHWConfig()	7 years ago
Lars Lehtonen	6eefe55e23	builder/vmware/iso: remove unused testState()	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Adrien Delorme	21a0cbffba	fmt	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Adrien Delorme	766e5c77ef	builder.vmware.vmx: remove duplicate RemoteType field.	7 years ago
Adrien Delorme	00e3f97f5b	builder.vmware.iso: remove duplicate Format field	7 years ago
Lars Lehtonen	2b795053b4	builder/vmware: fix dropped test errors	7 years ago
Megan Marsh	c24693372d	Merge pull request #8132 from scienty/support_floppy_vmx_esxi ... Support floppy_files for vmx on esxi	7 years ago
Adrien Delorme	3fe9d52e3f	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Prakash Sidaraddi	67be007f45	Support floppy_files for vmx on esxi	7 years ago
allinwait	171c2a9a07	add the floppy label option	7 years ago
Adrien Delorme	ba9ffcbf73	re-indent HWConfig struct comments	7 years ago
Adrien Delorme	b3cdf2ac8f	remove docs typo	7 years ago