Commit Graph

612 Commits (fdca7175fc889d60e41a98fbb104bfcd52017975)

Author SHA1 Message Date
Adrien Delorme 4dc12701d3 step_download: display clearer error messages, also when the checksum is not set
7 years ago
Megan Marsh 78cf1405ab
Merge pull request #7480 from BobSilent/fix-hyperv-multiple-hostadapter-same-switch
7 years ago
Adrien Delorme 9ac8d8aed8 step download: ovf files usually point to a file in the same directory, using them in place is the only way
7 years ago
Adrien Delorme 63f5bbbc73 use our own copy of iochan.LineReader
7 years ago
Adrien Delorme d72040f4fa move retry code into the common/retry pkg and make retry context aware
7 years ago
BobSilent 5b289f67fe Update hyperv.go
7 years ago
Adrien Delorme f555e7a9f2 allow a provisioner to timeout
7 years ago
Adrien Delorme a81abd297b Merge remote-tracking branch 'origin/master' into context_provisioner
7 years ago
Megan Marsh 3e72e65a6c
Merge pull request #7456 from hashicorp/do_5770
7 years ago
Megan Marsh 217a93fc30 fix build_test.go on windows. This code needs to not be run in parallel, or else there can be race conditions with the post-processors all trying to access the same file at once. Additionally, I changed the test template itself so that it is valid code on either bash or cmd. Finally, I found and fixed a small bug in naming the file extensions in shell local inline scripts.
7 years ago
Adrien Delorme c4f3dccc14 rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts
7 years ago
Adrien Delorme 82c4b76639 [Builder|Build|PostProcessor|Provisioner|Hook]Server: context cancel using a RPC cancel method
7 years ago
Adrien Delorme 14048b1e11 Revert "WIP: go towards context cancelled rpc pkg"
7 years ago
Adrien Delorme 9e3a179c0d WIP: go towards context cancelled rpc pkg
7 years ago
Adrien Delorme 829851fc8a change hooks to be passed a context for cancellation
7 years ago
Adrien Delorme 9836dad0c9 introduce the clean_resource_name to clean image names and deprecate the old ones
7 years ago
Adrien Delorme 91cc7e1091 net.ListenRangeConfig.Listen: don't swap ports if max < min
7 years ago
Adrien Delorme a4a83be2b9 net.ListenRangeConfig.Listen: allow to have a port rage of zero
7 years ago
Adrien Delorme cd39aa9988 net.ListenRangeConfig.Listen: log tried ports a bit earlier in the process
7 years ago
Adrien Delorme 5a6dffde9a use port as ints
7 years ago
Adrien Delorme c214f6735b make everything a uint
7 years ago
Adrien Delorme 51294287fa StepHTTPServer: display error if we could not connect
7 years ago
Adrien Delorme 6df4128517 StepHTTPServer: use the common/net pkg
7 years ago
Adrien Delorme 1685a1c4c0 add common/net package that can listen on a random port in a range
7 years ago
Adrien Delorme 6ab28ba89c
Update common/shell/shell.go
7 years ago
Adrien Delorme b4ec6e2ed2 Create exit_code_test.go
7 years ago
Adrien Delorme eedf5e4387 Update shell.go
7 years ago
Adrien Delorme f0a23bb81d common shell provisioner: define a ValidExitCode func
7 years ago
Adrien Delorme 30a65c858a regroup shell provisioner params into a common struct
7 years ago
Adrien Delorme 9f82b75e57 Use the hashicorp/go-getter to download files
7 years ago
Vadym Haidamaka f736e2aba5 Print VerifyChecksum log for the download as ui.Message output
7 years ago
Megan Marsh 3dc1dafe58
Merge pull request #7287 from stephen-fox/ephemeral-ssh-key-pair-issue-7225
7 years ago
Stephen Fox 56c17941fe Added comment to authorized_keys 'sed' calls per review.
7 years ago
Megan Marsh 2a9f49a5c6 make sure we don't try to load an iso into memory because of a user mistake
7 years ago
xinau 36c1e8d838 moved adapter to common package
7 years ago
Stephen Fox 354fcc5cc6 Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'.
7 years ago
Stephen Fox e40aa515f2 Added TODO about public key removal logic.
7 years ago
Megan Marsh 2d3f84abf0
Merge pull request #7271 from hashicorp/make_generate
7 years ago
Stephen Fox 4c2851013e Fixed 'sed' regex to remove public key by magic string.
7 years ago
Adrien Delorme 8621949e01 make generate
7 years ago
Megan Marsh 482ba644a8 quote variables in powershell script to account for spaces
7 years ago
Megan Marsh 3602180b45 re-add missing import
7 years ago
Megan Marsh c63b54a1e7 move http with proxy call into a helper function
7 years ago
Tom Parker-Shemilt d72fb9bcb3 If checksums for a download don't match, display the checksum that was found
7 years ago
Megan Marsh 97a791389a deduplicate step_output_dir and move to common folder
7 years ago
Adrien Delorme 9f2a3bdfbc
Merge pull request #7181 from hashicorp/python_shell_docs
7 years ago
Megan Marsh a2c3de9396 remove outdated logline
7 years ago
Adrien Delorme 9f7b4ffc17
Merge branch 'master' into pr/6950
7 years ago
Adrien Delorme 19cbb9cb24
Merge pull request #7136 from hashicorp/fix_5984
7 years ago
Megan Marsh 93053e0488 update comments
7 years ago
Megan Marsh 9557f3eea7 use script options struct rather than passing all the variables around an extra time
7 years ago
Megan Marsh a1b3b63cb9 use golang templating logic
7 years ago
Ladar Levison e6de727c25
Fix the Hyper-V gen 1 guest boot order.
7 years ago
Megan Marsh f26051a7da code comments yo
7 years ago
Megan Marsh 24d2cc34e5 tests
7 years ago
Megan Marsh 427a35fc7e tests
7 years ago
Megan Marsh d4de89e057 move powershell templating into separate script so we can test it
7 years ago
Megan Marsh 006682a09c add version option and also refactor powershell script to use golang templates for ease of testing and variable passing.
7 years ago
Ladar Levison 348c267054 Updated support for legacy network adapters on Hyper-V.
7 years ago
Megan Marsh b95123f457 add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work.
7 years ago
Adrien Delorme b7222d1f56 Add tmp package that offers Dir & File funcs
7 years ago
Anish Bhatt d5f88b154f
Better fix for #7095
7 years ago
Anish Bhatt 916375183b
Don't run StepCleanupTempKeys when communicator is set to none
7 years ago
Megan Marsh e69391f28b save users some bash scripting by exposing IP and port separately as well as together
7 years ago
pgrmega 2d1e3efadb
Fix a problem when calling Hyper-V\Compare-VM PowerShell cmdlet (#6726)
8 years ago
Megan Marsh f9ceaee4f1 fix variable casing convention
8 years ago
Joel Vasallo 5d17b3de84 fix: config validator output
8 years ago
Joel Vasallo 23ad90f2c4 fix: condensed and simplified os check logic and added validate output
8 years ago
Joel Vasallo d408c9e69c fix: moved os check to entry of func
8 years ago
Joel Vasallo 0912adea34 fix: converted onlyon param to only_on and added validation step
8 years ago
Joel Vasallo 25c0b98363 feat: ability to specify runtime OSs where shell-local should run
8 years ago
Adrien Delorme 02ba6ccfab make common/iso_config_test.go invisible to windows
8 years ago
Megan Marsh 847a3b0061 provide useful powershell error
8 years ago
Megan Marsh 3f8407d95f Revert "Merge pull request #6700 from hashicorp/multi_progressbar"
8 years ago
Megan Marsh 5470c08345
Merge pull request #6700 from hashicorp/multi_progressbar
8 years ago
Megan Marsh 38cc525ec7 new option allowing user to clean up the ephemeral ssh key from the authorized_keys file
8 years ago
Adrien Delorme dfeca9f0df split progressbars per object
8 years ago
Megan Marsh a0edaf6c46 Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
8 years ago
Adrien Delorme 32cacad273 remove comment that is not true anymore
8 years ago
Adrien Delorme bb59a70e8f progressbar: use int64 instead of uint64
8 years ago
Adrien Delorme f9c58e2b1f download: defer progress bar Finish
8 years ago
Adrien Delorme 3842f85eb4 download: remove close calls that are already defered
8 years ago
Adrien Delorme 23762a1810 fix tests for common/download_test.go
8 years ago
Adrien Delorme 7f50228080 remove old/unused progress code
8 years ago
Adrien Delorme 059e14fe42 put back usefull debug
8 years ago
Adrien Delorme a11f985e3c revert unecessary check
8 years ago
Adrien Delorme a9d302def8 removed debug logs
8 years ago
Adrien Delorme 541c68aed5 add StackableProgressBar struct that will refresh/show dl status for multiple files
8 years ago
Adrien Delorme fd7cb47adc use proxy reader for download progress & stop storing total/current in downloaders
8 years ago
Adrien Delorme ddd96c513b first draft at self refreshing loading bar centralized/controlled by Ui
8 years ago
Adrien Delorme 5a8af5500b random: optimize allocation & simplify loop
8 years ago
Adrien Delorme 4682b3a9d2 refactor possible random strings into common/random
8 years ago
Adrien Delorme 170b2f3383 builder/azure/common.RandomString-> common/random.String
8 years ago
Adrien Delorme 9cefd69f0d
change progress bar display rate to 5s to reduce 'spamminess' (#6640)
8 years ago
Megan Marsh 8309f36176
Merge pull request #6626 from hashicorp/fix_6620
8 years ago
Matthew Hooker 7519037562
Merge pull request #6629 from hashicorp/travisbuild
8 years ago
Matthew Hooker 8a604114ef
remove unused code
8 years ago
Matthew Hooker 3f1a9766f4
formatting verb fixes for go 1.11
8 years ago
Megan Marsh c5b346b07b
Merge pull request #6393 from DanHam/fix-hyperv-export
8 years ago
Megan Marsh b35acbd879 use statebag instead of SetSharedState for winRM password
8 years ago
Megan Marsh f5355a0693 make reasonable tempfile default on windows
8 years ago
Megan Marsh 340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
8 years ago
Megan Marsh 1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
8 years ago
Megan Marsh 31d4f8af45 use a time.Duration instead of a hardcoded ms
8 years ago
Megan Marsh 918db58604 added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used
8 years ago
Adrien Delorme 41f6e0334d refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
8 years ago
Ali Rizvi-Santiago cf9bbe3ecf Incorporated the hack demonstrated by @SwampDragons in order to deal with packer.rpc.Ui not exporting any information about what it's doing to anybody.
8 years ago
Ali Rizvi-Santiago 5726927cba Moved the progress bar out of packer.Ui and unlinked it out of all the packer.Ui implementations. Split up the terminal-related functions into a separate terminal.go and calculate the progress bar width by traversing through packer.Ui to avoid the issue with github.com/ugorji/go/codec serializing private members (or unsafe pointers) of structs. Shuffled some arguments around in getConsoleScreenBufferInfo in common/terminal_windows.go so that the interface forces the user to correctly declare a _CONSOLE_SCREEN_BUFFER_INFO type.
8 years ago
Ali Rizvi-Santiago 0f10032b3d Moved the progress bar from common to the packer.UI interface and refactored it so that the terminal width is calculated based on each interface which returns a custom progressbar specific to its ui.
8 years ago
Ali Rizvi-Santiago fd2fef8738 Added support for the progress bar to automatically determine its width using the minimum length from a packer.UI and the terminal dimensions via kernel32.GetConsoleScreenBufferInfo or an ioctl (TIOCGWINSZ) to "/dev/tty".
8 years ago
Ali Rizvi-Santiago 16ecb3ad9a Reverted removal of progress-bar that was done by commit 5d97b105a8 and added some missing arguments that were missed during the rebase. Modified the default progress bar's width to 80 as a result of the conversation on PR #5851.
8 years ago
Megan Marsh ff6a039d5b replace scrubconfig with packer.LogSecretFilter.Set
8 years ago
Adrien Delorme a5587e30ec log wether the file was transfered or is just being inplace referenced
8 years ago
Adrien Delorme 6b3844a64f
Revert "allow to use ISO images in-place v.s. copying them"
8 years ago
Adrien Delorme c744e8b2bb make download messages less redudant and more simple
8 years ago
Adrien Delorme d7d4aed51c be even more precise
8 years ago
Adrien Delorme 2b3ea29970 show more precise error download/copy/referencing messages
8 years ago
Adrien Delorme fae3db4e58 test inplace linking
8 years ago
Adrien Delorme 17f2949e36 remove stuttering; ISOConfig.InplaceISO -> Inplace
8 years ago
Adrien Delorme 863222b1e2 Also use the terminology Inplace in DownloadConfig for clarity/consistency
8 years ago
Adrien Delorme 82e480a285 allow to use ISO images inplace v.s. copying them
8 years ago
Ali Rizvi-Santiago 71e43d0b7f Updated common/download.go to handle when a connection error happens (response is nil), and reformatted the error that's returned when an HTTP error occurs.
8 years ago
Megan Marsh 5ef8b55559 need log import
8 years ago
Megan Marsh a2f5fbadf6 don't fail if you can't find abs or relative path.
8 years ago
DanHam da21c25791
Convert incorrect 'vmxc' -> 'vmcx' in codebase, docs and template opts
8 years ago
DanHam 674bad0ab4
Break very long lines for readability
8 years ago
DanHam d2390f464d
Actually implement the function for the driver
8 years ago
DanHam c2437ba592
Remove the option to place the VHD files in a separate directory
8 years ago
DanHam c6b9d9ce90
Add checks/error reporting to compaction process
8 years ago
DanHam 534fc4a473
Ensure the export directory structure matches that of previous versions
8 years ago
DanHam dc46848f89
Remove now redundant function to copy exported VM files
8 years ago
DanHam 3fc2defb6d
Refactor the export step for Hyper-V ISO and VMCX builders
8 years ago
Mathieu Tarral edcc0b3853 shell-local: expose PACKER_HTTP_ADDR env var
8 years ago
Megan Marsh 0df33cd032 fix relative pathing versus iso checksum dir to work even if user has provided a relative path for the iso_url which is relative to the directory where Packer is run.
8 years ago
Megan Marsh d0f0da6626 allow absolute paths to isos in checksum files
8 years ago
M. Marsh e5a63a674e
Merge pull request #6422 from DanHam/fix-gh-vmsecureboot
8 years ago
M. Marsh baaca808e8
Merge pull request #6412 from hashicorp/fix_config_validation_bug_windows_shell_local
8 years ago
DanHam 297f6b85ec
Use Get-Command over Get-Help to check for SecureBootTemplate parameter
8 years ago
Simon Hulme 475e79a251 Fixed SecureBootTemplate not being passed through to PS cmdlet
8 years ago
Megan Marsh 4a7953f93a found a config validation bug where packer crashes instead of throwing a validation error if a windows-style path is provided to a provisioner on linux
8 years ago
Jordan Borean efa9021974
Check if hyper-v addresses is an array before slicing it
8 years ago
Giovanni Tirloni 28095cf027 Do not return error on initial HEAD request
8 years ago
Giovanni Tirloni b7ea0b44fc HTTPDownloader - Fix invalid error handling
8 years ago
M. Marsh a012f70e71
Merge pull request #6251 from hashicorp/do_winrm_shell_local
8 years ago
Megan Marsh 3afca6905b remove duplicate assignmnet
8 years ago
Matthew Hooker 6a769f08d8
regenerate boot command code
8 years ago
Matthew Hooker 788418cff2
Add unit test to show that we handle tars safely
8 years ago
Megan Marsh 846f94c964 implement template variable for accessing WinRM password in either environemnt variables or directly in execute_command or inline commands.
8 years ago
M. Marsh 62e1323577
Merge pull request #5956 from hashicorp/dedupe_shell_local
8 years ago
Megan Marsh d1e31c0f23 use if/else to clarify code
8 years ago
Megan Marsh 969201a2d4 handle minor shell-local PR suggestions and corrections
8 years ago
Megan Marsh 1fdf763d0f fancier logging
8 years ago
M. Marsh edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
8 years ago
WaaZaa666 b747877222
Fixing #6267, multiple hyper-v disks
8 years ago
Unknown 29c4b4436d Changes requested in PR #6243
8 years ago
Unknown fc734b6bd9 Using vmconnect to display gui for hyper-v
8 years ago
M. Marsh 5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
8 years ago
Stefan Henseler 6f00596053 Adds config option to specify hyper-v secure boot template
8 years ago
DanHam d9d8b93c14
Remove tmp file created by common/ test. Avoid possible race condition.
8 years ago
M. Marsh 7c46e3d89c
Merge pull request #6207 from gtirloni/issue-6203
8 years ago
Matthew Hooker 5e6e12cacd
Use fmt to convert whatever's in error to a string.
8 years ago
Matthew Hooker 0a1842140b
Display build error when on-error=ask|abort
8 years ago
Megan Marsh 1bea658e16 fix command and inline calls on windows
8 years ago
Megan Marsh fabd1a6517 windows cmd env vars
8 years ago
Megan Marsh 9651432378 preserver BC for people using 'command' option
8 years ago
Megan Marsh dd183f22d9 update docs and add warnings around WSL limitations
8 years ago
Megan Marsh 51bcc7aa13 add new feature for telling shell-local whether to use linux pathing on windows; update docs with some examples.
8 years ago
Megan Marsh e983a94a88 fix default windows bash call for shell-local provisioner and move chmod command from the execute_command array into the portion of code where we actually generate inline scripts, sparing users the need to think about this modification which Packer should really handle on its own
8 years ago
Megan Marsh 5da4377f21 first pass at docs update
8 years ago
Megan Marsh 854d6fb141 add tests making sure post-processor has backwards compatability
8 years ago
Megan Marsh f799003b66 tighten up shell-local config validation
8 years ago
Megan Marsh 479d36734d consolidate shell-local defaulting of InlineShebang and ExecuteCommand to the config validation
8 years ago
Megan Marsh d304234725 fix tests
8 years ago
Megan Marsh 67739270bb pull temp file writing into its own function for easier testing
8 years ago
Megan Marsh 6dc4b1cbdc move all of the run commands for shell-local provisioner and postprocessor into common library too
8 years ago
Megan Marsh c7c66bedcb set inline to an empty array, rather than nil
8 years ago
Megan Marsh 926327beba deduplicate all validation and interpolation of the shell-local config, sharing options between shell-local provisioner and post-processor. Maintain backwards compatibility with shell-local provisioner.
8 years ago
Megan Marsh 616b41e58f deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module
8 years ago
M. Marsh bf6dc932d5
Merge pull request #6219 from jborean93/hyper-v-ip
8 years ago
DanHam 7e478f650e
Remove tmp files created by common/ tests
8 years ago
Jordan Borean 14e41fad7e
Hyper-V: Add support retrieving IP for Server 2008
8 years ago
Giovanni Tirloni 413d13c411
Handle HTTP download errors
8 years ago
Adam Robinson 3aebd5f462 Add use_fixed_vhd_format Hyper-V ISO option
8 years ago
Matthew Hooker a3bf2c786a
Use expression sequence generator in tests.
8 years ago
M. Marsh 69c7e2d51d
Merge pull request #6144 from hashicorp/winrm_password_fix
8 years ago
Matthew Hooker e4bd30e53d
fix bug with empty boot command.
8 years ago
Matthew Hooker b5a97e468f
fix test
8 years ago
Matthew Hooker 7e9af8247a
fix 2 byte scancodes for pc-xt VMs.
8 years ago
Matthew Hooker 675eae1e92
flush scancodes when we wait
8 years ago
Matthew Hooker 374d8f089f
better log message
8 years ago
Matthew Hooker 31d04f1945
remove outdated comment
8 years ago
Matthew Hooker df6224d04e
fix vnc config
8 years ago
Matthew Hooker aa69bdf74e
Perform validation of boot command.
8 years ago
Matthew Hooker 7d43324359
add menu key.
8 years ago
Matthew Hooker e9e27941cc
sort keycode lists
8 years ago
Matthew Hooker c6299972b9
s/boot_command/bootcommand/
8 years ago
Matthew Hooker 7990966a09
fix boot command config struct name
8 years ago
Matthew Hooker 408eba88ad
flatten boot command config and implement for vmware
8 years ago
Matthew Hooker 9a8acbbcab
negative wait WIP
8 years ago
Matthew Hooker add7e8acb9
Stop sending boot commands when context canceled.
8 years ago