106 Commits (f4eda950c2e1ec5a9f6c4e3a3d4e78bd7499583f)

Author	SHA1	Message	Date
hashicorp-copywrite[bot]	b7df3ca36f	[COMPLIANCE] Add Copyright and License Headers (#12254) ... Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>	3 years ago
Lucas Bajolet	ec1d2e68f5	hcp: generate fingerprints on each new build ... Fingerprints are how we link a packer build to an iteration on HCP. These are computed automatically from the Git SHA in the current state, and are unique to the bucket/iteration. The main problem with this approach is that while sound in theory, it quickly falls apart when users want to run the same build configuration twice, but expect a new image to be created. With the current model, this fails, as the iteration with the current SHA already exists. While this is solvable through environment variables, or by committing a change to the repository, we think this is not clear enough, and causes an extra step to what should otherwise be a simple process. Therefore, to lower the barrier of entry into HCP, we change this behaviour with this commit. Now, fingerprints are randomly generated ULIDs instead of a git SHA, and a new one is always generated, unless one is already specified in the environment. This makes continuation of an existing iteration a conscious choice rather than something automatic, and virtually eliminates conflicts such as the ones described above.	3 years ago
Lucas Bajolet	ca197afe9b	hcp: remove superfluous return value on GetBuilds ... This commit irons out one of the pain points of the HCP rework by introducing a HCPPublisher interface, implemented both by the JSON Core, and the HCL2 PackerConfig, which keeps a map of the build names used by Packer to the build names pushed on HCP. This in turn lets us go back to the old implementation of the GetBuilds function, which returns a list of (filtered) builds, and eventually an error if something went wrong while processing.	3 years ago
Wilken Rivera	57cbe4e203	core: Update validation options for undeclared variables (#12104) ... * Update validation options for undeclared variables In an effort to help users move from JSON to HCL2 templates the support for variable definitions files are being updated to ignore undeclared variable warnings on build execution. For legacy JSON templates builds no warnings are displayed when var-files contain undeclared variables. Since preferred mode HCL2 templates is to be explicit with variable declarations - they must be declared to be used - validation for undeclared variables still warns when running `packer validate`. A new flag has been added to the validate command that can be used to disable undeclared variable warnings. * Update validation test for unused variables Example Run ``` ~> go run . validate -no-warn-undeclared-var -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl The configuration is valid. ~> go run . validate -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl Warning: Undefined variable The variable "unused" was set but was not declared as an input variable. To declare variable "unused" place this block in one of your .pkr.hcl files, such as variables.pkr.hcl variable "unused" { type = string default = null } The configuration is valid. ~> go run . build -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl file.chocolate: output will be in this color. Build 'file.chocolate' finished after 744 microseconds. ==> Wait completed after 798 microseconds ==> Builds finished. The artifacts of successful builds are: --> file.chocolate: Stored file: chocolate.txt ``` * Rename Strict field to WarnOnUndeclaredVar The field name Strict is a bit vague since it is only used for checking against undeclared variables within a var-file definition. To mitigate against potential overloading of this field it is being renamed to be more explicit on its usage. * command/build: Add warn-on-undeclared-var flag Now that the default behaviour is to not display warnings for undeclared variables an optional flag has been added to toggle the old behaviour. ``` ~> go run . build -warn-on-undeclared-var -var-file command/test-fixtures/validate/var-file-tests/undeclared.pkrvars.hcl command/test-fixtures/validate/var-file-tests/basic.pkr.hcl Warning: Undefined variable The variable "unused" was set but was not declared as an input variable. To declare variable "unused" place this block in one of your .pkr.hcl files, such as variables.pkr.hcl variable "unused" { type = string default = null } file.chocolate: output will be in this color. Build 'file.chocolate' finished after 762 microseconds. ==> Wait completed after 799 microseconds ==> Builds finished. The artifacts of successful builds are: --> file.chocolate: Stored file: chocolate.txt ```	3 years ago
Wilken Rivera	606e6c48f1	internal: reorganise registry/HCP code ... This commit reorganises the code for both the registry/API and the Orchestrator/Registry. The main difference with the previous version is how stuff is exposed. Now we only expose a Registry interface to the outside (previously named Orchestrator), which has several implementations: null is the default, and is returned if HCP is not enabled. The other implementations being HCL/JSON, both private to the hcp sub-package. The api (previously `registry') is the set of functionality that abstracts and calls the HCP API. It was meant to be merged with the `hcp' package, but because of a dependency loop with the datasources, both are separated for now.	3 years ago
Lucas Bajolet	1cee460d0d	hcp: extract all HCP-related code to hcp package ... As part of the work to displace everything related to HCP from scattered places around the Packer code, we move it all to an hcp package. This in turn reduces the amount of code that the commands have to integrate, and leaves the HCP details to its own enclave.	3 years ago
Lucas Bajolet	dad07c6097	hcp: keep map of build names for hcp tracking ... To be able to track HCP builds during a Packer build, we need to propagate the name used for registering the build to HCP. This works out-of-the-box for JSON templates, as the build's name is always the builder's, so there's no confusion on that. For HCP templates however, there's a possibility for a template to define a name for the build, which is returned by a CoreBuild's Name() function, in addition to the source's Type/Name. The builds are registered to HCP with the source.String() function however, which does not contain the build's name. This prevents any build containing a name to work, as their name/source.String does not match. The name we registered the build with is stored in a CoreBuild as the Type attribute, but cannot be safely accessed, as builds are types within the command as packersdk.Build, which only exposes Name() for this purpose. In order to circumvent this problem, and as a way to present a prototype of solution that will likely have to be discussed before we merge it, this commit hotfixes the issue.	3 years ago
Lucas Bajolet	f3e4c2c3bb	tmp: move HCP logic to unwrap builds/post	3 years ago
Lucas Bajolet	61c810e720	command: rework HCP-related error messages ... The HCP error messages were sometimes a bit terse in terms of the information it bubbles up to the user. This made them useful for people who already knew what to look for, but newcomers would almost certainly be lost because of the lack of information in those. To improve on this situation, we reword most of those error messages in this commit.	3 years ago
Lucas Bajolet	73af77aeed	command: enhance error message on no build to run	3 years ago
Lucas Bajolet	e94b8766cb	build: exit immediately if no builds and diags ... When a template with some builds to run ends its GetBuilds with an error, and no builds produced, we can exit immediately without printing more errors.	3 years ago
Lucas Bajolet	a298617ecb	command/build: warn and exit when nothing to build ... When a `packer build' is run on a config that does not define anything to be built, the process would run normally, and only state that no artifacts were produced after builds were run successfully. This is misleading as we reach the end of the command without having a proper warning that nothing was even attempted to be built. This commit adds a warning when that happens, and leaves immediately after.	3 years ago
Lucas Bajolet	7cd095062a	parser: extract HCP logic out of the HCL parser ... Before this commit, some HCP-related logic was embedded in the parser, making all of it common to all commands. This complexifies the logic as some parts rely on the template being in a HCP-valid environment, and the datasources need to be evaluated in order for some operations to be executed. To simplify this and avoid those pitfalls, we move this logic to its own set of functions that will be performed after the parsing is done, on any valid HCL2 or JSON template.	4 years ago
Lucas Bajolet	4be7e38474	command: move GetConfig methods to meta ... Since the GetConfig methods are common to all the commands of Packer that rely on a config to work, we move them from build.go to meta.go in order to make the intent clearer.	4 years ago
Megan Marsh	b763b79d9f	implement contextual variable packer.iteration_id	4 years ago
Wilken Rivera	a534c743cf	HCP Packer registry enabled Packer client (#11154) ... * Add working registry pkg * Add custom error for handling the loading of PAR environment variables * Working Publish to Build, with proper error handling for bucket names * Update hcp-sdk-go to use branch instead of mod replace directive * Update Packer build status configuration * Add support for HCP_PACKER_BUILD_FINGERPRINT env * Add support for publishing one or more PARtifacts from a single build * add git shas to this branch * Add ability to set provider name if available * Add working RegistryBuilder type * Add RegistryPostProcessor as wrapper post-processor * When in PAR mode a empty RegistryPostProcessor is added to the end of the post-processor list to publish all final image data. * Add support for updating a build from PAR that is not in a DONE state * Fix a small issue with creation the initial builds for an empty iteration. * Add PAR URL to post-processor display * Implement hcp_packer_registry block (#11168) * Update vendored Amazon plugin to v1.0.1-dev * Fix panic when running a Packer registry build in a clean directory * Remove the publishing of post-processor metadata from the registry post-processor. * Remove metadata add from registry_builder * Update registry builder to skip a build that was found to be DONE Co-authored-by: Megan Marsh <megan@hashicorp.com> Co-authored-by: Sylvia Moss <moss@hashicorp.com>	5 years ago
Megan Marsh	00e503388e	change template parsing error to include warning about file extensions (#10652)	5 years ago
Adrien Delorme	ed091163be	HCL2 Parse packer.required_plugins block + packer init (#10304) ... This adds the new `required_plugins` block to be nested under the packer block. Example: ```hcl packer { required_plugins { aws = { version = ">= 2.7.0" source = "azr/aws" } azure = ">= 2.7.0" } } ``` For example on darwin_amd64 Packer will install those under : * "${PACKER_HOME_DIR}/plugin/github.com/azr/amazon/packer-plugin-amazon_2.7.0_x5.0_darwin_amd64" * "${PACKER_HOME_DIR}/plugin/github.com/hashicorp/azure/packer-plugin-azure_2.7.0_x5.0_darwin_amd64_x5" + docs + tests	5 years ago
Sylvia Moss	291121dd55	(2) Implement datasources (#10440)	5 years ago
Megan Marsh	88b7b0e14a	remove sdk	5 years ago
Megan Marsh	39ab646236	move plugin and rpc code into sdk; other minor tweaks (#10359)	5 years ago
Megan Marsh	14bdb9516c	move Artifact and artifact mock to the sdk	5 years ago
Megan Marsh	001886670d	move Ui definition into the packer plugin sdk.	5 years ago
Megan Marsh	6402362018	create packer-plugin-sdk directory and begin moving the relevant folders into it.	5 years ago
Megan Marsh	bc85854a53	refactor packer version out of hcltemplate code.	5 years ago
Megan Marsh	00cc425b84	docs tweaks	5 years ago
James Cradock	153d4111fa	Fix typo in build argument description (#10066)	5 years ago
Chris Gilmer	04f952a2f4	Pretty print build durations	6 years ago
Adrien Delorme	44616d3bff	refactor initialization out from packer configs + tests (#9627) ... The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost. This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too. fix #9478	6 years ago
Megan Marsh	42e98f15ae	make sure the no-op progress bar gets used for machine readable uis	6 years ago
Moss	4f26534072	add on-error flag option to run cleanup provisioner	6 years ago
Adrien Delorme	bac9c74447	packer console for HCL2 (#9359)	6 years ago
Megan Marsh	3dc4ba2d68	Json vs HCL2 parity refactor (#9301) ... * refactor so that json and hcl2 templates are both prepared in the same place in the build call, to make code easier to reason about. Remove overly verbose error output which isn't useful in vast majority of cases * fix tests * check err msg * hcl2template.PackerConfig.GetBuilds: raise a diagnostic in case the packer core build perpare call errors Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	6 years ago
Megan Marsh	ee5635722b	enable force, debug, and on-error for hcl2 builds	6 years ago
Megan Marsh	533fbc1381	Merge pull request #9139 from hashicorp/hcl2_commands_refactor ... Hcl2 commands refactor	6 years ago
Adrien Delorme	52b2151b21	go generate ./packer	6 years ago
Adrien Delorme	22a36ef97a	Move vars from Meta to cla args; this forces us to use it in GetConfigFromJSON which in turn forces us into updating console and validate	6 years ago
Adrien Delorme	534e98c4ef	pass Meta command line arguments around	6 years ago
Adrien Delorme	b35ec44d06	Update build.go	6 years ago
Adrien Delorme	efcc6af06c	fix tests	6 years ago
Adrien Delorme	42a05e1e80	more refactoring	6 years ago
Adrien Delorme	2f63e4e79d	refactor term interrupts & have RunContext take a conf struct now	6 years ago
nqb	be08eddd8d	remove useless comment ... -var-file allow an HCL file	6 years ago
Adrien Delorme	4047113746	Update build.go	6 years ago
Adrien Delorme	2c556ed8c0	remove clarified comment	6 years ago
Adrien Delorme	c71a792186	simplify/refactor core for build & validate	6 years ago
Adrien Delorme	7aaee62970	command/build: don't reset error code in case an error hapened	6 years ago
Adrien Delorme	5c2b8da63b	get builds from PackerConfig instead of parser ... to allow just reading the config and to not start anything. This will allow to later on run `validate --syntax-only`. Note that none of the builder/provisioner/post-processor config will be read but simply ignored. HCL2 still needs the body to be properly formatted and it should detect most syntax errors.	6 years ago
Tom Dyas	c0a6623ea2	teach HCL mode builds to honor -only and -except options (#8947)	6 years ago
Adrien Delorme	c8300b620a	allow to use hcl files as var files in HCL mode ... fix #8781	6 years ago