225 Commits (efc97dbda2fedd12cb8825db3cdaff2017159654)

Author	SHA1	Message	Date
Ali Rizvi-Santiago	efc97dbda2	Fixed TestFileExistsLocally tests in common/config_test.go so that they're actually being run. Added a non-existent-protocol:// test.	8 years ago
Ali Rizvi-Santiago	c366a1e160	Inverted the logic of FileExistsLocally as suggested by @SwampDragons as remote URLs are assumed to exist locally.	8 years ago
Ali Rizvi-Santiago	c98a074f0d	Renamed common/config.go's SupportedURL to SupportedProtocol as suggested by @SwampDragons.	8 years ago
Ali Rizvi-Santiago	97fc9c02a5	Grr...missed the case that actually mattered on linux.	8 years ago
Ali Rizvi-Santiago	f9572cb244	Fixed a bug on linux related to forgetting to check the platform for the forward-slash prefix.	8 years ago
Ali Rizvi-Santiago	41f4dc3f3d	umm...gofmt -w on common/config{,_test}.go from linux instead of windows(?)	8 years ago
Ali Rizvi-Santiago	7cd5d576d9	Updated common/config.go's FileExistsLocally implementation to use the LocalDownloader interface for determining the real file path.	8 years ago
Ali Rizvi-Santiago	8a102a42a0	gofmt -w on common/config{,_test}.go	8 years ago
Ali Rizvi-Santiago	15079a99dc	Fixed common/config_test.go tests for DownloadableURL to avoid writing to disk on the windows platform. Also added tests for relative paths/uris. ... common/config_test.go: Replaced instances of os.Mkdir and os.Create with tests that use the existing "common/test-fixtures" mechanism. Removed the runtime.GOOS test for the "FileExistsLocally" test, as the functionality should work regardless of the platform. Added some more comprehensive tests for the relative uri/pathing. Replaced the Windows Object Manager name test as the Object Manager's naming scheme is different from a UNC path. Modified the FilePaths tests to support the policy of windows absolute paths being prefixed with the `/` introduced with PR #5761.	8 years ago
Ali Rizvi-Santiago	95f60f6153	Modified common/config.go to accommodate some of the new DownloadableURL policies made by the PR #5761 merge. ... common/config.go: Added the ability for DownloadableURL to promote UNC paths to the SMB uri. Modified DownloadableURL to include the "./" prefix when a relative path is passed to it. Fix-up the DownloadableURL argument if on windows and incorrectly prefixed with "/".	8 years ago
Ali Rizvi-Santiago	50e9cd2ca7	Initial fixes of common/config.go after rebase before refactoring of test-cases so that they don't require root to run.	8 years ago
Ali Rizvi-Santiago	c17f827e1d	Split up DownloadableURL() into it's individual components: SupportedURL(), DownloadableURL(), and ValidatedURL(). Updated all instances of DownloadableURL() to point to ValidatedURL(). Reverted the tests that are based on un-supported protocols.	8 years ago
Ali Rizvi-Santiago	3cf448f6ec	Reverted previously removed additions of tests that check for ftp:// or nonexistent-protocol:// using DownloadableURL. DownloadableURL's responsibility is not to have inherent knowledge of protocols that are available, but to format an invalid url/path to a valid url/path.	8 years ago
Ali Rizvi-Santiago	4a1fb0d262	Grrr...gofmt -w common/*.go	8 years ago
Ali Rizvi-Santiago	5d97b105a8	Removed implementation of the ftp protocol and the usage of cheggaaa's progress-bar as suggested by @SwampDragons. Replaced some of the old smoke-tests that were based on the ftp-protocol non-existing with a "non-existent://" protocol that's guaranteed to not exist.	8 years ago
Ali Rizvi-Santiago	5a3e98b529	Updated the testcases in common/download_test.go to pass a non-nil progress-bar due to the removal of a pointer type in commit ed2e341b7d7f49a063dd5018701b4ae548b8ec14 from yesterday.	8 years ago
Ali Rizvi-Santiago	ab4490b967	Consolidated progress bar's appearance into the GetDefaultProgressBar() function. Updated dependency for cheggaaa's progress-bar from the gopkg.in location to the better maintained one on github.com.	8 years ago
Ali Rizvi-Santiago	8c6efe336c	Added second argument for custom-formatted progress-bar to NewDownloadClient in common/download_test.go. This second parameter was added as a result of commit f0bd9018f3e318caafb1fe7d46e04c470e07c092 which lets you customize the progress-bar format.	8 years ago
Ali Rizvi-Santiago	69e5eec1ce	Consolidated the progress-bar's format into common/step_download.go. Removed DownloadClient's PercentProgress callback since cheggaaa's progress-bar already does that.	8 years ago
Ali Rizvi-Santiago	d85883582f	Changed a critical error to a non-critical one when dealing with the strange .CopyFile flag in common/download.go.	8 years ago
Ali Rizvi-Santiago	c978e27f0f	grr. removed an assignment that was dead in common/download.go.	8 years ago
Ali Rizvi-Santiago	5a4ce2165c	Modified common/download_test.go to not test the smb:// uri on platforms other than windows. Added an immediate platform error to SMBDownloader.Download as opposed to letting .toPath return it (which would have left the structure partially initialized).	8 years ago
Ali Rizvi-Santiago	4783b6508e	Fix common/download_test.go to avoid formatting the volume name to a hidden windows share when not on windows.	8 years ago
Ali Rizvi-Santiago	b1ff14714b	go fmt	8 years ago
Ali Rizvi-Santiago	11ff4439a6	Moved the setting of HTTPDownloader's current progress to after the object actually gets instantiated. ;)	8 years ago
Ali Rizvi-Santiago	0fa6c3782e	Added a progressbar using gopkg.in/cheggaaa/pb.v1 as per #3578 for all the DownloadClients in common/download.go.	8 years ago
Ali Rizvi-Santiago	2f1104625d	Fixed some of the unit-tests in common/ due to the changes made in {config,download}.go ... config.go: Fixed some issues related to the url scheme not being lowercased which broke some of the tests. config_test.go: Removed the UNC share test for \\host\share\file since SMB support has been moved to a different uri scheme. download_test.go: Explicitly set the CopyFile configuration option for all the unit-tests that test file copying capability. Removed the UNC share testcase since it's under a different uri scheme now. Modified the file:// UNC share testcase to explicitly test the smb:// uri. Changed the incorrect t.Errorf calls to t.Logf so that the tests can pass.	8 years ago
Ali Rizvi-Santiago	6170e24ecb	Refactored the code a bit to move the CopyFile hack out of DownloadClient and instead into each protocol. ... config.go: Removed all of the windows-specific net/url hackery since it's now handled mostly by download.go Removed the replacement of '\' with '/' since url.Parse does it now. Added knowledge of the other protocols implemented in download.go (ftp, smb) Removed some modules that were unused in this commit. download.go: Moved the file-path conversions for the different protocols into their own internally callable functions. Shuffled some of the functions around in case someone wants to implement the ability to resume. Modified DownloadClient.Get to remove the CopyFile special case and trust the protocol implementations if a user doesn't want to copy the file. Since all the protocols except for HTTPDownloader implement Cancel, added a Resume method as a placeholder for another developer to implement. Added a few missing names from their function definitions. Fixed the syntax in a few lines due to my suckage at go. Adjusted the types for progress and total so that they support 64-bit sizes. Removed the usage of the bufio library since it wasn't really being used.	8 years ago
Ali Rizvi-Santiago	60831801a7	Added the file, ftp, and smb downloaders to common/download.go	8 years ago
Ali Rizvi-Santiago	da9c94b345	Added some testcases for the various file uri transforms to download_test.go ... Moved some of the code for normalizing a Windows file uri to a regular path into it's own function NormalizeWindowsURL	8 years ago
Ali Rizvi-Santiago	281dd1258a	Added proper support for downloading via a Windows UNC path or a relative uri. ... Added proper support for validating a downloadableURL containing a UNC or relative uri. Removed the workaround for an earlier Go issue that had remained dormant in common/download.go (issue #5927). When building a .vmx file via the vmware-iso builder, transform the path to the correct os-formatted one (using filepath.FromSlash).	8 years ago
SwampDragons	fb730cf521	Merge pull request #5761 from hashicorp/fix_5713 ... fix nasty edge case where we can't find guest additions on windows if they are on a different drive	8 years ago
Megan Marsh	bdd186fa2b	add tests for fileexistslocally helper function	8 years ago
Megan Marsh	3ace5bb91b	simplify FileExistsLocally	8 years ago
Megan Marsh	55ddbf4765	sloppy copypasta	8 years ago
Megan Marsh	898dadd53c	re-add this block. I still don't think we need it but I don't want to risk breaking things with this bugfix.	8 years ago
Megan Marsh	a04a921c2d	add UNC path to test cases, so I can try to enable it in future	8 years ago
Megan Marsh	154973241f	add a bunch of windows filepath tests	8 years ago
Megan Marsh	40f0cc6dfe	I don't think this is needed anymore	8 years ago
Megan Marsh	2838a2371d	disambiguate url variable from url library	8 years ago
Megan Marsh	216c44b153	fix FileExistsLocally	8 years ago
Megan Marsh	a3d5d40f78	reformat TestDownloadableURL into a table test to allow adding more URLS	8 years ago
Megan Marsh	4f3b470804	add helper function to manage validation of filepaths created using DownloadableURL	8 years ago
Megan Marsh	54bd057bb9	fix nasty edge case where we can't find guest additions on windows if they are on a different drive	8 years ago
SwampDragons	72afc2eab3	Merge pull request #5632 from VladRassokhin/do-not-donwload-twice ... Do not re-download iso multiple times from different urls	8 years ago
Vladislav Rassokhin	af8a0c46c5	Do not re-download iso multiple times from different urls ... In case of two or more iso_urls checks for downloaded files prior to downloading them. Speedups case when some iso already downloaded and another url prepended to iso_urls list.	8 years ago
Vijaya Bhaskar Reddy Kondreddi	b7e3f37b44	Add support for differential disk	8 years ago
Megan Marsh	3c20176dbb	runtime imported but not used	8 years ago
Megan Marsh	4fb8a27879	remove the actual offending code	8 years ago
Megan Marsh	74a4cc04fe	fix regression :(	8 years ago