312 Commits (ea2fdc25fa2701fae4b60259ccb7dac34afc5a13)

Author	SHA1	Message	Date
Adrien Delorme	48199c5aa8	add basic test to see if generated files are parseable	6 years ago
Adrien Delorme	ca23dab943	set correct type for PEM block	6 years ago
Adrien Delorme	750102901c	add cmd/ssh-keygen/main.go to try this on real servers	6 years ago
Adrien Delorme	0cf7af4247	add sshkey.Generate function	6 years ago
Ricardo Rosales	809f38be3a	[azure-chroot] Updating parameter `exlude_from_latest` to `exclude_from_latest` (#10034)	6 years ago
Marco Molteni	4d7e42220b	scaleway: add pre validate step (check image and snapshot names) (#9840) ... * Implement Stringer inteface for multistep.StepAction * scaleway: add pre validate step (check image and snapshot names) Before, it was possible to create multiple images with the same name, leading to a confusing and wasteful situation (same for snapshots). Now, we perform the same kind of checks done by the AWS EC2 builder, and refuse to proceed if there is an existing image with the same name (same for snapshots). As usual, invoking `packer build -force` will bypass the checks. Closes #9839.	6 years ago
Megan Marsh	94a9beaac6	fix up documentation for virtualbox key pair ssh options	6 years ago
Megan Marsh	5120ad9d9a	add test file	6 years ago
Megan Marsh	20d62654ae	move runAndStream into a generalized helper function to enable easy local exectution in other places than just the docker builder	6 years ago
Megan Marsh	2dcf950441	change pause to run connect again afterwards	6 years ago
Adrien Delorme	44616d3bff	refactor initialization out from packer configs + tests (#9627) ... The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost. This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too. fix #9478	6 years ago
Megan Marsh	a687d6fe12	ci/tech-debt: Fix vmware acceptance tests (#9636) ... * add kex algorithm option to ssh config * regenerate code * This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts: 1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed. 2) It modifies logic in reading and defaulting hardware config values, which was crashing. 3) It adds a new acceptance test with a preseed file to test loading from an http directory.	6 years ago
Adrien Delorme	125178d943	core: Decode: when in HCL2 decoding mode; reset the whole struct before preparing it. (#9622) ... * core: Decode when in HCL2 decoding mode; reset the whole struct before preparing it. * HCL2: add path variables + docs & tests Co-authored-by: Megan Marsh <megan@hashicorp.com>	6 years ago
Adrien Delorme	fd6be7f279	better/simpler `pause_before_connecting` example	6 years ago
Megan Marsh	530f5e3f63	more additions to partials	6 years ago
Roger Hu	31a7a1d637	adding basic support for OpenSSH CertificateFile support ... small fix	6 years ago
Sylvia Moss	9c1409dbba	Add content_library_destination to import VM template to a Content Library (#9551)	6 years ago
Moss	8ea64c5b35	undocument ssh_keypair_name and ssh_agent_auth	6 years ago
Moss	41edd09d3c	undocument temporary_key_pair_name and ssh_private_key_file	6 years ago
Megan Marsh	cacdb0ca02	add tests	6 years ago
Megan Marsh	4f77bb0c4a	add new ssh_ciphers option	6 years ago
Megan Marsh	a07563c64f	fix up typos in comments and regenerate docs. ... Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>	6 years ago
Megan Marsh	4178625afb	re-add winrm_no_proxy option. Winrm code needs to be modified in order to read no_proxy env var when client is created rather than when net/http library is instantiated.	6 years ago
Wilken Rivera	f672f5bd9b	command/validate: Add support for HCL2 configuration files ... * Update validate command to use FixConfig for checking against known fixers * Update validation command flag docs * Add ConfigFixer method to PackerHandler Interface * Implement ConfigFixer interface in PackerConfig * Remove all stdout messaging (i.e calls to c.Ui.Say) in the validate command. The command will only display hcl.Diagnotic messaging when there is an error or warning. HCL2 Configs ``` ⇶ packer validate docker_centos_shell_provisioner.pkr.hcl ``` JSON Configs ``` ⇶ packer validate vmware-iso_ubuntu_minimal/vmware-iso_ubuntu_minimal.json Error: Failed to prepare build: "vmware-iso" 1 error occurred: * Deprecated configuration key: 'iso_checksum_type'. Please call `packer fix` against your template to update your template to be compatable with the current version of Packer. Visit https://www.packer.io/docs/commands/fix/ for more detail. Warning: Fixable configuration found. You may need to run `packer fix` to get your build to run correctly. See debug log for more information. map[string]interface{}{ "builders": []interface{}{ map[string]interface{}{ ... // 3 identical entries "guest_os_type": string("ubuntu-64"), "http_directory": string("http"), - "iso_checksum": string("946a6077af6f5f95a51f82fdc44051c7aa19f9cfc5f737954845a6050543d7c2"), + "iso_checksum": string("sha256:946a6077af6f5f95a51f82fdc44051c7aa19f9cfc5f737954845a6050543d7c2"), - "iso_checksum_type": string("sha256"), "iso_url": string("http://old-releases.ubuntu.com/releases/14.04.1/ubuntu-14.04.1-server-amd64.iso"), "shutdown_command": string("echo 'vagrant' | sudo -S shutdown -P now"), ... // 4 identical entries }, }, } ```	6 years ago
Sylvia Moss	ce45a1990a	Refactor communicator config for Qemu and add SkipNatMapping option (#9307)	6 years ago
Megan Marsh	4698f90e65	update deprecated options	6 years ago
Megan Marsh	a94e147865	fix go fmt	6 years ago
Megan Marsh	b28059c0a5	add generator to create a list of all the deprecated options that the fixers fix ... fix location of deprecated_options code	6 years ago
Megan Marsh	15b14d4879	add deprecation check to config helper	6 years ago
Adrien Delorme	40947c2bf6	HCL2: generate hcl tags with go-cty tags too (#9306) ... This will allow to generate the config files: ```go package main import ( "fmt" "github.com/hashicorp/hcl/v2/gohcl" "github.com/hashicorp/hcl/v2/hclwrite" "github.com/hashicorp/packer/builder/alicloud/ecs" ) func main() { name := "name" app := ecs.FlatConfig{ AlicloudImageName: &name, ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{ DiskName: &name, }, } f := hclwrite.NewEmptyFile() block := gohcl.EncodeAsBlock(&app, `source "something" "something"`) f.Body().AppendBlock(block) fmt.Printf("%s", f.Bytes()) } ``` Will output: ``` source "something" "something" { packer_user_variables = null packer_sensitive_variables = null image_name = "name" image_share_account = null image_unshare_account = null image_copy_regions = null image_copy_names = null tags = null tag = null system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_ snapshot_id = null } image_disk_mappings = null ssh_remote_tunnels = null ssh_local_tunnels = null ssh_public_key = null ssh_private_key = null } ``` This is a good first step for #9015 and #9282 fix #9304	6 years ago
Megan Marsh	3dc4ba2d68	Json vs HCL2 parity refactor (#9301) ... * refactor so that json and hcl2 templates are both prepared in the same place in the build call, to make code easier to reason about. Remove overly verbose error output which isn't useful in vast majority of cases * fix tests * check err msg * hcl2template.PackerConfig.GetBuilds: raise a diagnostic in case the packer core build perpare call errors Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>	6 years ago
Sylvia Moss	1c30a71d09	Replace file shared state by statebag (#9238)	6 years ago
Megan Marsh	7e0cfd8b77	add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs	6 years ago
Megan Marsh	217dcbb97f	golang 1.14 doesn't like calling NewFile on existing files. Port solution over from Terraform	6 years ago
Jeff Escalante	2999934326	fix generation script, bugfixes in source comments, update website paths in primary codebase	6 years ago
Jeff Escalante	4afd107eeb	patch source files for extensions changes	6 years ago
Wilken Rivera	360f81b030	tests/provisioners: Add TestProvsionerPreCheck function ... This function can be used to check if a Provisioner has been marked for testing within the ACC_TEST_PROVISIONERS environment variable. While testing I found that the shell acceptance test were also running when trying to run powershell tests. Before change ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h === RUN TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner 2020/04/06 15:18:12 ui: amazon-ebs: output will be in this color. 2020/04/06 15:18:12 ui: 2020/04/06 15:18:12 Build debug mode: false 2020/04/06 15:18:12 Force build: false 2020/04/06 15:18:12 On error: 2020/04/06 15:18:12 Preparing build: amazon-ebs 2020/04/06 15:18:12 Waiting on builds to complete... 2020/04/06 15:18:12 Starting build run: amazon-ebs 2020/04/06 15:18:12 Running builder: amazon-ebs ``` After changes ``` ⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/shell/... -timeout=1h --- SKIP: TestShellProvisioner (0.00s) provisioners.go:88: Provisioner "shell" not defined in ACC_TEST_PROVISIONERS ```	6 years ago
Sylvia Moss	665330de92	Write generic Builder-Provisioner acceptance test logic (#8963)	6 years ago
Adrien Delorme	88297c796d	Merge branch 'master' into hcl2_singular_blocks	6 years ago
Adrien Delorme	834f44190f	go generate	6 years ago
Adrien Delorme	87d6b2433f	make generate	6 years ago
Megan Marsh	fc35f02004	Merge pull request #8890 from hashicorp/fix_8880 ... fix googlecompute password interpolation	6 years ago
Megan Marsh	e94ff70199	Merge pull request #8883 from hashicorp/fix_8835 ... Interpolate shell inline config	6 years ago
Megan Marsh	6477d8a0c8	Merge pull request #8882 from hashicorp/fix-var-file-hcl ... allow to use hcl files as var files in HCL mode	6 years ago
Megan Marsh	6008f911fd	Merge pull request #8847 from takaishi/support-keyboard-interactive ... communicator/ssh: support keyboard-interactive auth to connect bastion	6 years ago
Megan Marsh	bcb7b8751c	fix googlecompute password interpolation	6 years ago
Moss	5a8c628880	Add acc test validation to avoid running with unit tests	6 years ago
Moss	3f49b7c66e	Fix linter	6 years ago
Moss	2ca6804827	Move shell prov acc test to the same folder	6 years ago
Adrien Delorme	60a3105a45	make ssh docs less AWS specific	6 years ago
r_takaishi	70e3f60539	write unit test	6 years ago
r_takaishi	f50ff1d270	make generate	6 years ago
Adrien Delorme	7ec39ebb4e	TestStringSlice_Set: check error even if none is returned	6 years ago
Adrien Delorme	6b48feb817	kvflag: add TestStringSlice_Set	6 years ago
Adrien Delorme	c8300b620a	allow to use hcl files as var files in HCL mode ... fix #8781	6 years ago
Wilken Rivera	7b705545d9	docs: Various doc clean-ups to fix code block formatting and syntax highlighting (#8868)	6 years ago
r_takaishi	34bb0429d0	keyboard-interactive used when ssh_bastion_host is true.	6 years ago
Sylvia Moss	76f13deaf4	Make template variables SSHPublicKey and SSHPrivateKey as strings (#8829)	6 years ago
Lars Lehtonen	74a94d8547	helper/builder/testing: prune unused functions (#8852)	6 years ago
r_takaishi	e2df4a80f8	support keyboard interactive auth	6 years ago
Wilken Rivera	9ec8b67392	Add golangci-lint to project (#8686) ... * Add golangci-lint as linting tool * Disable failing staticchecks to start; GitHub issue to handle coming soon * Run `goimports -w` to repair all source files that have improperly formatted imports * makefile: Add ci-lint target to run on travis This change adds a new make target for running golangci-lint on newly added Go files only. This target is expected to run during Packer ci builds. * .github/contributing: Add code linting instructions * travis: Update job configuration to run parallel builds	6 years ago
Megan Marsh	d252a24b82	allow user to set winrm_host override like we do ssh_host override	6 years ago
Sylvia Moss	0677b02e18	Share SourceImageName with provisioners and manifest post-processor (#8603)	6 years ago
Megan Marsh	82f03fca7c	fix to work with hcl2; update tests	6 years ago
Megan Marsh	4059ed75f5	update docs to mention ssh auth sock env var (#8523) ... Closes #8358 Add some docs to alleviate confusion.	6 years ago
Megan Marsh	cd7abf1f9e	clean up a few final issues with info sharing	6 years ago
Adrien Delorme	4b7132c87c	Merge remote-tracking branch 'origin/master' into sharing_info	6 years ago
Adrien Delorme	0785c2f6fc	build using HCL2 (#8423) ... This follows #8232 which added the code to generate the code required to parse HCL files for each packer component. All old config files of packer will keep on working the same. Packer takes one argument. When a directory is passed, all files in the folder with a name ending with “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format. When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed using the HCL2 format. For every other case; the old packer style will be used. ## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields ## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file. This is a breaking change for packer plugins. a packer component can be a: builder/provisioner/post-processor each component interface now gets a `ConfigSpec() hcldec.ObjectSpec` which allows packer to tell what is the layout of the hcl2 config meant to configure that specific component. This ObjectSpec is sent through the wire (RPC) and a cty.Value is now sent through the already existing configuration entrypoints: Provisioner.Prepare(raws ...interface{}) error Builder.Prepare(raws ...interface{}) ([]string, error) PostProcessor.Configure(raws ...interface{}) error close #1768 Example hcl files: ```hcl // file amazon-ebs-kms-key/run.pkr.hcl build { sources = [ "source.amazon-ebs.first", ] provisioner "shell" { inline = [ "sleep 5" ] } post-processor "shell-local" { inline = [ "sleep 5" ] } } // amazon-ebs-kms-key/source.pkr.hcl source "amazon-ebs" "first" { ami_name = "hcl2-test" region = "us-east-1" instance_type = "t2.micro" kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c" encrypt_boot = true source_ami_filter { filters { virtualization-type = "hvm" name = "amzn-ami-hvm-????.??.?.????????-x86_64-gp2" root-device-type = "ebs" } most_recent = true owners = ["amazon"] } launch_block_device_mappings { device_name = "/dev/xvda" volume_size = 20 volume_type = "gp2" delete_on_termination = "true" } launch_block_device_mappings { device_name = "/dev/xvdf" volume_size = 500 volume_type = "gp2" delete_on_termination = true encrypted = true } ami_regions = ["eu-central-1"] run_tags { Name = "packer-solr-something" stack-name = "DevOps Tools" } communicator = "ssh" ssh_pty = true ssh_username = "ec2-user" associate_public_ip_address = true } ```	6 years ago
Megan Marsh	0f6d1beccf	add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables.	6 years ago
Megan Marsh	82367a88f8	reorganize placeholder data call to live with provisioner implementation; force users to use the generated function, therefore forcing validation, for all variables except winrmpassword, by doing a simple string check against the placeholder data.	6 years ago
Megan Marsh	6f418d0e54	get data sharing to a working state with the powershell provisioner	6 years ago
nywilken	a61fe833ef	helper/communicator/step_connect_ssh: Update proxy connection settings to use `SSHProxyUsername` and `SSHProxyPassword`	7 years ago
Adrien Delorme	819329228a	Change back to make sure all durations are a time.Duration ... It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because: * we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.) * we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config. * the hcl2 generated code asks for a string, so this will be enforced by default.	7 years ago
Adrien Delorme	bf3d9841c6	Force durations to be passed a strings ... Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".	7 years ago
Adrien Delorme	078ba7c8c3	commit old code generation tool ... for history	7 years ago
Chris Roberts	8bb7d8dc16	Prevent busy loop while waiting for WinRM connection ... Set first run variable outside conditional so it will properly be updated during the first run and pause on subsequent runs.	7 years ago
Megan Marsh	85de1d0637	make friendlier message warning user that their creds may be wrong	7 years ago
Adrien Delorme	3fe9d52e3f	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Daniel Kimsey	3b64620234	SSH tunneling support ... Support for both local and remote TCP port tunneling. Includes updated docs and tests. Does not implement dynamic port forwarding (SSH's built-in SOCKS) (uncertain difficulty) nor unix socket (potentially easy).	7 years ago
Adrien Delorme	5517d41468	make sure all documentation fields are there ... * add missing `temporary_key_pair_name` field for alicloud * add missing description to `vpc_filter` for aws * add missing ssh communicator fields for aws * add links for aws * update vmware-vmx docs * manually describe AMI Configuration section for ebsvolume * display missing required ami_name field for aws * add missing fields for docker * add missing fields for openstack	7 years ago
Adrien Delorme	db880ab50a	add decoding tests for trilean	7 years ago
Megan Marsh	3c3f7f26ce	implement custom data type "trilean" (tri-state-boolean) to track booleans which have a "null" or "unset" state. Previously we used *bool for these template options, but it turns out that those won't work because "unset" will evaluate to "false" if a user is using template variables to set the option that maps to a *bool.	7 years ago
Adrien Delorme	4cb7c30987	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Stephen Fox	9592211bcf	Honor value of 'Comment' field in 'ssh.KeyPairFromPrivateKey()'. ... The 'ssh.KeyPairFromPrivateKey()' function in the 'ssh' helper library was not honoring the value of the 'Comment' field in the 'FromPrivateKeyConfig' struct. This commit fixes the issue, and updates unit tests to catch the issue if it happens again.	7 years ago
Vladislav Rassokhin	19e8f150a3	Use context for timeouts, interruption in ssh and winrm communicators ... Also don't waste 5 seconds waiting before first winrm connection attempt Minor code cleanup as well	7 years ago
Megan Marsh	ba66d5d857	Merge pull request #7831 from hashicorp/fix_ssh_interface ... Revert "move SSHInterface/SSHIPVersion fields to communitator.Config …	7 years ago
Megan Marsh	242f5b1c9f	typos	7 years ago
Megan Marsh	8718e98efe	add common commHost function	7 years ago
Megan Marsh	6ad975f296	Revert "move SSHInterface/SSHIPVersion fields to communitator.Config struct" ... This reverts commit b0c09087a2.	7 years ago
Adrien Delorme	6e3dc1aa9a	Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config	7 years ago
Adrien Delorme	d16fd8a2b1	allow to build on solaris	7 years ago
Megan Marsh	df916e805e	borrow wrappedreadline workarounds from terraform and implement a similar check for piped commands; this makes the cli experience much cleaner	7 years ago
Adrien Delorme	4bf6a56d71	split communitacor.SSH & communitacor.WinRM to facilitate documentation ... put doc for communicator into the struct	7 years ago
Adrien Delorme	e96409954a	add execution policy type and use it to default the powershell cmd	7 years ago
Adrien Delorme	f555e7a9f2	allow a provisioner to timeout ... * I had to contextualise Communicator.Start and RemoteCmd.StartWithUi NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer. Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock * cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions * also had to simplify StartWithUi	7 years ago
Adrien Delorme	a81abd297b	Merge remote-tracking branch 'origin/master' into context_provisioner	7 years ago
Adrien Delorme	c4f3dccc14	rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts	7 years ago
Adrien Delorme	82c4b76639	[Builder|Build|PostProcessor|Provisioner|Hook]Server: context cancel using a RPC cancel method	7 years ago
Adrien Delorme	cccbd7f316	contextualize basic runner	7 years ago
Adrien Delorme	a4bf94dd3c	change Builder to be passed a context for cancellation ... we have to to give it to our hook	7 years ago